From: Jakub Kicinski <kuba@kernel.org>
To: Sieng Piaw Liew <liew.s.piaw@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/6] bcm63xx_enet: add xmit_more support
Date: Mon, 28 Dec 2020 12:40:24 -0800 [thread overview]
Message-ID: <20201228124024.32ceb0fc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201224142421.32350-4-liew.s.piaw@gmail.com>
On Thu, 24 Dec 2020 22:24:18 +0800 Sieng Piaw Liew wrote:
> Support bulking hardware TX queue by using netdev_xmit_more().
>
> Signed-off-by: Sieng Piaw Liew <liew.s.piaw@gmail.com>
> ---
> drivers/net/ethernet/broadcom/bcm63xx_enet.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> index 90f8214b4d22..452968f168ed 100644
> --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> @@ -633,14 +633,17 @@ bcm_enet_start_xmit(struct sk_buff *skb, struct net_device *dev)
>
> netdev_sent_queue(dev, skb->len);
>
> - /* kick tx dma */
> - enet_dmac_writel(priv, priv->dma_chan_en_mask,
> - ENETDMAC_CHANCFG, priv->tx_chan);
> -
> /* stop queue if no more desc available */
> if (!priv->tx_desc_count)
> netif_stop_queue(dev);
>
> + /* kick tx dma */
> + if (!netdev_xmit_more() || !priv->tx_desc_count)
> + enet_dmac_writel(priv, priv->dma_chan_en_mask,
> + ENETDMAC_CHANCFG, priv->tx_chan);
> +
> +
> +
> dev->stats.tx_bytes += skb->len;
> dev->stats.tx_packets++;
> ret = NETDEV_TX_OK;
Please address checkpatch --strict issues throughout the series:
ERROR: code indent should use tabs where possible
#31: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:641:
+ if (!netdev_xmit_more() || !priv->tx_desc_count)$
WARNING: please, no spaces at the start of a line
#31: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:641:
+ if (!netdev_xmit_more() || !priv->tx_desc_count)$
ERROR: code indent should use tabs where possible
#32: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:642:
+ enet_dmac_writel(priv, priv->dma_chan_en_mask,$
WARNING: please, no spaces at the start of a line
#32: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:642:
+ enet_dmac_writel(priv, priv->dma_chan_en_mask,$
ERROR: code indent should use tabs where possible
#33: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:643:
+ ENETDMAC_CHANCFG, priv->tx_chan);$
WARNING: please, no spaces at the start of a line
#33: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:643:
+ ENETDMAC_CHANCFG, priv->tx_chan);$
CHECK: Please don't use multiple blank lines
#35: FILE: drivers/net/ethernet/broadcom/bcm63xx_enet.c:645:
+
+
next prev parent reply other threads:[~2020-12-28 23:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 14:24 [PATCH net-next v2 0/6] bcm63xx_enet: major makeover of driver Sieng Piaw Liew
2020-12-24 14:24 ` [PATCH net-next v2 1/6] bcm63xx_enet: batch process rx path Sieng Piaw Liew
2020-12-29 3:11 ` Florian Fainelli
2020-12-24 14:24 ` [PATCH net-next v2 2/6] bcm63xx_enet: add BQL support Sieng Piaw Liew
2020-12-29 3:12 ` Florian Fainelli
2020-12-24 14:24 ` [PATCH net-next v2 3/6] bcm63xx_enet: add xmit_more support Sieng Piaw Liew
2020-12-28 20:40 ` Jakub Kicinski [this message]
2020-12-29 3:13 ` Florian Fainelli
2020-12-24 14:24 ` [PATCH net-next v2 4/6] bcm63xx_enet: alloc rx skb with NET_IP_ALIGN Sieng Piaw Liew
2020-12-29 3:14 ` Florian Fainelli
2020-12-24 14:24 ` [PATCH net-next v2 5/6] bcm63xx_enet: convert to build_skb Sieng Piaw Liew
2020-12-29 3:24 ` Florian Fainelli
2020-12-24 14:24 ` [PATCH net-next v2 6/6] bcm63xx_enet: improve rx loop Sieng Piaw Liew
2020-12-29 3:17 ` Florian Fainelli
2020-12-28 20:39 ` [PATCH net-next v2 0/6] bcm63xx_enet: major makeover of driver Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228124024.32ceb0fc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=liew.s.piaw@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).