archive mirror
 help / color / mirror / Atom feed
From: Nathan Chancellor <>
To: Marc Zyngier <>
Cc: James Morse <>,
	Julien Thierry <>,
	Suzuki K Poulose <>,
	Catalin Marinas <>,
	Will Deacon <>,,,,,
	Nathan Chancellor <>
Subject: [PATCH] KVM: arm64: Fix section mismatches around hyp_cpu_pm_{init,exit}
Date: Tue, 29 Dec 2020 14:43:36 -0700	[thread overview]
Message-ID: <> (raw)

Commit fa8c3d65538a ("KVM: arm64: Keep nVHE EL2 vector installed")
inadvertently changed clang's inlining decisions around
hyp_cpu_pm_{init,exit}, causing the following section mismatch warnings:

WARNING: modpost: vmlinux.o(.text+0x95c6c): Section mismatch in
reference from the function kvm_arch_init() to the function
The function kvm_arch_init() references
the function __init hyp_cpu_pm_exit().
This is often because kvm_arch_init lacks a __init
annotation or the annotation of hyp_cpu_pm_exit is wrong.

WARNING: modpost: vmlinux.o(.text+0x97054): Section mismatch in
reference from the function init_subsystems() to the function
The function init_subsystems() references
the function __init hyp_cpu_pm_init().
This is often because init_subsystems lacks a __init
annotation or the annotation of hyp_cpu_pm_init is wrong.

Remove the __init annotation so that there are no warnings regardless of
how functions are inlined.

Fixes: 1fcf7ce0c602 ("arm: kvm: implement CPU PM notifier")
Fixes: 06a71a24bae5 ("arm64: KVM: unregister notifiers in hyp mode teardown path")
Signed-off-by: Nathan Chancellor <>
 arch/arm64/kvm/arm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
index 6e637d2b4cfb..71a49eae9ea0 100644
--- a/arch/arm64/kvm/arm.c
+++ b/arch/arm64/kvm/arm.c
@@ -1574,12 +1574,12 @@ static struct notifier_block hyp_init_cpu_pm_nb = {
 	.notifier_call = hyp_init_cpu_pm_notifier,
-static void __init hyp_cpu_pm_init(void)
+static void hyp_cpu_pm_init(void)
 	if (!is_protected_kvm_enabled())
-static void __init hyp_cpu_pm_exit(void)
+static void hyp_cpu_pm_exit(void)
 	if (!is_protected_kvm_enabled())

base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e

             reply	other threads:[~2020-12-29 21:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-29 21:43 Nathan Chancellor [this message]
2020-12-29 22:11 ` Marc Zyngier
2020-12-29 22:33   ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] KVM: arm64: Fix section mismatches around hyp_cpu_pm_{init,exit}' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox