From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH 1/2] rtc: goldfish: Remove GOLDFISH dependency
Date: Mon, 4 Jan 2021 15:48:41 +0100 [thread overview]
Message-ID: <20210104144841.GC3313@piout.net> (raw)
In-Reply-To: <CAMuHMdXo9o9af-YBt5g53QHRhuLxdSy_C9n4wdEEh7yzDidr-w@mail.gmail.com>
Hi Geert,
On 04/01/2021 14:28:26+0100, Geert Uytterhoeven wrote:
> Hi Jiaxun,
>
> On Sat, Nov 14, 2020 at 2:20 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> > Goldfish platform is covered with dust.
> > However the goldfish-rtc had been used as virtualized RTC
> > in QEMU for RISC-V virt hw and MIPS loongson3-virt hw, thus
> > we can drop other parts of goldfish but leave goldfish-rtc here.
> >
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>
> Thanks for your patch!
>
> > --- a/drivers/rtc/Kconfig
> > +++ b/drivers/rtc/Kconfig
> > @@ -1935,7 +1935,6 @@ config RTC_DRV_HID_SENSOR_TIME
> > config RTC_DRV_GOLDFISH
> > tristate "Goldfish Real Time Clock"
> > depends on OF && HAS_IOMEM
> > - depends on GOLDFISH || COMPILE_TEST
> > help
> > Say yes to enable RTC driver for the Goldfish based virtual platform.
>
> I was just looking to see if someone had already sent a patch to add
> "depends on GOLDFISH || COMPILE_TEST", before sending one myself, when I
> noticed your patch had removed it...
>
> What about
>
> depends on CPU_LOONGSON64 || GOLDFISH || RISCV || COMPILE_TEST
>
> instead?
>
But this driver also works on ARM, is it really important to restrict to
a few architectures ?
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-01-04 14:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 13:09 [PATCH 0/2] Preserve goldfish rtc Jiaxun Yang
2020-11-14 13:09 ` [PATCH 1/2] rtc: goldfish: Remove GOLDFISH dependency Jiaxun Yang
2021-01-04 13:28 ` Geert Uytterhoeven
2021-01-04 14:48 ` Alexandre Belloni [this message]
2021-01-04 15:21 ` Geert Uytterhoeven
2021-01-04 15:43 ` Alexandre Belloni
2021-01-04 15:51 ` Geert Uytterhoeven
2021-01-06 13:27 ` Alexandre Belloni
2020-11-14 13:09 ` [PATCH 2/2] MAINTAINERS: Set myself as Goldfish RTC maintainer Jiaxun Yang
2020-11-14 18:25 ` Sergei Shtylyov
2020-11-16 11:06 ` Miodrag Dinic
2020-11-14 23:39 ` [PATCH 0/2] Preserve goldfish rtc Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104144841.GC3313@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=geert@linux-m68k.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).