From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA3DC433DB for ; Tue, 5 Jan 2021 03:18:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36CEB22581 for ; Tue, 5 Jan 2021 03:18:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728332AbhAEDSA (ORCPT ); Mon, 4 Jan 2021 22:18:00 -0500 Received: from owa.iluvatar.ai ([103.91.158.24]:6093 "EHLO smg.iluvatar.ai" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726599AbhAEDSA (ORCPT ); Mon, 4 Jan 2021 22:18:00 -0500 X-AuditID: 0a650161-e51ff70000001043-b0-5ff3da38862c Received: from owa.iluvatar.ai (s-10-101-1-102.iluvatar.local [10.101.1.102]) by smg.iluvatar.ai (Symantec Messaging Gateway) with SMTP id A4.FB.04163.83AD3FF5; Tue, 5 Jan 2021 11:17:12 +0800 (HKT) Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; d=iluvatar.ai; s=key_2018; c=relaxed/relaxed; t=1609816632; h=from:subject:to:date:message-id; bh=bh/KlAKtf2is8XgpiGQlUbIlz9Cl49eRRpOLayL9zlI=; b=jqNgsXGg612hjuVZr2jcZZfLYgJlk0Q3kQURO63DaAoo5B53K5ZO0mXfQNh+Li7KpodGwuplyTB xp4mBZ3nTq9hfeUINe1GW1IfWRnc0G6bMfjuDGxysgrSJpIx+DZfB7sGTmzpbqldGugE00ZVI526L AVTcDEHqtdITdqxVrD4= Received: from hsj-Precision-5520.iluvatar.local (10.101.199.252) by S-10-101-1-102.iluvatar.local (10.101.1.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1415.2; Tue, 5 Jan 2021 11:17:12 +0800 From: Huang Shijie To: CC: , , Huang Shijie Subject: [PATCH] lib/genalloc: change return type to unsigned long for bitmap_set_ll Date: Tue, 5 Jan 2021 11:16:44 +0800 Message-ID: <20210105031644.2771-1-sjhuang@iluvatar.ai> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.101.199.252] X-ClientProxiedBy: S-10-101-1-105.iluvatar.local (10.101.1.105) To S-10-101-1-102.iluvatar.local (10.101.1.102) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just as bitmap_clear_ll(), change return type to unsigned long for bitmap_set_ll to avoid the possible overflow in future. Signed-off-by: Huang Shijie --- This patch is not a bug fix. I missed to change it in previous patch. --- lib/genalloc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/genalloc.c b/lib/genalloc.c index dab97bb69df6..5dcf9cdcbc46 100644 --- a/lib/genalloc.c +++ b/lib/genalloc.c @@ -81,7 +81,8 @@ static int clear_bits_ll(unsigned long *addr, unsigned long mask_to_clear) * users set the same bit, one user will return remain bits, otherwise * return 0. */ -static int bitmap_set_ll(unsigned long *map, unsigned long start, unsigned long nr) +static unsigned long +bitmap_set_ll(unsigned long *map, unsigned long start, unsigned long nr) { unsigned long *p = map + BIT_WORD(start); const unsigned long size = start + nr; -- 2.17.1