[PATCH v2 00/18] Devicetree update for SDX55 platform

[PATCH v2 00/18] Devicetree update for SDX55 platform

[Manivannan Sadhasivam]

Hi Bjorn,

This series updates devicetree for the SDX55 platform and the MTP board.
Most of the SDX55 specific driver codes are already merged and some of
existing driver support got reused.

Thanks,
Mani

Changes in v2:

* Changed "SoC" to "platform" and modified FIXME in commit message

Bjorn Andersson (1):
  ARM: dts: qcom: sdx55: Enable ARM SMMU

Manivannan Sadhasivam (9):
  dt-bindings: mmc: sdhci-msm: Document the SDX55 compatible
  ARM: dts: qcom: sdx55: Add support for SDHCI controller
  dt-bindings: arm-smmu: Add binding for Qcom SDX55 SMMU
  ARM: dts: qcom: sdx55: Add support for TCSR Mutex
  ARM: dts: qcom: sdx55: Add Shared memory manager support
  ARM: dts: qcom: sdx55: Add QPIC BAM support
  ARM: dts: qcom: sdx55: Add QPIC NAND support
  ARM: dts: qcom: sdx55-mtp: Enable BAM DMA
  ARM: dts: qcom: sdx55-mtp: Enable QPIC NAND

Vinod Koul (8):
  ARM: dts: qcom: sdx55: Add pincontrol node
  ARM: dts: qcom: sdx55: Add reserved memory nodes
  ARM: dts: qcom: sdx55: Add spmi node
  ARM: dts: qcom: sdx55-mtp: Add pm8150b pmic
  ARM: dts: qcom: sdx55-mtp: Add pmx55 pmic
  ARM: dts: qcom: sdx55: Add rpmpd node
  ARM: dts: qcom: Add PMIC pmx55 dts
  ARM: dts: qcom: sdx55-mtp: Add regulator nodes

 .../devicetree/bindings/iommu/arm,smmu.yaml   |   1 +
 .../devicetree/bindings/mmc/sdhci-msm.txt     |   1 +
 arch/arm/boot/dts/qcom-pmx55.dtsi             |  91 +++++++
 arch/arm/boot/dts/qcom-sdx55-mtp.dts          | 197 +++++++++++++++
 arch/arm/boot/dts/qcom-sdx55.dtsi             | 234 ++++++++++++++++++
 5 files changed, 524 insertions(+)
 create mode 100644 arch/arm/boot/dts/qcom-pmx55.dtsi

-- 
2.25.1

[PATCH v2 01/18] ARM: dts: qcom: sdx55: Add pincontrol node

[Manivannan Sadhasivam]

From: Vinod Koul <vkoul@kernel.org>

This adds pincontrol node to SDX55 dts.

Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index ca7d4e4f5d11..08b4a40338fa 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -96,6 +96,16 @@ pdc: interrupt-controller@b210000 {
 			interrupt-controller;
 		};
 
+		tlmm: pinctrl@f100000 {
+			compatible = "qcom,sdx55-pinctrl";
+			reg = <0xf100000 0x300000>;
+			interrupts = <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+
 		intc: interrupt-controller@17800000 {
 			compatible = "qcom,msm-qgic2";
 			interrupt-controller;
-- 
2.25.1

[PATCH v2 02/18] ARM: dts: qcom: sdx55: Add reserved memory nodes

[Manivannan Sadhasivam]

From: Vinod Koul <vkoul@kernel.org>

This adds reserved memory nodes to the SDX55 dtsi as defined by v8 of
the memory map

Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 67 +++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index 08b4a40338fa..eeb6bf392f93 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -60,6 +60,73 @@ psci {
 		method = "smc";
 	};
 
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		mpss_debug_mem: memory@8ef00000 {
+			no-map;
+			reg = <0x8ef00000 0x800000>;
+		};
+
+		hyp_mem: memory@8fc00000 {
+			no-map;
+			reg = <0x8fc00000 0x80000>;
+		};
+
+		ac_db_mem: memory@8fc80000 {
+			no-map;
+			reg = <0x8fc80000 0x40000>;
+		};
+
+		secdata_mem: memory@8fcfd000 {
+			no-map;
+			reg = <0x8fcfd000 0x1000>;
+		};
+
+		ipa_fw_mem: memory@8fced000 {
+			no-map;
+			reg = <0x8fced000 0x10000>;
+		};
+
+		sbl_mem: memory@8fd00000 {
+			no-map;
+			reg = <0x8fd00000 0x100000>;
+		};
+
+		aop_image: memory@8fe00000 {
+			no-map;
+			reg = <0x8fe00000 0x20000>;
+		};
+
+		aop_cmd_db: memory@8fe20000 {
+			compatible = "qcom,cmd-db";
+			reg = <0x8fe20000 0x20000>;
+			no-map;
+		};
+
+		smem_mem: memory@8fe40000 {
+			no-map;
+			reg = <0x8fe40000 0xc0000>;
+		};
+
+		tz_mem: memory@8ff00000 {
+			no-map;
+			reg = <0x8ff00000 0x100000>;
+		};
+
+		tz_apps_mem: memory@0x90000000 {
+			no-map;
+			reg = <0x90000000 0x500000>;
+		};
+
+		mpss_adsp_mem: memory@90800000 {
+			no-map;
+			reg = <0x90800000 0xf800000>;
+		};
+	};
+
 	soc: soc {
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.25.1

[PATCH v2 03/18] dt-bindings: mmc: sdhci-msm: Document the SDX55 compatible

[Manivannan Sadhasivam]

The SDHCI controller on SDX55 is based on MSM SDHCI v5 IP. Hence,
document the compatible with "qcom,sdhci-msm-v5" as the fallback.

Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
index 3b602fd6180b..31f4a5628595 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
@@ -21,6 +21,7 @@ Required properties:
 		"qcom,sdm845-sdhci", "qcom,sdhci-msm-v5"
 		"qcom,qcs404-sdhci", "qcom,sdhci-msm-v5"
 		"qcom,sc7180-sdhci", "qcom,sdhci-msm-v5";
+		"qcom,sdx55-sdhci", "qcom,sdhci-msm-v5";
 	NOTE that some old device tree files may be floating around that only
 	have the string "qcom,sdhci-msm-v4" without the SoC compatible string
 	but doing that should be considered a deprecated practice.
-- 
2.25.1

[PATCH v2 04/18] ARM: dts: qcom: sdx55: Add support for SDHCI controller

[Manivannan Sadhasivam]

Add devicetree support for SDHCI controller found in Qualcomm SDX55 SoC.
The SDHCI controller used in this SoC is based on the MSM SDHCI v5 IP.
Hence, the support is added by reusing the existing sdhci driver with
"qcom,sdhci-msm-v5" as the fallback.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index eeb6bf392f93..3f8e98bfc020 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -154,6 +154,18 @@ blsp1_uart3: serial@831000 {
 			status = "disabled";
 		};
 
+		sdhc_1: sdhci@8804000 {
+			compatible = "qcom,sdx55-sdhci", "qcom,sdhci-msm-v5";
+			reg = <0x08804000 0x1000>;
+			interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "hc_irq", "pwr_irq";
+			clocks = <&gcc GCC_SDCC1_AHB_CLK>,
+				 <&gcc GCC_SDCC1_APPS_CLK>;
+			clock-names = "iface", "core";
+			status = "disabled";
+		};
+
 		pdc: interrupt-controller@b210000 {
 			compatible = "qcom,sdx55-pdc", "qcom,pdc";
 			reg = <0x0b210000 0x30000>;
-- 
2.25.1

[PATCH v2 05/18] dt-bindings: arm-smmu: Add binding for Qcom SDX55 SMMU

[Manivannan Sadhasivam]

Add devicetree binding for Qualcomm SDX55 SMMU.

Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
index 3b63f2ae24db..cc48d90de5fe 100644
--- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
+++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
@@ -37,6 +37,7 @@ properties:
               - qcom,sdm845-smmu-500
               - qcom,sm8150-smmu-500
               - qcom,sm8250-smmu-500
+              - qcom,sdx55-smmu-500
           - const: arm,mmu-500
       - description: Qcom Adreno GPUs implementing "arm,smmu-v2"
         items:
-- 
2.25.1

[PATCH v2 06/18] ARM: dts: qcom: sdx55: Enable ARM SMMU

[Manivannan Sadhasivam]

From: Bjorn Andersson <bjorn.andersson@linaro.org>

Add a node for the ARM SMMU found in the SDX55.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index 3f8e98bfc020..927f43a7414c 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -185,6 +185,30 @@ tlmm: pinctrl@f100000 {
 			#interrupt-cells = <2>;
 		};
 
+		apps_smmu: iommu@15000000 {
+			compatible = "qcom,sdx55-smmu-500", "arm,mmu-500";
+			reg = <0x15000000 0x20000>;
+			#iommu-cells = <2>;
+			#global-interrupts = <1>;
+			interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
+		};
+
 		intc: interrupt-controller@17800000 {
 			compatible = "qcom,msm-qgic2";
 			interrupt-controller;
-- 
2.25.1

[PATCH v2 07/18] ARM: dts: qcom: sdx55: Add support for TCSR Mutex

[Manivannan Sadhasivam]

Add TCSR Mutex node to support Qualcomm Hardware Mutex block on SDX55
platform.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index 927f43a7414c..e48ec7a1971b 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -166,6 +166,17 @@ sdhc_1: sdhci@8804000 {
 			status = "disabled";
 		};
 
+		tcsr_mutex_block: syscon@1f40000 {
+			compatible = "syscon";
+			reg = <0x1f40000 0x20000>;
+		};
+
+		tcsr_mutex: hwlock {
+			compatible = "qcom,tcsr-mutex";
+			syscon = <&tcsr_mutex_block 0 0x1000>;
+			#hwlock-cells = <1>;
+		};
+
 		pdc: interrupt-controller@b210000 {
 			compatible = "qcom,sdx55-pdc", "qcom,pdc";
 			reg = <0x0b210000 0x30000>;
-- 
2.25.1

[PATCH v2 08/18] ARM: dts: qcom: sdx55: Add Shared memory manager support

[Manivannan Sadhasivam]

Add smem node to support shared memory manager on SDX55 platform.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index e48ec7a1971b..622a63b0058f 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -177,6 +177,12 @@ tcsr_mutex: hwlock {
 			#hwlock-cells = <1>;
 		};
 
+		smem {
+			compatible = "qcom,smem";
+			memory-region = <&smem_mem>;
+			hwlocks = <&tcsr_mutex 3>;
+		};
+
 		pdc: interrupt-controller@b210000 {
 			compatible = "qcom,sdx55-pdc", "qcom,pdc";
 			reg = <0x0b210000 0x30000>;
-- 
2.25.1

[PATCH v2 09/18] ARM: dts: qcom: sdx55: Add QPIC BAM support

[Manivannan Sadhasivam]

Add qpic_bam node to support QPIC BAM DMA controller on SDX55 platform.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index 622a63b0058f..1b9b990ad0a2 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -166,6 +166,18 @@ sdhc_1: sdhci@8804000 {
 			status = "disabled";
 		};
 
+		qpic_bam: dma@1b04000 {
+			compatible = "qcom,bam-v1.7.0";
+			reg = <0x01b04000 0x1c000>;
+			interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&rpmhcc RPMH_QPIC_CLK>;
+			clock-names = "bam_clk";
+			#dma-cells = <1>;
+			qcom,ee = <0>;
+			qcom,controlled-remotely;
+			status = "disabled";
+		};
+
 		tcsr_mutex_block: syscon@1f40000 {
 			compatible = "syscon";
 			reg = <0x1f40000 0x20000>;
-- 
2.25.1

[PATCH v2 10/18] ARM: dts: qcom: sdx55: Add QPIC NAND support

[Manivannan Sadhasivam]

Add qpic_nand node to support QPIC NAND controller on SDX55 platform.
Since there is no "aon" clock in SDX55, a dummy clock is provided.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index 1b9b990ad0a2..1a6947753972 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -41,6 +41,12 @@ pll_test_clk: pll-test-clk {
 			#clock-cells = <0>;
 			clock-frequency = <400000000>;
 		};
+
+		nand_clk_dummy: nand-clk-dummy {
+			compatible = "fixed-clock";
+			#clock-cells = <0>;
+			clock-frequency = <32000>;
+		};
 	};
 
 	cpus {
@@ -178,6 +184,22 @@ qpic_bam: dma@1b04000 {
 			status = "disabled";
 		};
 
+		qpic_nand: nand@1b30000 {
+			compatible = "qcom,sdx55-nand";
+			reg = <0x01b30000 0x10000>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			clocks = <&rpmhcc RPMH_QPIC_CLK>,
+				 <&nand_clk_dummy>;
+			clock-names = "core", "aon";
+
+			dmas = <&qpic_bam 0>,
+			       <&qpic_bam 1>,
+			       <&qpic_bam 2>;
+			dma-names = "tx", "rx", "cmd";
+			status = "disabled";
+		};
+
 		tcsr_mutex_block: syscon@1f40000 {
 			compatible = "syscon";
 			reg = <0x1f40000 0x20000>;
-- 
2.25.1

[PATCH v2 11/18] ARM: dts: qcom: sdx55-mtp: Enable BAM DMA

[Manivannan Sadhasivam]

Enable BAM DMA on SDX55-MTP board.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55-mtp.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55-mtp.dts b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
index 262660e6dd11..74ea6f425c77 100644
--- a/arch/arm/boot/dts/qcom-sdx55-mtp.dts
+++ b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
@@ -25,3 +25,7 @@ chosen {
 &blsp1_uart3 {
 	status = "ok";
 };
+
+&qpic_bam {
+	status = "ok";
+};
-- 
2.25.1

[PATCH v2 12/18] ARM: dts: qcom: sdx55-mtp: Enable QPIC NAND

[Manivannan Sadhasivam]

Enable QPIC NAND on SDX55-MTP board.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55-mtp.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55-mtp.dts b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
index 74ea6f425c77..b8d432a4324c 100644
--- a/arch/arm/boot/dts/qcom-sdx55-mtp.dts
+++ b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
@@ -29,3 +29,15 @@ &blsp1_uart3 {
 &qpic_bam {
 	status = "ok";
 };
+
+&qpic_nand {
+	status = "ok";
+
+	nand@0 {
+		reg = <0>;
+
+		nand-ecc-strength = <8>;
+		nand-ecc-step-size = <512>;
+		nand-bus-width = <8>;
+	};
+};
-- 
2.25.1

[PATCH v2 13/18] ARM: dts: qcom: sdx55: Add spmi node

[Manivannan Sadhasivam]

From: Vinod Koul <vkoul@kernel.org>

This adds SPMI node to SDX55 dts.

Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index 1a6947753972..f3864471ba4c 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -226,6 +226,25 @@ pdc: interrupt-controller@b210000 {
 			interrupt-controller;
 		};
 
+		spmi_bus: qcom,spmi@c440000 {
+			compatible = "qcom,spmi-pmic-arb";
+			reg = <0x0c440000 0x0000d00>,
+			      <0x0c600000 0x2000000>,
+			      <0x0e600000 0x0100000>,
+			      <0x0e700000 0x00a0000>,
+			      <0x0c40a000 0x0000700>;
+			reg-names = "core", "chnls", "obsrvr", "intr", "cnfg";
+			interrupt-names = "periph_irq";
+			interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;
+			qcom,ee = <0>;
+			qcom,channel = <0>;
+			#address-cells = <2>;
+			#size-cells = <0>;
+			interrupt-controller;
+			#interrupt-cells = <4>;
+			cell-index = <0>;
+		};
+
 		tlmm: pinctrl@f100000 {
 			compatible = "qcom,sdx55-pinctrl";
 			reg = <0xf100000 0x300000>;
-- 
2.25.1

[PATCH v2 14/18] ARM: dts: qcom: sdx55-mtp: Add pm8150b pmic

[Manivannan Sadhasivam]

From: Vinod Koul <vkoul@kernel.org>

SDX55-mtp features PM8150B pmic, so include the dts as well

Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55-mtp.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55-mtp.dts b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
index b8d432a4324c..09aeeb14be37 100644
--- a/arch/arm/boot/dts/qcom-sdx55-mtp.dts
+++ b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
@@ -7,6 +7,7 @@
 /dts-v1/;
 
 #include "qcom-sdx55.dtsi"
+#include <arm64/qcom/pm8150b.dtsi>
 
 / {
 	model = "Qualcomm Technologies, Inc. SDX55 MTP";
-- 
2.25.1

[PATCH v2 15/18] ARM: dts: qcom: sdx55-mtp: Add pmx55 pmic

[Manivannan Sadhasivam]

From: Vinod Koul <vkoul@kernel.org>

SDX55-mtp features PMX55 pmic, so include the dts as well

Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55-mtp.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55-mtp.dts b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
index 09aeeb14be37..825cc7d0ba18 100644
--- a/arch/arm/boot/dts/qcom-sdx55-mtp.dts
+++ b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
@@ -8,6 +8,7 @@
 
 #include "qcom-sdx55.dtsi"
 #include <arm64/qcom/pm8150b.dtsi>
+#include "qcom-pmx55.dtsi"
 
 / {
 	model = "Qualcomm Technologies, Inc. SDX55 MTP";
-- 
2.25.1

[PATCH v2 16/18] ARM: dts: qcom: sdx55: Add rpmpd node

[Manivannan Sadhasivam]

From: Vinod Koul <vkoul@kernel.org>

This adds rpmpd node and opps for this node to the SDX55 dts.

Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 51 +++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index f3864471ba4c..6f53acc882dc 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -9,6 +9,7 @@
 #include <dt-bindings/clock/qcom,gcc-sdx55.h>
 #include <dt-bindings/clock/qcom,rpmh.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/power/qcom-rpmpd.h>
 #include <dt-bindings/soc/qcom,rpmh-rsc.h>
 
 / {
@@ -371,6 +372,56 @@ rpmhcc: clock-controller {
 				clock-names = "xo";
 				clocks = <&xo_board>;
 			};
+
+			rpmhpd: power-controller {
+				compatible = "qcom,sdx55-rpmhpd";
+				#power-domain-cells = <1>;
+				operating-points-v2 = <&rpmhpd_opp_table>;
+
+				rpmhpd_opp_table: opp-table {
+					compatible = "operating-points-v2";
+
+					rpmhpd_opp_ret: opp1 {
+						opp-level = <RPMH_REGULATOR_LEVEL_RETENTION>;
+					};
+
+					rpmhpd_opp_min_svs: opp2 {
+						opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>;
+					};
+
+					rpmhpd_opp_low_svs: opp3 {
+						opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>;
+					};
+
+					rpmhpd_opp_svs: opp4 {
+						opp-level = <RPMH_REGULATOR_LEVEL_SVS>;
+					};
+
+					rpmhpd_opp_svs_l1: opp5 {
+						opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>;
+					};
+
+					rpmhpd_opp_nom: opp6 {
+						opp-level = <RPMH_REGULATOR_LEVEL_NOM>;
+					};
+
+					rpmhpd_opp_nom_l1: opp7 {
+						opp-level = <RPMH_REGULATOR_LEVEL_NOM_L1>;
+					};
+
+					rpmhpd_opp_nom_l2: opp8 {
+						opp-level = <RPMH_REGULATOR_LEVEL_NOM_L2>;
+					};
+
+					rpmhpd_opp_turbo: opp9 {
+						opp-level = <RPMH_REGULATOR_LEVEL_TURBO>;
+					};
+
+					rpmhpd_opp_turbo_l1: opp10 {
+						opp-level = <RPMH_REGULATOR_LEVEL_TURBO_L1>;
+					};
+				};
+			};
 		};
 	};
 
-- 
2.25.1

[PATCH v2 17/18] ARM: dts: qcom: Add PMIC pmx55 dts

[Manivannan Sadhasivam]

From: Vinod Koul <vkoul@kernel.org>

This adds DTS for PMIC PMX55 found in Qualcomm platforms.

Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-pmx55.dtsi | 91 +++++++++++++++++++++++++++++++
 1 file changed, 91 insertions(+)
 create mode 100644 arch/arm/boot/dts/qcom-pmx55.dtsi

diff --git a/arch/arm/boot/dts/qcom-pmx55.dtsi b/arch/arm/boot/dts/qcom-pmx55.dtsi
new file mode 100644
index 000000000000..05f033334716
--- /dev/null
+++ b/arch/arm/boot/dts/qcom-pmx55.dtsi
@@ -0,0 +1,91 @@
+// SPDX-License-Identifier: BSD-3-Clause
+
+/*
+ * Copyright (c) 2018-2020, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2020, Linaro Limited
+ */
+
+#include <dt-bindings/iio/qcom,spmi-vadc.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+&spmi_bus {
+	pmic@8 {
+		compatible = "qcom,pmx55", "qcom,spmi-pmic";
+		reg = <0x8 SPMI_USID>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		power-on@800 {
+			compatible = "qcom,pm8916-pon";
+			reg = <0x0800>;
+
+			status = "disabled";
+		};
+
+		pmx55_temp: temp-alarm@2400 {
+			compatible = "qcom,spmi-temp-alarm";
+			reg = <0x2400>;
+			interrupts = <0x8 0x24 0x0 IRQ_TYPE_EDGE_BOTH>;
+			io-channels = <&pmx55_adc ADC5_DIE_TEMP>;
+			io-channel-names = "thermal";
+			#thermal-sensor-cells = <0>;
+		};
+
+		pmx55_adc: adc@3100 {
+			compatible = "qcom,spmi-adc5";
+			reg = <0x3100>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			#io-channel-cells = <1>;
+			interrupts = <0x8 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
+
+			ref-gnd@0 {
+				reg = <ADC5_REF_GND>;
+				qcom,pre-scaling = <1 1>;
+				label = "ref_gnd";
+			};
+
+			vref-1p25@1 {
+				reg = <ADC5_1P25VREF>;
+				qcom,pre-scaling = <1 1>;
+				label = "vref_1p25";
+			};
+
+			die-temp@6 {
+				reg = <ADC5_DIE_TEMP>;
+				qcom,pre-scaling = <1 1>;
+				label = "die_temp";
+			};
+
+			chg-temp@9 {
+				reg = <ADC5_CHG_TEMP>;
+				qcom,pre-scaling = <1 1>;
+				label = "chg_temp";
+			};
+		};
+
+		pmx55_gpios: gpio@c000 {
+			compatible = "qcom,pmx55-gpio", "qcom,spmi-gpio";
+			reg = <0xc000>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			interrupts = <0x8 0xc0 0x0 IRQ_TYPE_NONE>,
+				     <0x8 0xc1 0x0 IRQ_TYPE_NONE>,
+				     <0x8 0xc3 0x0 IRQ_TYPE_NONE>,
+				     <0x8 0xc4 0x0 IRQ_TYPE_NONE>,
+				     <0x8 0xc5 0x0 IRQ_TYPE_NONE>,
+				     <0x8 0xc7 0x0 IRQ_TYPE_NONE>,
+				     <0x8 0xc8 0x0 IRQ_TYPE_NONE>;
+		};
+	};
+
+	pmic@9 {
+		compatible = "qcom,pmx55", "qcom,spmi-pmic";
+		reg = <0x9 SPMI_USID>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+	};
+};
-- 
2.25.1

[PATCH v2 18/18] ARM: dts: qcom: sdx55-mtp: Add regulator nodes

[Manivannan Sadhasivam]

From: Vinod Koul <vkoul@kernel.org>

This adds the regulators found on SDX55 MTP.

Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55-mtp.dts | 179 +++++++++++++++++++++++++++
 1 file changed, 179 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-sdx55-mtp.dts b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
index 825cc7d0ba18..61e7d5d4bd48 100644
--- a/arch/arm/boot/dts/qcom-sdx55-mtp.dts
+++ b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
@@ -6,6 +6,7 @@
 
 /dts-v1/;
 
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 #include "qcom-sdx55.dtsi"
 #include <arm64/qcom/pm8150b.dtsi>
 #include "qcom-pmx55.dtsi"
@@ -22,6 +23,184 @@ aliases {
 	chosen {
 		stdout-path = "serial0:115200n8";
 	};
+
+	vph_pwr: vph-pwr-regulator {
+		compatible = "regulator-fixed";
+		regulator-name = "vph_pwr";
+		regulator-min-microvolt = <3700000>;
+		regulator-max-microvolt = <3700000>;
+	};
+
+	vreg_bob_3p3: pmx55-bob {
+		compatible = "regulator-fixed";
+		regulator-name = "vreg_bob_3p3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		regulator-always-on;
+		regulator-boot-on;
+
+		vin-supply = <&vph_pwr>;
+	};
+
+	vreg_s7e_mx_0p752: pmx55-s7e {
+		compatible = "regulator-fixed";
+		regulator-name = "vreg_s7e_mx_0p752";
+		regulator-min-microvolt = <752000>;
+		regulator-max-microvolt = <752000>;
+
+		vin-supply = <&vph_pwr>;
+	};
+
+	vreg_vddpx_2: vddpx-2 {
+		compatible = "regulator-gpio";
+		regulator-name = "vreg_vddpx_2";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <2850000>;
+		enable-gpios = <&tlmm 98 GPIO_ACTIVE_HIGH>;
+		gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;
+		states = <1800000 0>, <2850000 1>;
+		startup-delay-us = <200000>;
+		enable-active-high;
+		regulator-boot-on;
+
+		vin-supply = <&vph_pwr>;
+	};
+};
+
+&apps_rsc {
+	pmx55-rpmh-regulators {
+		compatible = "qcom,pmx55-rpmh-regulators";
+		qcom,pmic-id = "e";
+
+		vdd-s1-supply = <&vph_pwr>;
+		vdd-s2-supply = <&vph_pwr>;
+		vdd-s3-supply = <&vph_pwr>;
+		vdd-s4-supply = <&vph_pwr>;
+		vdd-s5-supply = <&vph_pwr>;
+		vdd-s6-supply = <&vph_pwr>;
+		vdd-s7-supply = <&vph_pwr>;
+		vdd-l1-l2-supply = <&vreg_s2e_1p224>;
+		vdd-l3-l9-supply = <&vreg_s3e_0p824>;
+		vdd-l4-l12-supply = <&vreg_s4e_1p904>;
+		vdd-l5-l6-supply = <&vreg_s4e_1p904>;
+		vdd-l7-l8-supply = <&vreg_s3e_0p824>;
+		vdd-l10-l11-l13-supply = <&vreg_bob_3p3>;
+		vdd-l14-supply = <&vreg_s7e_mx_0p752>;
+		vdd-l15-supply = <&vreg_s2e_1p224>;
+		vdd-l16-supply = <&vreg_s4e_1p904>;
+
+		vreg_s2e_1p224: smps2 {
+			regulator-min-microvolt = <1280000>;
+			regulator-max-microvolt = <1400000>;
+		};
+
+		vreg_s3e_0p824: smps3 {
+			regulator-min-microvolt = <800000>;
+			regulator-max-microvolt = <1000000>;
+		};
+
+		vreg_s4e_1p904: smps4 {
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1960000>;
+		};
+
+		ldo1 {
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo2 {
+			regulator-min-microvolt = <1128000>;
+			regulator-max-microvolt = <1128000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo3 {
+			regulator-min-microvolt = <800000>;
+			regulator-max-microvolt = <800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo4 {
+			regulator-min-microvolt = <872000>;
+			regulator-max-microvolt = <872000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo5 {
+			regulator-min-microvolt = <1704000>;
+			regulator-max-microvolt = <1900000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo6 {
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo7 {
+			regulator-min-microvolt = <480000>;
+			regulator-max-microvolt = <900000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo8 {
+			regulator-min-microvolt = <480000>;
+			regulator-max-microvolt = <900000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo9 {
+			regulator-min-microvolt = <800000>;
+			regulator-max-microvolt = <800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo10 {
+			regulator-min-microvolt = <3088000>;
+			regulator-max-microvolt = <3088000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo11 {
+			regulator-min-microvolt = <1704000>;
+			regulator-max-microvolt = <2928000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo12 {
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo13 {
+			regulator-min-microvolt = <1704000>;
+			regulator-max-microvolt = <2928000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo14 {
+			regulator-min-microvolt = <600000>;
+			regulator-max-microvolt = <800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo15 {
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+
+		ldo16 {
+			regulator-min-microvolt = <1704000>;
+			regulator-max-microvolt = <1904000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
+		};
+	};
 };
 
 &blsp1_uart3 {
-- 
2.25.1

Re: [PATCH v2 05/18] dt-bindings: arm-smmu: Add binding for Qcom SDX55 SMMU

[Vinod Koul]

On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> Add devicetree binding for Qualcomm SDX55 SMMU.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> index 3b63f2ae24db..cc48d90de5fe 100644
> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> @@ -37,6 +37,7 @@ properties:
>                - qcom,sdm845-smmu-500
>                - qcom,sm8150-smmu-500
>                - qcom,sm8250-smmu-500
> +              - qcom,sdx55-smmu-500

Keep this sorted?

With that:

Reviewed-by: Vinod Koul <vkoul@kernel.org>

>            - const: arm,mmu-500
>        - description: Qcom Adreno GPUs implementing "arm,smmu-v2"
>          items:
> -- 
> 2.25.1

-- 
~Vinod

Re: [PATCH v2 09/18] ARM: dts: qcom: sdx55: Add QPIC BAM support

[Vinod Koul]

On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> Add qpic_bam node to support QPIC BAM DMA controller on SDX55 platform.

Reviewed-by: Vinod Koul <vkoul@kernel.org>

> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-sdx55.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> index 622a63b0058f..1b9b990ad0a2 100644
> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> @@ -166,6 +166,18 @@ sdhc_1: sdhci@8804000 {
>  			status = "disabled";
>  		};
>  
> +		qpic_bam: dma@1b04000 {
> +			compatible = "qcom,bam-v1.7.0";
> +			reg = <0x01b04000 0x1c000>;
> +			interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&rpmhcc RPMH_QPIC_CLK>;
> +			clock-names = "bam_clk";
> +			#dma-cells = <1>;
> +			qcom,ee = <0>;
> +			qcom,controlled-remotely;
> +			status = "disabled";
> +		};
> +
>  		tcsr_mutex_block: syscon@1f40000 {
>  			compatible = "syscon";
>  			reg = <0x1f40000 0x20000>;
> -- 
> 2.25.1

-- 
~Vinod

Re: [PATCH v2 10/18] ARM: dts: qcom: sdx55: Add QPIC NAND support

[Vinod Koul]

On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> Add qpic_nand node to support QPIC NAND controller on SDX55 platform.
> Since there is no "aon" clock in SDX55, a dummy clock is provided.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-sdx55.dtsi | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> index 1b9b990ad0a2..1a6947753972 100644
> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> @@ -41,6 +41,12 @@ pll_test_clk: pll-test-clk {
>  			#clock-cells = <0>;
>  			clock-frequency = <400000000>;
>  		};
> +
> +		nand_clk_dummy: nand-clk-dummy {

Why dummy..? 
> +			compatible = "fixed-clock";
> +			#clock-cells = <0>;
> +			clock-frequency = <32000>;

Is this sleep clock of platform..?

> +		};
>  	};
>  
>  	cpus {
> @@ -178,6 +184,22 @@ qpic_bam: dma@1b04000 {
>  			status = "disabled";
>  		};
>  
> +		qpic_nand: nand@1b30000 {
> +			compatible = "qcom,sdx55-nand";
> +			reg = <0x01b30000 0x10000>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			clocks = <&rpmhcc RPMH_QPIC_CLK>,
> +				 <&nand_clk_dummy>;
> +			clock-names = "core", "aon";
> +
> +			dmas = <&qpic_bam 0>,
> +			       <&qpic_bam 1>,
> +			       <&qpic_bam 2>;
> +			dma-names = "tx", "rx", "cmd";
> +			status = "disabled";
> +		};
> +
>  		tcsr_mutex_block: syscon@1f40000 {
>  			compatible = "syscon";
>  			reg = <0x1f40000 0x20000>;
> -- 
> 2.25.1

-- 
~Vinod

Re: [PATCH v2 12/18] ARM: dts: qcom: sdx55-mtp: Enable QPIC NAND

[Vinod Koul]

On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> Enable QPIC NAND on SDX55-MTP board.

Reviewed-by: Vinod Koul <vkoul@kernel.org>

> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-sdx55-mtp.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx55-mtp.dts b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> index 74ea6f425c77..b8d432a4324c 100644
> --- a/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> +++ b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> @@ -29,3 +29,15 @@ &blsp1_uart3 {
>  &qpic_bam {
>  	status = "ok";
>  };
> +
> +&qpic_nand {
> +	status = "ok";
> +
> +	nand@0 {
> +		reg = <0>;
> +
> +		nand-ecc-strength = <8>;
> +		nand-ecc-step-size = <512>;
> +		nand-bus-width = <8>;
> +	};
> +};
> -- 
> 2.25.1

-- 
~Vinod

Re: [PATCH v2 11/18] ARM: dts: qcom: sdx55-mtp: Enable BAM DMA

[Vinod Koul]

On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> Enable BAM DMA on SDX55-MTP board.

Reviewed-by: Vinod Koul <vkoul@kernel.org>

> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-sdx55-mtp.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx55-mtp.dts b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> index 262660e6dd11..74ea6f425c77 100644
> --- a/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> +++ b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> @@ -25,3 +25,7 @@ chosen {
>  &blsp1_uart3 {
>  	status = "ok";
>  };
> +
> +&qpic_bam {
> +	status = "ok";
> +};
> -- 
> 2.25.1

-- 
~Vinod

Re: [PATCH v2 08/18] ARM: dts: qcom: sdx55: Add Shared memory manager support

[Vinod Koul]

On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> Add smem node to support shared memory manager on SDX55 platform.

Reviewed-by: Vinod Koul <vkoul@kernel.org>

> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-sdx55.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> index e48ec7a1971b..622a63b0058f 100644
> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> @@ -177,6 +177,12 @@ tcsr_mutex: hwlock {
>  			#hwlock-cells = <1>;
>  		};
>  
> +		smem {
> +			compatible = "qcom,smem";
> +			memory-region = <&smem_mem>;
> +			hwlocks = <&tcsr_mutex 3>;
> +		};
> +
>  		pdc: interrupt-controller@b210000 {
>  			compatible = "qcom,sdx55-pdc", "qcom,pdc";
>  			reg = <0x0b210000 0x30000>;
> -- 
> 2.25.1

-- 
~Vinod

Re: [PATCH v2 07/18] ARM: dts: qcom: sdx55: Add support for TCSR Mutex

[Vinod Koul]

On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> Add TCSR Mutex node to support Qualcomm Hardware Mutex block on SDX55
> platform.

Reviewed-by: Vinod Koul <vkoul@kernel.org>

> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-sdx55.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> index 927f43a7414c..e48ec7a1971b 100644
> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> @@ -166,6 +166,17 @@ sdhc_1: sdhci@8804000 {
>  			status = "disabled";
>  		};
>  
> +		tcsr_mutex_block: syscon@1f40000 {
> +			compatible = "syscon";
> +			reg = <0x1f40000 0x20000>;
> +		};
> +
> +		tcsr_mutex: hwlock {
> +			compatible = "qcom,tcsr-mutex";
> +			syscon = <&tcsr_mutex_block 0 0x1000>;
> +			#hwlock-cells = <1>;
> +		};
> +
>  		pdc: interrupt-controller@b210000 {
>  			compatible = "qcom,sdx55-pdc", "qcom,pdc";
>  			reg = <0x0b210000 0x30000>;
> -- 
> 2.25.1

-- 
~Vinod

Re: [PATCH v2 04/18] ARM: dts: qcom: sdx55: Add support for SDHCI controller

[Vinod Koul]

On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> Add devicetree support for SDHCI controller found in Qualcomm SDX55 SoC.
> The SDHCI controller used in this SoC is based on the MSM SDHCI v5 IP.
> Hence, the support is added by reusing the existing sdhci driver with
> "qcom,sdhci-msm-v5" as the fallback.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-sdx55.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> index eeb6bf392f93..3f8e98bfc020 100644
> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> @@ -154,6 +154,18 @@ blsp1_uart3: serial@831000 {
>  			status = "disabled";
>  		};
>  
> +		sdhc_1: sdhci@8804000 {

Any reason why this is sdhc_1 label, do we have another one..?

> +			compatible = "qcom,sdx55-sdhci", "qcom,sdhci-msm-v5";
> +			reg = <0x08804000 0x1000>;
> +			interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "hc_irq", "pwr_irq";
> +			clocks = <&gcc GCC_SDCC1_AHB_CLK>,
> +				 <&gcc GCC_SDCC1_APPS_CLK>;
> +			clock-names = "iface", "core";
> +			status = "disabled";
> +		};
> +
>  		pdc: interrupt-controller@b210000 {
>  			compatible = "qcom,sdx55-pdc", "qcom,pdc";
>  			reg = <0x0b210000 0x30000>;
> -- 
> 2.25.1

-- 
~Vinod

Re: [PATCH v2 03/18] dt-bindings: mmc: sdhci-msm: Document the SDX55 compatible

[Vinod Koul]

On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> The SDHCI controller on SDX55 is based on MSM SDHCI v5 IP. Hence,
> document the compatible with "qcom,sdhci-msm-v5" as the fallback.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> index 3b602fd6180b..31f4a5628595 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> @@ -21,6 +21,7 @@ Required properties:
>  		"qcom,sdm845-sdhci", "qcom,sdhci-msm-v5"
>  		"qcom,qcs404-sdhci", "qcom,sdhci-msm-v5"
>  		"qcom,sc7180-sdhci", "qcom,sdhci-msm-v5";
> +		"qcom,sdx55-sdhci", "qcom,sdhci-msm-v5";

Keep this sorted?

With that:

Reviewed-by: Vinod Koul <vkoul@kernel.org>

>  	NOTE that some old device tree files may be floating around that only
>  	have the string "qcom,sdhci-msm-v4" without the SoC compatible string
>  	but doing that should be considered a deprecated practice.
> -- 
> 2.25.1

-- 
~Vinod

Re: [PATCH v2 09/18] ARM: dts: qcom: sdx55: Add QPIC BAM support

[Vinod Koul]

Hi Mani,

On 05-01-21, 21:20, Vinod Koul wrote:
> On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> > Add qpic_bam node to support QPIC BAM DMA controller on SDX55 platform.
> 
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
> 
> > 
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> >  arch/arm/boot/dts/qcom-sdx55.dtsi | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > index 622a63b0058f..1b9b990ad0a2 100644
> > --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> > +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > @@ -166,6 +166,18 @@ sdhc_1: sdhci@8804000 {
> >  			status = "disabled";
> >  		};
> >  
> > +		qpic_bam: dma@1b04000 {

This should be dma-controller@

Also, please run dtbs_check on these patches

> > +			compatible = "qcom,bam-v1.7.0";
> > +			reg = <0x01b04000 0x1c000>;
> > +			interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&rpmhcc RPMH_QPIC_CLK>;
> > +			clock-names = "bam_clk";
> > +			#dma-cells = <1>;
> > +			qcom,ee = <0>;
> > +			qcom,controlled-remotely;
> > +			status = "disabled";
> > +		};
> > +
> >  		tcsr_mutex_block: syscon@1f40000 {
> >  			compatible = "syscon";
> >  			reg = <0x1f40000 0x20000>;
> > -- 
> > 2.25.1
> 
> -- 
> ~Vinod

-- 
~Vinod

Re: [PATCH v2 02/18] ARM: dts: qcom: sdx55: Add reserved memory nodes

[Bjorn Andersson]

On Tue 05 Jan 06:26 CST 2021, Manivannan Sadhasivam wrote:

> From: Vinod Koul <vkoul@kernel.org>
> 
> This adds reserved memory nodes to the SDX55 dtsi as defined by v8 of
> the memory map
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-sdx55.dtsi | 67 +++++++++++++++++++++++++++++++
>  1 file changed, 67 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> index 08b4a40338fa..eeb6bf392f93 100644
> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> @@ -60,6 +60,73 @@ psci {
>  		method = "smc";
>  	};
>  
> +	reserved-memory {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		mpss_debug_mem: memory@8ef00000 {
> +			no-map;
> +			reg = <0x8ef00000 0x800000>;
> +		};
> +
> +		hyp_mem: memory@8fc00000 {
> +			no-map;
> +			reg = <0x8fc00000 0x80000>;
> +		};
> +
> +		ac_db_mem: memory@8fc80000 {
> +			no-map;
> +			reg = <0x8fc80000 0x40000>;
> +		};
> +
> +		secdata_mem: memory@8fcfd000 {
> +			no-map;
> +			reg = <0x8fcfd000 0x1000>;
> +		};
> +
> +		ipa_fw_mem: memory@8fced000 {
> +			no-map;
> +			reg = <0x8fced000 0x10000>;
> +		};
> +
> +		sbl_mem: memory@8fd00000 {
> +			no-map;
> +			reg = <0x8fd00000 0x100000>;
> +		};
> +
> +		aop_image: memory@8fe00000 {
> +			no-map;
> +			reg = <0x8fe00000 0x20000>;
> +		};
> +
> +		aop_cmd_db: memory@8fe20000 {
> +			compatible = "qcom,cmd-db";
> +			reg = <0x8fe20000 0x20000>;
> +			no-map;
> +		};
> +
> +		smem_mem: memory@8fe40000 {
> +			no-map;
> +			reg = <0x8fe40000 0xc0000>;
> +		};
> +
> +		tz_mem: memory@8ff00000 {
> +			no-map;
> +			reg = <0x8ff00000 0x100000>;
> +		};
> +
> +		tz_apps_mem: memory@0x90000000 {
> +			no-map;
> +			reg = <0x90000000 0x500000>;
> +		};
> +
> +		mpss_adsp_mem: memory@90800000 {
> +			no-map;
> +			reg = <0x90800000 0xf800000>;

Didn't you say this moved to 0x9c000000?

Regards,
Bjorn

> +		};
> +	};
> +
>  	soc: soc {
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> -- 
> 2.25.1
> 

Re: [PATCH v2 17/18] ARM: dts: qcom: Add PMIC pmx55 dts

[Bjorn Andersson]

On Tue 05 Jan 06:26 CST 2021, Manivannan Sadhasivam wrote:

> From: Vinod Koul <vkoul@kernel.org>
> 
> This adds DTS for PMIC PMX55 found in Qualcomm platforms.
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-pmx55.dtsi | 91 +++++++++++++++++++++++++++++++
>  1 file changed, 91 insertions(+)
>  create mode 100644 arch/arm/boot/dts/qcom-pmx55.dtsi
> 
> diff --git a/arch/arm/boot/dts/qcom-pmx55.dtsi b/arch/arm/boot/dts/qcom-pmx55.dtsi
> new file mode 100644
> index 000000000000..05f033334716
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-pmx55.dtsi
> @@ -0,0 +1,91 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +
> +/*
> + * Copyright (c) 2018-2020, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2020, Linaro Limited
> + */
> +
> +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +&spmi_bus {
> +	pmic@8 {
> +		compatible = "qcom,pmx55", "qcom,spmi-pmic";
> +		reg = <0x8 SPMI_USID>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		power-on@800 {
> +			compatible = "qcom,pm8916-pon";
> +			reg = <0x0800>;
> +
> +			status = "disabled";
> +		};
> +
> +		pmx55_temp: temp-alarm@2400 {
> +			compatible = "qcom,spmi-temp-alarm";
> +			reg = <0x2400>;
> +			interrupts = <0x8 0x24 0x0 IRQ_TYPE_EDGE_BOTH>;
> +			io-channels = <&pmx55_adc ADC5_DIE_TEMP>;
> +			io-channel-names = "thermal";
> +			#thermal-sensor-cells = <0>;
> +		};
> +
> +		pmx55_adc: adc@3100 {
> +			compatible = "qcom,spmi-adc5";
> +			reg = <0x3100>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			#io-channel-cells = <1>;
> +			interrupts = <0x8 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
> +
> +			ref-gnd@0 {
> +				reg = <ADC5_REF_GND>;
> +				qcom,pre-scaling = <1 1>;
> +				label = "ref_gnd";
> +			};
> +
> +			vref-1p25@1 {
> +				reg = <ADC5_1P25VREF>;
> +				qcom,pre-scaling = <1 1>;
> +				label = "vref_1p25";
> +			};
> +
> +			die-temp@6 {
> +				reg = <ADC5_DIE_TEMP>;
> +				qcom,pre-scaling = <1 1>;
> +				label = "die_temp";
> +			};
> +
> +			chg-temp@9 {
> +				reg = <ADC5_CHG_TEMP>;
> +				qcom,pre-scaling = <1 1>;
> +				label = "chg_temp";
> +			};
> +		};
> +
> +		pmx55_gpios: gpio@c000 {
> +			compatible = "qcom,pmx55-gpio", "qcom,spmi-gpio";
> +			reg = <0xc000>;
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			interrupts = <0x8 0xc0 0x0 IRQ_TYPE_NONE>,
> +				     <0x8 0xc1 0x0 IRQ_TYPE_NONE>,
> +				     <0x8 0xc3 0x0 IRQ_TYPE_NONE>,
> +				     <0x8 0xc4 0x0 IRQ_TYPE_NONE>,
> +				     <0x8 0xc5 0x0 IRQ_TYPE_NONE>,
> +				     <0x8 0xc7 0x0 IRQ_TYPE_NONE>,
> +				     <0x8 0xc8 0x0 IRQ_TYPE_NONE>;

Brian reworked the spmi-gpio driver a while back to use hierarchical
irqdomains instead of this, so please drop the "interrupts" property.

For reference see e.g.:
f14a5e6da4a5 ("arm64: dts: qcom: pmi8998: add interrupt controller properties")

Regards,
Bjorn

> +		};
> +	};
> +
> +	pmic@9 {
> +		compatible = "qcom,pmx55", "qcom,spmi-pmic";
> +		reg = <0x9 SPMI_USID>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +	};
> +};
> -- 
> 2.25.1
> 

Re: [PATCH v2 18/18] ARM: dts: qcom: sdx55-mtp: Add regulator nodes

[Bjorn Andersson]

On Tue 05 Jan 06:26 CST 2021, Manivannan Sadhasivam wrote:

> From: Vinod Koul <vkoul@kernel.org>
> 
> This adds the regulators found on SDX55 MTP.
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-sdx55-mtp.dts | 179 +++++++++++++++++++++++++++
>  1 file changed, 179 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx55-mtp.dts b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> index 825cc7d0ba18..61e7d5d4bd48 100644
> --- a/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> +++ b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> @@ -6,6 +6,7 @@
>  
>  /dts-v1/;
>  
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>  #include "qcom-sdx55.dtsi"
>  #include <arm64/qcom/pm8150b.dtsi>
>  #include "qcom-pmx55.dtsi"
> @@ -22,6 +23,184 @@ aliases {
>  	chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
> +
> +	vph_pwr: vph-pwr-regulator {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vph_pwr";
> +		regulator-min-microvolt = <3700000>;
> +		regulator-max-microvolt = <3700000>;
> +	};
> +
> +	vreg_bob_3p3: pmx55-bob {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vreg_bob_3p3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +
> +		regulator-always-on;
> +		regulator-boot-on;
> +
> +		vin-supply = <&vph_pwr>;
> +	};
> +
> +	vreg_s7e_mx_0p752: pmx55-s7e {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vreg_s7e_mx_0p752";
> +		regulator-min-microvolt = <752000>;
> +		regulator-max-microvolt = <752000>;
> +
> +		vin-supply = <&vph_pwr>;
> +	};
> +
> +	vreg_vddpx_2: vddpx-2 {

Isn't this the name of the pad on the SoC, i.e. the consumer? Does the
regulator output have a more suitable name?

I don't see any references to this node and you got it "boot-on", what
happens when the regulator core tuns it off? Or this isn't an issue
until we actually try to support sdhci (guessing based on the voltages)?

Regards,
Bjorn

> +		compatible = "regulator-gpio";
> +		regulator-name = "vreg_vddpx_2";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <2850000>;
> +		enable-gpios = <&tlmm 98 GPIO_ACTIVE_HIGH>;
> +		gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;
> +		states = <1800000 0>, <2850000 1>;
> +		startup-delay-us = <200000>;
> +		enable-active-high;
> +		regulator-boot-on;
> +
> +		vin-supply = <&vph_pwr>;
> +	};
> +};
> +
> +&apps_rsc {
> +	pmx55-rpmh-regulators {
> +		compatible = "qcom,pmx55-rpmh-regulators";
> +		qcom,pmic-id = "e";
> +
> +		vdd-s1-supply = <&vph_pwr>;
> +		vdd-s2-supply = <&vph_pwr>;
> +		vdd-s3-supply = <&vph_pwr>;
> +		vdd-s4-supply = <&vph_pwr>;
> +		vdd-s5-supply = <&vph_pwr>;
> +		vdd-s6-supply = <&vph_pwr>;
> +		vdd-s7-supply = <&vph_pwr>;
> +		vdd-l1-l2-supply = <&vreg_s2e_1p224>;
> +		vdd-l3-l9-supply = <&vreg_s3e_0p824>;
> +		vdd-l4-l12-supply = <&vreg_s4e_1p904>;
> +		vdd-l5-l6-supply = <&vreg_s4e_1p904>;
> +		vdd-l7-l8-supply = <&vreg_s3e_0p824>;
> +		vdd-l10-l11-l13-supply = <&vreg_bob_3p3>;
> +		vdd-l14-supply = <&vreg_s7e_mx_0p752>;
> +		vdd-l15-supply = <&vreg_s2e_1p224>;
> +		vdd-l16-supply = <&vreg_s4e_1p904>;
> +
> +		vreg_s2e_1p224: smps2 {
> +			regulator-min-microvolt = <1280000>;
> +			regulator-max-microvolt = <1400000>;
> +		};
> +
> +		vreg_s3e_0p824: smps3 {
> +			regulator-min-microvolt = <800000>;
> +			regulator-max-microvolt = <1000000>;
> +		};
> +
> +		vreg_s4e_1p904: smps4 {
> +			regulator-min-microvolt = <1800000>;
> +			regulator-max-microvolt = <1960000>;
> +		};
> +
> +		ldo1 {
> +			regulator-min-microvolt = <1200000>;
> +			regulator-max-microvolt = <1200000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo2 {
> +			regulator-min-microvolt = <1128000>;
> +			regulator-max-microvolt = <1128000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo3 {
> +			regulator-min-microvolt = <800000>;
> +			regulator-max-microvolt = <800000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo4 {
> +			regulator-min-microvolt = <872000>;
> +			regulator-max-microvolt = <872000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo5 {
> +			regulator-min-microvolt = <1704000>;
> +			regulator-max-microvolt = <1900000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo6 {
> +			regulator-min-microvolt = <1800000>;
> +			regulator-max-microvolt = <1800000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo7 {
> +			regulator-min-microvolt = <480000>;
> +			regulator-max-microvolt = <900000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo8 {
> +			regulator-min-microvolt = <480000>;
> +			regulator-max-microvolt = <900000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo9 {
> +			regulator-min-microvolt = <800000>;
> +			regulator-max-microvolt = <800000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo10 {
> +			regulator-min-microvolt = <3088000>;
> +			regulator-max-microvolt = <3088000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo11 {
> +			regulator-min-microvolt = <1704000>;
> +			regulator-max-microvolt = <2928000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo12 {
> +			regulator-min-microvolt = <1200000>;
> +			regulator-max-microvolt = <1200000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo13 {
> +			regulator-min-microvolt = <1704000>;
> +			regulator-max-microvolt = <2928000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo14 {
> +			regulator-min-microvolt = <600000>;
> +			regulator-max-microvolt = <800000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo15 {
> +			regulator-min-microvolt = <1200000>;
> +			regulator-max-microvolt = <1200000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +
> +		ldo16 {
> +			regulator-min-microvolt = <1704000>;
> +			regulator-max-microvolt = <1904000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> +		};
> +	};
>  };
>  
>  &blsp1_uart3 {
> -- 
> 2.25.1
> 

Re: [PATCH v2 07/18] ARM: dts: qcom: sdx55: Add support for TCSR Mutex

[Bjorn Andersson]

On Tue 05 Jan 06:26 CST 2021, Manivannan Sadhasivam wrote:

> Add TCSR Mutex node to support Qualcomm Hardware Mutex block on SDX55
> platform.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-sdx55.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> index 927f43a7414c..e48ec7a1971b 100644
> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> @@ -166,6 +166,17 @@ sdhc_1: sdhci@8804000 {
>  			status = "disabled";
>  		};
>  
> +		tcsr_mutex_block: syscon@1f40000 {
> +			compatible = "syscon";

It was recently determined that simply "syscon" isn't a valid
compatible.

> +			reg = <0x1f40000 0x20000>;
> +		};
> +
> +		tcsr_mutex: hwlock {
> +			compatible = "qcom,tcsr-mutex";

And in some platforms the tcsr_mutex_block seems to be single use
anyways, so I rewrote this binding a while ago.

So, this will still work in Linux, please update the patch to match the
new binding
(Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml)

Thanks,
Bjorn

> +			syscon = <&tcsr_mutex_block 0 0x1000>;
> +			#hwlock-cells = <1>;
> +		};
> +
>  		pdc: interrupt-controller@b210000 {
>  			compatible = "qcom,sdx55-pdc", "qcom,pdc";
>  			reg = <0x0b210000 0x30000>;
> -- 
> 2.25.1
> 

Re: [PATCH v2 02/18] ARM: dts: qcom: sdx55: Add reserved memory nodes

[Manivannan Sadhasivam]

On Tue, Jan 05, 2021 at 12:05:49PM -0600, Bjorn Andersson wrote:
> On Tue 05 Jan 06:26 CST 2021, Manivannan Sadhasivam wrote:
> 
> > From: Vinod Koul <vkoul@kernel.org>
> > 
> > This adds reserved memory nodes to the SDX55 dtsi as defined by v8 of
> > the memory map
> > 
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> >  arch/arm/boot/dts/qcom-sdx55.dtsi | 67 +++++++++++++++++++++++++++++++
> >  1 file changed, 67 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > index 08b4a40338fa..eeb6bf392f93 100644
> > --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> > +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > @@ -60,6 +60,73 @@ psci {
> >  		method = "smc";
> >  	};
> >  
> > +	reserved-memory {
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges;
> > +
> > +		mpss_debug_mem: memory@8ef00000 {
> > +			no-map;
> > +			reg = <0x8ef00000 0x800000>;
> > +		};
> > +
> > +		hyp_mem: memory@8fc00000 {
> > +			no-map;
> > +			reg = <0x8fc00000 0x80000>;
> > +		};
> > +
> > +		ac_db_mem: memory@8fc80000 {
> > +			no-map;
> > +			reg = <0x8fc80000 0x40000>;
> > +		};
> > +
> > +		secdata_mem: memory@8fcfd000 {
> > +			no-map;
> > +			reg = <0x8fcfd000 0x1000>;
> > +		};
> > +
> > +		ipa_fw_mem: memory@8fced000 {
> > +			no-map;
> > +			reg = <0x8fced000 0x10000>;
> > +		};
> > +
> > +		sbl_mem: memory@8fd00000 {
> > +			no-map;
> > +			reg = <0x8fd00000 0x100000>;
> > +		};
> > +
> > +		aop_image: memory@8fe00000 {
> > +			no-map;
> > +			reg = <0x8fe00000 0x20000>;
> > +		};
> > +
> > +		aop_cmd_db: memory@8fe20000 {
> > +			compatible = "qcom,cmd-db";
> > +			reg = <0x8fe20000 0x20000>;
> > +			no-map;
> > +		};
> > +
> > +		smem_mem: memory@8fe40000 {
> > +			no-map;
> > +			reg = <0x8fe40000 0xc0000>;
> > +		};
> > +
> > +		tz_mem: memory@8ff00000 {
> > +			no-map;
> > +			reg = <0x8ff00000 0x100000>;
> > +		};
> > +
> > +		tz_apps_mem: memory@0x90000000 {
> > +			no-map;
> > +			reg = <0x90000000 0x500000>;
> > +		};
> > +
> > +		mpss_adsp_mem: memory@90800000 {
> > +			no-map;
> > +			reg = <0x90800000 0xf800000>;
> 
> Didn't you say this moved to 0x9c000000?
> 

That's for an old bootloader which is used in the MTP. But I guess we should
always use the latest mem map for the latest bootloader.

Thanks,
Mani

> Regards,
> Bjorn
> 
> > +		};
> > +	};
> > +
> >  	soc: soc {
> >  		#address-cells = <1>;
> >  		#size-cells = <1>;
> > -- 
> > 2.25.1
> > 

Re: [PATCH v2 02/18] ARM: dts: qcom: sdx55: Add reserved memory nodes

[Bjorn Andersson]

On Tue 05 Jan 21:07 CST 2021, Manivannan Sadhasivam wrote:

> On Tue, Jan 05, 2021 at 12:05:49PM -0600, Bjorn Andersson wrote:
> > On Tue 05 Jan 06:26 CST 2021, Manivannan Sadhasivam wrote:
> > 
> > > From: Vinod Koul <vkoul@kernel.org>
> > > 
> > > This adds reserved memory nodes to the SDX55 dtsi as defined by v8 of
> > > the memory map
> > > 
> > > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > ---
> > >  arch/arm/boot/dts/qcom-sdx55.dtsi | 67 +++++++++++++++++++++++++++++++
> > >  1 file changed, 67 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > > index 08b4a40338fa..eeb6bf392f93 100644
> > > --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> > > +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > > @@ -60,6 +60,73 @@ psci {
> > >  		method = "smc";
> > >  	};
> > >  
> > > +	reserved-memory {
> > > +		#address-cells = <1>;
> > > +		#size-cells = <1>;
> > > +		ranges;
> > > +
> > > +		mpss_debug_mem: memory@8ef00000 {
> > > +			no-map;
> > > +			reg = <0x8ef00000 0x800000>;
> > > +		};
> > > +
> > > +		hyp_mem: memory@8fc00000 {
> > > +			no-map;
> > > +			reg = <0x8fc00000 0x80000>;
> > > +		};
> > > +
> > > +		ac_db_mem: memory@8fc80000 {
> > > +			no-map;
> > > +			reg = <0x8fc80000 0x40000>;
> > > +		};
> > > +
> > > +		secdata_mem: memory@8fcfd000 {
> > > +			no-map;
> > > +			reg = <0x8fcfd000 0x1000>;
> > > +		};
> > > +
> > > +		ipa_fw_mem: memory@8fced000 {
> > > +			no-map;
> > > +			reg = <0x8fced000 0x10000>;
> > > +		};
> > > +
> > > +		sbl_mem: memory@8fd00000 {
> > > +			no-map;
> > > +			reg = <0x8fd00000 0x100000>;
> > > +		};
> > > +
> > > +		aop_image: memory@8fe00000 {
> > > +			no-map;
> > > +			reg = <0x8fe00000 0x20000>;
> > > +		};
> > > +
> > > +		aop_cmd_db: memory@8fe20000 {
> > > +			compatible = "qcom,cmd-db";
> > > +			reg = <0x8fe20000 0x20000>;
> > > +			no-map;
> > > +		};
> > > +
> > > +		smem_mem: memory@8fe40000 {
> > > +			no-map;
> > > +			reg = <0x8fe40000 0xc0000>;
> > > +		};
> > > +
> > > +		tz_mem: memory@8ff00000 {
> > > +			no-map;
> > > +			reg = <0x8ff00000 0x100000>;
> > > +		};
> > > +
> > > +		tz_apps_mem: memory@0x90000000 {
> > > +			no-map;
> > > +			reg = <0x90000000 0x500000>;
> > > +		};
> > > +
> > > +		mpss_adsp_mem: memory@90800000 {
> > > +			no-map;
> > > +			reg = <0x90800000 0xf800000>;
> > 
> > Didn't you say this moved to 0x9c000000?
> > 
> 
> That's for an old bootloader which is used in the MTP. But I guess we should
> always use the latest mem map for the latest bootloader.
> 

That reminds me, a number of times we're learned that these are at least
related to which firmware the individual vendors are shipping on their
devices. So the peripheral (remoteproc) regions is better to push out to
the board file.

I.e. that would (probably) be &mpss_debug_mem, &ipa_fw_mem and
&mpss_adsp_mem.

Regards,
Bjorn

Re: [PATCH v2 02/18] ARM: dts: qcom: sdx55: Add reserved memory nodes

[Manivannan Sadhasivam]

On Tue, Jan 05, 2021 at 09:42:11PM -0600, Bjorn Andersson wrote:
> On Tue 05 Jan 21:07 CST 2021, Manivannan Sadhasivam wrote:
> 
> > On Tue, Jan 05, 2021 at 12:05:49PM -0600, Bjorn Andersson wrote:
> > > On Tue 05 Jan 06:26 CST 2021, Manivannan Sadhasivam wrote:
> > > 
> > > > From: Vinod Koul <vkoul@kernel.org>
> > > > 
> > > > This adds reserved memory nodes to the SDX55 dtsi as defined by v8 of
> > > > the memory map
> > > > 
> > > > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > > ---
> > > >  arch/arm/boot/dts/qcom-sdx55.dtsi | 67 +++++++++++++++++++++++++++++++
> > > >  1 file changed, 67 insertions(+)
> > > > 
> > > > diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > > > index 08b4a40338fa..eeb6bf392f93 100644
> > > > --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> > > > +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > > > @@ -60,6 +60,73 @@ psci {
> > > >  		method = "smc";
> > > >  	};
> > > >  

[...]

> > > > +		mpss_adsp_mem: memory@90800000 {
> > > > +			no-map;
> > > > +			reg = <0x90800000 0xf800000>;
> > > 
> > > Didn't you say this moved to 0x9c000000?
> > > 
> > 
> > That's for an old bootloader which is used in the MTP. But I guess we should
> > always use the latest mem map for the latest bootloader.
> > 
> 
> That reminds me, a number of times we're learned that these are at least
> related to which firmware the individual vendors are shipping on their
> devices. So the peripheral (remoteproc) regions is better to push out to
> the board file.
> 
> I.e. that would (probably) be &mpss_debug_mem, &ipa_fw_mem and
> &mpss_adsp_mem.
> 

Okay.

Thanks,
Mani

> Regards,
> Bjorn

Re: [PATCH v2 10/18] ARM: dts: qcom: sdx55: Add QPIC NAND support

[Manivannan Sadhasivam]

On Tue, Jan 05, 2021 at 09:21:02PM +0530, Vinod Koul wrote:
> On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> > Add qpic_nand node to support QPIC NAND controller on SDX55 platform.
> > Since there is no "aon" clock in SDX55, a dummy clock is provided.
> > 
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> >  arch/arm/boot/dts/qcom-sdx55.dtsi | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > index 1b9b990ad0a2..1a6947753972 100644
> > --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> > +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > @@ -41,6 +41,12 @@ pll_test_clk: pll-test-clk {
> >  			#clock-cells = <0>;
> >  			clock-frequency = <400000000>;
> >  		};
> > +
> > +		nand_clk_dummy: nand-clk-dummy {
> 
> Why dummy..? 

There is no such clock used on this platform but the driver requires it.

> > +			compatible = "fixed-clock";
> > +			#clock-cells = <0>;
> > +			clock-frequency = <32000>;
> 
> Is this sleep clock of platform..?
> 

Always ON (AON) clock.

Thanks,
Mani

Re: [PATCH v2 04/18] ARM: dts: qcom: sdx55: Add support for SDHCI controller

[Manivannan Sadhasivam]

On Tue, Jan 05, 2021 at 09:22:59PM +0530, Vinod Koul wrote:
> On 05-01-21, 17:56, Manivannan Sadhasivam wrote:
> > Add devicetree support for SDHCI controller found in Qualcomm SDX55 SoC.
> > The SDHCI controller used in this SoC is based on the MSM SDHCI v5 IP.
> > Hence, the support is added by reusing the existing sdhci driver with
> > "qcom,sdhci-msm-v5" as the fallback.
> > 
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> >  arch/arm/boot/dts/qcom-sdx55.dtsi | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > index eeb6bf392f93..3f8e98bfc020 100644
> > --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> > +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> > @@ -154,6 +154,18 @@ blsp1_uart3: serial@831000 {
> >  			status = "disabled";
> >  		};
> >  
> > +		sdhc_1: sdhci@8804000 {
> 
> Any reason why this is sdhc_1 label, do we have another one..?
> 

The documentation lists this as SDC1 eventhough there seems to be no other
instances.

Thanks,
Mani

Re: [PATCH v2 18/18] ARM: dts: qcom: sdx55-mtp: Add regulator nodes

[Manivannan Sadhasivam]

On Tue, Jan 05, 2021 at 12:16:11PM -0600, Bjorn Andersson wrote:
> On Tue 05 Jan 06:26 CST 2021, Manivannan Sadhasivam wrote:
> 
> > From: Vinod Koul <vkoul@kernel.org>
> > 
> > This adds the regulators found on SDX55 MTP.
> > 
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> >  arch/arm/boot/dts/qcom-sdx55-mtp.dts | 179 +++++++++++++++++++++++++++
> >  1 file changed, 179 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-sdx55-mtp.dts b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> > index 825cc7d0ba18..61e7d5d4bd48 100644
> > --- a/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> > +++ b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> > @@ -6,6 +6,7 @@
> >  
> >  /dts-v1/;
> >  
> > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> >  #include "qcom-sdx55.dtsi"
> >  #include <arm64/qcom/pm8150b.dtsi>
> >  #include "qcom-pmx55.dtsi"
> > @@ -22,6 +23,184 @@ aliases {
> >  	chosen {
> >  		stdout-path = "serial0:115200n8";
> >  	};
> > +
> > +	vph_pwr: vph-pwr-regulator {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vph_pwr";
> > +		regulator-min-microvolt = <3700000>;
> > +		regulator-max-microvolt = <3700000>;
> > +	};
> > +
> > +	vreg_bob_3p3: pmx55-bob {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vreg_bob_3p3";
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +
> > +		regulator-always-on;
> > +		regulator-boot-on;
> > +
> > +		vin-supply = <&vph_pwr>;
> > +	};
> > +
> > +	vreg_s7e_mx_0p752: pmx55-s7e {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vreg_s7e_mx_0p752";
> > +		regulator-min-microvolt = <752000>;
> > +		regulator-max-microvolt = <752000>;
> > +
> > +		vin-supply = <&vph_pwr>;
> > +	};
> > +
> > +	vreg_vddpx_2: vddpx-2 {
> 
> Isn't this the name of the pad on the SoC, i.e. the consumer? Does the
> regulator output have a more suitable name?
>

The reference is from the downstream dts.
 
> I don't see any references to this node and you got it "boot-on", what
> happens when the regulator core tuns it off? Or this isn't an issue
> until we actually try to support sdhci (guessing based on the voltages)?
> 

I think we can ignore this regulator since there is no SDHCI support in MTP.

Thanks,
Mani

> Regards,
> Bjorn
> 
> > +		compatible = "regulator-gpio";
> > +		regulator-name = "vreg_vddpx_2";
> > +		regulator-min-microvolt = <1800000>;
> > +		regulator-max-microvolt = <2850000>;
> > +		enable-gpios = <&tlmm 98 GPIO_ACTIVE_HIGH>;
> > +		gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;
> > +		states = <1800000 0>, <2850000 1>;
> > +		startup-delay-us = <200000>;
> > +		enable-active-high;
> > +		regulator-boot-on;
> > +
> > +		vin-supply = <&vph_pwr>;
> > +	};
> > +};
> > +
> > +&apps_rsc {
> > +	pmx55-rpmh-regulators {
> > +		compatible = "qcom,pmx55-rpmh-regulators";
> > +		qcom,pmic-id = "e";
> > +
> > +		vdd-s1-supply = <&vph_pwr>;
> > +		vdd-s2-supply = <&vph_pwr>;
> > +		vdd-s3-supply = <&vph_pwr>;
> > +		vdd-s4-supply = <&vph_pwr>;
> > +		vdd-s5-supply = <&vph_pwr>;
> > +		vdd-s6-supply = <&vph_pwr>;
> > +		vdd-s7-supply = <&vph_pwr>;
> > +		vdd-l1-l2-supply = <&vreg_s2e_1p224>;
> > +		vdd-l3-l9-supply = <&vreg_s3e_0p824>;
> > +		vdd-l4-l12-supply = <&vreg_s4e_1p904>;
> > +		vdd-l5-l6-supply = <&vreg_s4e_1p904>;
> > +		vdd-l7-l8-supply = <&vreg_s3e_0p824>;
> > +		vdd-l10-l11-l13-supply = <&vreg_bob_3p3>;
> > +		vdd-l14-supply = <&vreg_s7e_mx_0p752>;
> > +		vdd-l15-supply = <&vreg_s2e_1p224>;
> > +		vdd-l16-supply = <&vreg_s4e_1p904>;
> > +
> > +		vreg_s2e_1p224: smps2 {
> > +			regulator-min-microvolt = <1280000>;
> > +			regulator-max-microvolt = <1400000>;
> > +		};
> > +
> > +		vreg_s3e_0p824: smps3 {
> > +			regulator-min-microvolt = <800000>;
> > +			regulator-max-microvolt = <1000000>;
> > +		};
> > +
> > +		vreg_s4e_1p904: smps4 {
> > +			regulator-min-microvolt = <1800000>;
> > +			regulator-max-microvolt = <1960000>;
> > +		};
> > +
> > +		ldo1 {
> > +			regulator-min-microvolt = <1200000>;
> > +			regulator-max-microvolt = <1200000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo2 {
> > +			regulator-min-microvolt = <1128000>;
> > +			regulator-max-microvolt = <1128000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo3 {
> > +			regulator-min-microvolt = <800000>;
> > +			regulator-max-microvolt = <800000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo4 {
> > +			regulator-min-microvolt = <872000>;
> > +			regulator-max-microvolt = <872000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo5 {
> > +			regulator-min-microvolt = <1704000>;
> > +			regulator-max-microvolt = <1900000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo6 {
> > +			regulator-min-microvolt = <1800000>;
> > +			regulator-max-microvolt = <1800000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo7 {
> > +			regulator-min-microvolt = <480000>;
> > +			regulator-max-microvolt = <900000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo8 {
> > +			regulator-min-microvolt = <480000>;
> > +			regulator-max-microvolt = <900000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo9 {
> > +			regulator-min-microvolt = <800000>;
> > +			regulator-max-microvolt = <800000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo10 {
> > +			regulator-min-microvolt = <3088000>;
> > +			regulator-max-microvolt = <3088000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo11 {
> > +			regulator-min-microvolt = <1704000>;
> > +			regulator-max-microvolt = <2928000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo12 {
> > +			regulator-min-microvolt = <1200000>;
> > +			regulator-max-microvolt = <1200000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo13 {
> > +			regulator-min-microvolt = <1704000>;
> > +			regulator-max-microvolt = <2928000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo14 {
> > +			regulator-min-microvolt = <600000>;
> > +			regulator-max-microvolt = <800000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo15 {
> > +			regulator-min-microvolt = <1200000>;
> > +			regulator-max-microvolt = <1200000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +
> > +		ldo16 {
> > +			regulator-min-microvolt = <1704000>;
> > +			regulator-max-microvolt = <1904000>;
> > +			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > +		};
> > +	};
> >  };
> >  
> >  &blsp1_uart3 {
> > -- 
> > 2.25.1
> >