linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Skrabec" <jernej.skrabec@siol.net>,
	"Hans Verkuil" <hverkuil@xs4all.nl>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	kevin.lhopital@hotmail.com,
	"Kévin L'hôpital" <kevin.lhopital@bootlin.com>
Subject: Re: [PATCH v4 2/3] media: i2c: Add support for the OV8865 image sensor
Date: Tue, 5 Jan 2021 16:41:50 +0200	[thread overview]
Message-ID: <20210105144150.GS11878@paasikivi.fi.intel.com> (raw)
In-Reply-To: <X/Qzp8/4gd/ANdXh@aptenodytes>

Hi Paul,

On Tue, Jan 05, 2021 at 10:38:47AM +0100, Paul Kocialkowski wrote:
> Hi Sakari,
> 
> On Mon 04 Jan 21, 14:07, Sakari Ailus wrote:
> > Hi Paul,
> > 
> > On Thu, Dec 31, 2020 at 03:27:01PM +0100, Paul Kocialkowski wrote:
> > > The OV8865 is a 8 Mpx CMOS image sensor producing 3264x2448 at 30 fps.
> > > Other modes (including some with sub-sampling) are available too.
> > > It outputs 10-bit bayer CFA data through a MIPI CSI-2 interface with
> > > up to 4 lanes supported.
> > 
> > I've added the patches to a pull request to Mauro; there appear to still be
> > some checkpatch.pl issues in both of the drivers.
> > 
> > I don't mind the warnings on the assignment or the mutex though. Could you
> > address these in additional patches, please?
> 
> Sorry about that, I realized that I never run checkpatch with --strict
> so I completely missed those.
> 
> I'll fix the cosmetic issues in a following patch.
> 
> Just to clarify one thing:
> #define OV8865_PAD_PK_DRIVE_STRENGTH_2X		(1 << 5)
> #define OV8865_BLC_CTRL1_COL_SHIFT_128		(1 << 4)
> 
> these are not single-bit fields so even though it looks like they should
> use BIT(), this would be incoherent with other possible values, such as:
> #define OV8865_PAD_PK_DRIVE_STRENGTH_3X		(2 << 5)
> #define OV8865_BLC_CTRL1_COL_SHIFT_64		(2 << 4)

Agreed.

You might not assign the top bit, but if you did, the left operand would
have to be unsigned to guarantee the intended result (otherwise it's
undefined).

-- 
Sakari Ailus

  reply	other threads:[~2021-01-05 14:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-31 14:26 [PATCH v4 0/3] media: i2c: OV8865 image sensor support Paul Kocialkowski
2020-12-31 14:27 ` [PATCH v4 1/3] dt-bindings: media: i2c: Add OV8865 bindings documentation Paul Kocialkowski
2020-12-31 14:27 ` [PATCH v4 2/3] media: i2c: Add support for the OV8865 image sensor Paul Kocialkowski
2021-01-04 12:07   ` Sakari Ailus
2021-01-05  9:38     ` Paul Kocialkowski
2021-01-05 14:41       ` Sakari Ailus [this message]
2021-01-05 14:49         ` Paul Kocialkowski
2020-12-31 14:27 ` [PATCH NOT FOR MERGE v4 3/3] ARM: dts: sun8i: a83t: bananapi-m3: Enable MIPI CSI-2 with OV8865 Paul Kocialkowski
  -- strict thread matches above, loose matches on Subject: below --
2020-12-11 15:44 [PATCH v4 0/3] media: i2c: OV8865 image sensor support Paul Kocialkowski
2020-12-11 15:44 ` [PATCH v4 2/3] media: i2c: Add support for the OV8865 image sensor Paul Kocialkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210105144150.GS11878@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil@xs4all.nl \
    --cc=jernej.skrabec@siol.net \
    --cc=kevin.lhopital@bootlin.com \
    --cc=kevin.lhopital@hotmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mripard@kernel.org \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).