From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A05FC433E0 for ; Wed, 6 Jan 2021 07:53:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE62623109 for ; Wed, 6 Jan 2021 07:53:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727205AbhAFHx0 (ORCPT ); Wed, 6 Jan 2021 02:53:26 -0500 Received: from mga02.intel.com ([134.134.136.20]:58640 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727047AbhAFHxW (ORCPT ); Wed, 6 Jan 2021 02:53:22 -0500 IronPort-SDR: Ir8vJOleTLztTCE255dgnsUbRiYA5/h/Yc7BdGhfgkxDPc/sqYQqTPDI2Ha0duGKNaiMA4JhJA AlcZVV1BS8kw== X-IronPort-AV: E=McAfee;i="6000,8403,9855"; a="164315970" X-IronPort-AV: E=Sophos;i="5.78,479,1599548400"; d="scan'208";a="164315970" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2021 23:52:41 -0800 IronPort-SDR: vzSTcC9jT6yZ03ArRvQdODG5E7MR8/CJtMqxNGXdMsj+MOstxE4FSxYB+W2YpbaY3bmxdTkRtI xJLPlPXnZnyg== X-IronPort-AV: E=Sophos;i="5.78,479,1599548400"; d="scan'208";a="346565754" Received: from shuo-intel.sh.intel.com (HELO localhost) ([10.239.154.30]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2021 23:52:37 -0800 Date: Wed, 6 Jan 2021 15:52:35 +0800 From: Shuo A Liu To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Greg Kroah-Hartman , "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , Sean Christopherson , Yu Wang , Reinette Chatre , Yakui Zhao , Nick Desaulniers , Dave Hansen , Dan Williams , Fengwei Yin , Zhi Wang , Zhenyu Wang , Arvind Sankar , Peter Zijlstra , Segher Boessenkool Subject: Re: [PATCH v6 04/18] x86/acrn: Introduce hypercall interfaces Message-ID: <20210106075235.GA22447@shuo-intel.sh.intel.com> References: <20201201093853.12070-1-shuo.a.liu@intel.com> <20201201093853.12070-5-shuo.a.liu@intel.com> <20201230173305.GF22022@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20201230173305.GF22022@zn.tnic> User-Agent: Mutt/1.8.3 (2017-05-23) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 30.Dec'20 at 18:33:05 +0100, Borislav Petkov wrote: >On Tue, Dec 01, 2020 at 05:38:39PM +0800, shuo.a.liu@intel.com wrote: >> From: Shuo Liu >> >> The Service VM communicates with the hypervisor via conventional >> hypercalls. VMCALL instruction is used to make the hypercalls. >> >> ACRN hypercall ABI: >> * Hypercall number is in R8 register. >> * Up to 2 parameters are in RDI and RSI registers. >> * Return value is in RAX register. >> >> Introduce the ACRN hypercall interfaces. Because GCC doesn't support R8 >> register as direct register constraints, use supported constraint as >> input with a explicit MOV to R8 in beginning of asm. >> >> Originally-by: Yakui Zhao >> Signed-off-by: Shuo Liu >> Reviewed-by: Reinette Chatre >> Reviewed-by: Nick Desaulniers >> Cc: Dave Hansen >> Cc: Sean Christopherson >> Cc: Dan Williams >> Cc: Fengwei Yin >> Cc: Zhi Wang >> Cc: Zhenyu Wang >> Cc: Yu Wang >> Cc: Reinette Chatre >> Cc: Greg Kroah-Hartman >> Cc: Borislav Petkov >> Cc: Arvind Sankar >> Cc: Peter Zijlstra >> Cc: Nick Desaulniers >> Cc: Segher Boessenkool >> --- >> arch/x86/include/asm/acrn.h | 54 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 54 insertions(+) > >The x86 bits in patches 2-4 look ok now, thanks! > >Acked-by: Borislav Petkov Thanks for review! Shuo