From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80CA0C433E0 for ; Wed, 6 Jan 2021 16:45:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 425AA23132 for ; Wed, 6 Jan 2021 16:45:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727673AbhAFQpN (ORCPT ); Wed, 6 Jan 2021 11:45:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:53842 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727177AbhAFQpM (ORCPT ); Wed, 6 Jan 2021 11:45:12 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C92D123132; Wed, 6 Jan 2021 16:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609951472; bh=e4tUkqNaZkqQTwm0KVYjRZbhKx3YSzLR0ZJevmpAV0o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d6z/k89BS9nvZrJcyTm9N72JND36l1OI6Jz0FTpmRQQtAdLpUAI/ngjPmpA7U/xyI 2tG1pMbeqUKndDPverX9YZqdZx1wMC5fRcQqk4fpQPLnmB3DV6oH00NRz72Yl0ROCY A3F11qddQdkdSVhflI9HVtCJcqZkGsWyWFyRDFbgEbsR0ESY/KW3TMoVTmiLv5Y1Ft C9F9Lpof91yF67DTv6muG+lZ35SMtonaX1jPgPVkl4zqXuiPdI5bvw8lw0Dbo3Mr2M lRszP24zvhtxvpSN26MotEqH3zcjhGGsgV5jysq8QovwDVLT8jLo8AiM0KlruwzkUT vGu0vhvJT8HpA== Date: Wed, 6 Jan 2021 08:44:30 -0800 From: Jakub Kicinski To: dinghao.liu@zju.edu.cn Cc: "Konstantin Ryabitsev" , "Florian Fainelli" , "Andrew Lunn" , kjlu@umn.edu, "David S. Miller" , "Jesse Brandeburg" , "Arnd Bergmann" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe Message-ID: <20210106084430.291a90cc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <328f073a.222d7.176d7572f29.Coremail.dinghao.liu@zju.edu.cn> References: <20201223153304.GD3198262@lunn.ch> <20201223123218.1cf7d9cb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20201223210044.GA3253993@lunn.ch> <20201223131149.15fff8d2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <680850a9-8ab0-4672-498e-6dc740720da3@gmail.com> <20201223174146.37e62326@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20201224180631.l4zieher54ncqvwl@chatter.i7.local> <20201228202302.afkxtco27j4ahh6d@chatter.i7.local> <08e2b663-c144-d1bb-3f90-5e4ef240d14b@gmail.com> <20201228211417.m5gdnqexjzgt4ix6@chatter.i7.local> <20201230133618.7c242856@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <328f073a.222d7.176d7572f29.Coremail.dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Jan 2021 18:56:23 +0800 (GMT+08:00) dinghao.liu@zju.edu.cn wrote: > > I used this one for a test: > > > > https://patchwork.kernel.org/project/netdevbpf/patch/1609312994-121032-1-git-send-email-abaci-bugfix@linux.alibaba.com/ > > > > I'm not getting the Fixes tag when I download the mbox. > > It seems that automatically generating Fixes tags is a hard work. > Both patches and bugs could be complex. Sometimes even human cannot > determine which commit introduced a target bug. > > Is this an already implemented functionality? I'm not sure I understand. Indeed finding the right commit to use in a Fixes tag is not always easy, and definitely not easy to automate. Human validation is always required. If we could easily automate finding the commit which introduced a problem we wouldn't need to add the explicit tag, backporters could just run such script locally.. That's why it's best if the author does the digging and provides the right tag. The conversation with Konstantin and Florian was about automatically picking up Fixes tags from the mailing list by the patchwork software, when such tags are posted in reply to the original posting, just like review tags. But the tags are still generated by humans.