From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BD7AC433E0 for ; Wed, 6 Jan 2021 09:32:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1ED823102 for ; Wed, 6 Jan 2021 09:31:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726614AbhAFJbo (ORCPT ); Wed, 6 Jan 2021 04:31:44 -0500 Received: from foss.arm.com ([217.140.110.172]:37858 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726251AbhAFJbn (ORCPT ); Wed, 6 Jan 2021 04:31:43 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A81D81FB; Wed, 6 Jan 2021 01:30:57 -0800 (PST) Received: from bogus (unknown [10.57.35.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E261E3F719; Wed, 6 Jan 2021 01:30:55 -0800 (PST) Date: Wed, 6 Jan 2021 09:30:53 +0000 From: Sudeep Holla To: Jim Quinlan Cc: Jim Quinlan , Sudeep Holla , Florian Fainelli , bcm-kernel-feedback-list , "open list:SYSTEM CONTROL & POWER/MANAGEMENT INTERFACE Mes..." , open list Subject: Re: [PATCH v4 2/2] firmware: arm_scmi: Augment SMC/HVC to allow optional interrupt Message-ID: <20210106093053.tnlncqvcba7qnwnk@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 05, 2021 at 01:32:49PM -0500, Jim Quinlan wrote: [...] > > I don't think that is the case; the bottom routine, > do_wait_for_common(), decrements the x->done after a completion (which > does an increment). Regardless, I think it is prudent to add the > reinit patch you've provided below. > Ah right, but I will add that. > BTW, one thing I could have done was incorporate the timeout value but > I thought that since this is the "fast" call we shouldn't be timing > out at all. > Agreed, we can add it later. However it is not related to fast call, it is more for protection against failure of delivery of interrupt from the platform or any firmware responsible IMO. > > This electronic communication and the information and any files > > transmitted with it, or attached to it, are confidential and are intended > > solely for the use of the individual or entity to whom it is addressed and > > may contain information that is confidential, legally privileged, > > protected by privacy laws, or otherwise restricted from disclosure to > > anyone else. If you are not the intended recipient or the person > > responsible for delivering the e-mail to the intended recipient, you are > > hereby notified that any use, copying, distributing, dissemination, > > forwarding, printing, or copying of this e-mail is strictly prohibited. If > > you received this e-mail in error, please return the e-mail to the sender, > > delete it from your computer, and destroy any printed copy of it. I am assuming this was unintentional and ignoring. If not disregard my response. Otherwise you may need to fix your mail server. -- Regards, Sudeep