From: Borislav Petkov <bp@alien8.de>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: tglx@linutronix.de, fenghua.yu@intel.com, tony.luck@intel.com,
kuo-lang.tseng@intel.com, shakeelb@google.com,
valentin.schneider@arm.com, mingo@redhat.com, babu.moger@amd.com,
james.morse@arm.com, hpa@zytor.com, x86@kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH V2 1/4] x86/resctrl: Use IPI instead of task_work_add() to update PQR_ASSOC MSR
Date: Wed, 6 Jan 2021 12:19:58 +0100 [thread overview]
Message-ID: <20210106111958.GD5729@zn.tnic> (raw)
In-Reply-To: <17aa2fb38fc12ce7bb710106b3e7c7b45acb9e94.1608243147.git.reinette.chatre@intel.com>
On Thu, Dec 17, 2020 at 02:31:18PM -0800, Reinette Chatre wrote:
> +#ifdef CONFIG_SMP
> +static void update_task_closid_rmid(struct task_struct *t)
> +{
> + if (task_curr(t))
> + smp_call_function_single(task_cpu(t), _update_task_closid_rmid,
> + t, 1);
> }
> +#else
> +static void update_task_closid_rmid(struct task_struct *t)
> +{
> + _update_task_closid_rmid(t);
> +}
> +#endif
Why the ifdeffery? Why not simply:
static void update_task_closid_rmid(struct task_struct *t)
{
if (IS_ENABLED(CONFIG_SMP) && task_curr(t))
smp_call_function_single(task_cpu(t), _update_task_closid_rmid, t, 1);
else
_update_task_closid_rmid(t);
}
?
If no particular reason, I'll change it before committing.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-01-06 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 22:31 [PATCH V2 0/4] x86/resctrl: Fix a few issues in moving a task to a resource group Reinette Chatre
2020-12-17 22:31 ` [PATCH V2 1/4] x86/resctrl: Use IPI instead of task_work_add() to update PQR_ASSOC MSR Reinette Chatre
2021-01-06 11:19 ` Borislav Petkov [this message]
2021-01-07 22:11 ` Reinette Chatre
2020-12-17 22:31 ` [PATCH V2 2/4] x86/resctrl: Don't move a task to the same resource group Reinette Chatre
2020-12-17 22:31 ` [PATCH V2 3/4] x86/resctrl: Use task_curr() instead of task_struct->on_cpu to prevent unnecessary IPI Reinette Chatre
2020-12-17 22:31 ` [PATCH V2 4/4] x86/resctrl: Apply READ_ONCE/WRITE_ONCE to task_struct .rmid & .closid Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106111958.GD5729@zn.tnic \
--to=bp@alien8.de \
--cc=babu.moger@amd.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=kuo-lang.tseng@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=shakeelb@google.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=valentin.schneider@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).