* [PATCH -next] mtd: use resource_size
@ 2021-01-06 13:18 Zheng Yongjun
2021-01-06 14:49 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2021-01-06 13:18 UTC (permalink / raw)
To: miquel.raynal, richard, vigneshr, linux-mtd, linux-kernel; +Cc: Zheng Yongjun
Use resource_size rather than a verbose computation on
the end and start fields.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/mtd/maps/pci.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/maps/pci.c b/drivers/mtd/maps/pci.c
index 377ef0fc4e3e..ca00d211e73e 100644
--- a/drivers/mtd/maps/pci.c
+++ b/drivers/mtd/maps/pci.c
@@ -90,8 +90,8 @@ intel_iq80310_init(struct pci_dev *dev, struct map_pci_info *map)
u32 win_base;
map->map.bankwidth = 1;
- map->map.read = mtd_pci_read8,
- map->map.write = mtd_pci_write8,
+ map->map.read = mtd_pci_read8;
+ map->map.write = mtd_pci_write8;
map->map.size = 0x00800000;
map->base = ioremap(pci_resource_start(dev, 0),
@@ -185,8 +185,8 @@ intel_dc21285_init(struct pci_dev *dev, struct map_pci_info *map)
return -ENXIO;
map->map.bankwidth = 4;
- map->map.read = mtd_pci_read32,
- map->map.write = mtd_pci_write32,
+ map->map.read = mtd_pci_read32;
+ map->map.write = mtd_pci_write32;
map->map.size = len;
map->base = ioremap(base, len);
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mtd: use resource_size
2021-01-06 13:18 [PATCH -next] mtd: use resource_size Zheng Yongjun
@ 2021-01-06 14:49 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2021-01-06 14:49 UTC (permalink / raw)
To: Zheng Yongjun; +Cc: richard, vigneshr, linux-mtd, linux-kernel
Hello,
Zheng Yongjun <zhengyongjun3@huawei.com> wrote on Wed, 6 Jan 2021
21:18:31 +0800:
> Use resource_size rather than a verbose computation on
> the end and start fields.
The commit message and the patch content do not match.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/mtd/maps/pci.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/maps/pci.c b/drivers/mtd/maps/pci.c
> index 377ef0fc4e3e..ca00d211e73e 100644
> --- a/drivers/mtd/maps/pci.c
> +++ b/drivers/mtd/maps/pci.c
> @@ -90,8 +90,8 @@ intel_iq80310_init(struct pci_dev *dev, struct map_pci_info *map)
> u32 win_base;
>
> map->map.bankwidth = 1;
> - map->map.read = mtd_pci_read8,
> - map->map.write = mtd_pci_write8,
> + map->map.read = mtd_pci_read8;
> + map->map.write = mtd_pci_write8;
>
> map->map.size = 0x00800000;
> map->base = ioremap(pci_resource_start(dev, 0),
> @@ -185,8 +185,8 @@ intel_dc21285_init(struct pci_dev *dev, struct map_pci_info *map)
> return -ENXIO;
>
> map->map.bankwidth = 4;
> - map->map.read = mtd_pci_read32,
> - map->map.write = mtd_pci_write32,
> + map->map.read = mtd_pci_read32;
> + map->map.write = mtd_pci_write32;
> map->map.size = len;
> map->base = ioremap(base, len);
>
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-06 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-06 13:18 [PATCH -next] mtd: use resource_size Zheng Yongjun
2021-01-06 14:49 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).