From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E266C433E0 for ; Wed, 6 Jan 2021 15:24:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32B582311B for ; Wed, 6 Jan 2021 15:24:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726807AbhAFPYY (ORCPT ); Wed, 6 Jan 2021 10:24:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726251AbhAFPYX (ORCPT ); Wed, 6 Jan 2021 10:24:23 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABC23C06134C; Wed, 6 Jan 2021 07:23:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hNXRA1N/lF5UZHqtQKnDiy+PmmxY1oztmX6RyYI7W5U=; b=RH10tNZpLk8yPwd/05sn0bHC0 F7vEg3U8riC3I3ml5BcmAbjjNDi8bjKRuRkUTZFBt4azGEUTiVFd7Pdz9alo8J+Ru5TKfdBToiCEV i/Gnc3W9TPbyHqLrYGQ+3JpdtHwaCyCk09Koj7gL7EZ55ujsPelMNM+ae9PpEEiDhxiNhL84as0Hc V2ytOqAWNwMmr2crlw7pKnq8L/sL3VBqU49s1CeO6ooVkd4ytW81xfn9CDZSpWsjm78pxpveJcNUA ATybVLoIz/M95fFdvV5Ke1/S3JoHHqngKRLd59beFZMJdFg/MUHI8cPGxg97G43589d9EBJsHGOvN SOUSppHBQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45188) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxAex-0001jj-8U; Wed, 06 Jan 2021 15:23:39 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kxAex-0000Kr-0z; Wed, 06 Jan 2021 15:23:39 +0000 Date: Wed, 6 Jan 2021 15:23:39 +0000 From: Russell King - ARM Linux admin To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Andrew Lunn , Thomas Schreiber , Heiner Kallweit , "David S. Miller" , Jakub Kicinski , Marek =?iso-8859-1?Q?Beh=FAn?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Message-ID: <20210106152338.GN1605@shell.armlinux.org.uk> References: <20201230190958.GW1551@shell.armlinux.org.uk> <20201231121410.2xlxtyqjelrlysd2@pali> <20201231170039.zkoa6mij3q3gt7c6@pali> <20210102014955.2xv27xla65eeqyzz@pali> <20210103024132.fpvjumilazrxiuzj@pali> <20210106145532.xynhoufpfyzmurd5@pali> <20210106152138.GK1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210106152138.GK1551@shell.armlinux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 06, 2021 at 03:21:38PM +0000, Russell King - ARM Linux admin wrote: > On Wed, Jan 06, 2021 at 03:55:32PM +0100, Pali Rohár wrote: > > On my tested CarlitoxxPro module is: > > > > Option values : 0x00 0x1c > > Option : RX_LOS implemented, inverted > > Option : TX_FAULT implemented > > Option : TX_DISABLE implemented > > > > When cable is disconnected then in EEPROM at position 0x16e is value > > 0x82. If I call 'ip link set eth1 up' then value changes to 0x02, module > > itself has a link and I can connect to its internal telnet/webserver to > > configure it. > > Bit 7 reflects the TX_DISABLE pin state. Bit 1 reflects the RX_LOS pin > state. It isn't specified whether the inverted/non-inverted state is > reflected in bit 1 or not - the definition just says that bit 1 is > "Digital state of the RX_LOS Output Pin." > > > I also tested UBNT module and result is: > > > > Option values : 0x00 0x06 > > Option : RX_LOS implemented > > Option : RX_LOS implemented, inverted > > > > Which means that those bits are not implemented. > > > > Anyway I check position 0x16e and value on its value is randomly either > > 0x79 or 0xff independently of the state of the GPON module. > > > > So it is really not implemented on UBNT. > > There are enhanced options at offset 93 which tell you which of the > offset 110 signals are implemented. That's the ID EEPROM (A0) offset 93 for the Diagnostic address (A2) offset 110. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!