From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 093C6C433E0 for ; Thu, 7 Jan 2021 16:30:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2B6723428 for ; Thu, 7 Jan 2021 16:30:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728824AbhAGQ3r (ORCPT ); Thu, 7 Jan 2021 11:29:47 -0500 Received: from elvis.franken.de ([193.175.24.41]:34729 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727753AbhAGQ3q (ORCPT ); Thu, 7 Jan 2021 11:29:46 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kxY9o-0000Mi-01; Thu, 07 Jan 2021 17:29:04 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id A44DEC080E; Thu, 7 Jan 2021 17:26:40 +0100 (CET) Date: Thu, 7 Jan 2021 17:26:40 +0100 From: Thomas Bogendoerfer To: Nathan Chancellor Cc: John Crispin , Nick Desaulniers , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Dmitry Golovin Subject: Re: [PATCH] MIPS: lantiq: Explicitly compare LTQ_EBU_PCC_ISTAT against 0 Message-ID: <20210107162640.GB11882@alpha.franken.de> References: <20210105201548.50920-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210105201548.50920-1-natechancellor@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 05, 2021 at 01:15:48PM -0700, Nathan Chancellor wrote: > When building xway_defconfig with clang: > > arch/mips/lantiq/irq.c:305:48: error: use of logical '&&' with constant > operand [-Werror,-Wconstant-logical-operand] > if ((irq == LTQ_ICU_EBU_IRQ) && (module == 0) && LTQ_EBU_PCC_ISTAT) > ^ ~~~~~~~~~~~~~~~~~ > arch/mips/lantiq/irq.c:305:48: note: use '&' for a bitwise operation > if ((irq == LTQ_ICU_EBU_IRQ) && (module == 0) && LTQ_EBU_PCC_ISTAT) > ^~ > & > arch/mips/lantiq/irq.c:305:48: note: remove constant to silence this > warning > if ((irq == LTQ_ICU_EBU_IRQ) && (module == 0) && LTQ_EBU_PCC_ISTAT) > ~^~~~~~~~~~~~~~~~~~~~ > 1 error generated. > > Explicitly compare the constant LTQ_EBU_PCC_ISTAT against 0 to fix the > warning. Additionally, remove the unnecessary parentheses as this is a > simple conditional statement and shorthand '== 0' to '!'. > > Fixes: 3645da0276ae ("OF: MIPS: lantiq: implement irq_domain support") > Link: https://github.com/ClangBuiltLinux/linux/issues/807 > Reported-by: Dmitry Golovin > Signed-off-by: Nathan Chancellor > --- > arch/mips/lantiq/irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]