linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 -next] mfd: convert comma to semicolon
@ 2021-01-08  9:20 Zheng Yongjun
  2021-01-08 10:53 ` Lee Jones
  0 siblings, 1 reply; 4+ messages in thread
From: Zheng Yongjun @ 2021-01-08  9:20 UTC (permalink / raw)
  To: linux-kernel; +Cc: lee.jones, Zheng Yongjun

Replace a comma between expression statements by a semicolon.

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
 drivers/mfd/88pm860x-core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/mfd/88pm860x-core.c b/drivers/mfd/88pm860x-core.c
index c9bae71f643a..a9e0855b4c66 100644
--- a/drivers/mfd/88pm860x-core.c
+++ b/drivers/mfd/88pm860x-core.c
@@ -916,7 +916,7 @@ static void device_power_init(struct pm860x_chip *chip,
 	power_devs[0].platform_data = pdata->power;
 	power_devs[0].pdata_size = sizeof(struct pm860x_power_pdata);
 	power_devs[0].num_resources = ARRAY_SIZE(battery_resources);
-	power_devs[0].resources = &battery_resources[0],
+	power_devs[0].resources = &battery_resources[0];
 	ret = mfd_add_devices(chip->dev, 0, &power_devs[0], 1,
 			      &battery_resources[0], chip->irq_base, NULL);
 	if (ret < 0)
@@ -925,7 +925,7 @@ static void device_power_init(struct pm860x_chip *chip,
 	power_devs[1].platform_data = pdata->power;
 	power_devs[1].pdata_size = sizeof(struct pm860x_power_pdata);
 	power_devs[1].num_resources = ARRAY_SIZE(charger_resources);
-	power_devs[1].resources = &charger_resources[0],
+	power_devs[1].resources = &charger_resources[0];
 	ret = mfd_add_devices(chip->dev, 0, &power_devs[1], 1,
 			      &charger_resources[0], chip->irq_base, NULL);
 	if (ret < 0)
@@ -942,7 +942,7 @@ static void device_power_init(struct pm860x_chip *chip,
 		pdata->chg_desc->charger_regulators =
 			&chg_desc_regulator_data[0];
 		pdata->chg_desc->num_charger_regulators	=
-			ARRAY_SIZE(chg_desc_regulator_data),
+			ARRAY_SIZE(chg_desc_regulator_data);
 		power_devs[3].platform_data = pdata->chg_desc;
 		power_devs[3].pdata_size = sizeof(*pdata->chg_desc);
 		ret = mfd_add_devices(chip->dev, 0, &power_devs[3], 1,
@@ -958,7 +958,7 @@ static void device_onkey_init(struct pm860x_chip *chip,
 	int ret;
 
 	onkey_devs[0].num_resources = ARRAY_SIZE(onkey_resources);
-	onkey_devs[0].resources = &onkey_resources[0],
+	onkey_devs[0].resources = &onkey_resources[0];
 	ret = mfd_add_devices(chip->dev, 0, &onkey_devs[0],
 			      ARRAY_SIZE(onkey_devs), &onkey_resources[0],
 			      chip->irq_base, NULL);
@@ -972,7 +972,7 @@ static void device_codec_init(struct pm860x_chip *chip,
 	int ret;
 
 	codec_devs[0].num_resources = ARRAY_SIZE(codec_resources);
-	codec_devs[0].resources = &codec_resources[0],
+	codec_devs[0].resources = &codec_resources[0];
 	ret = mfd_add_devices(chip->dev, 0, &codec_devs[0],
 			      ARRAY_SIZE(codec_devs), &codec_resources[0], 0,
 			      NULL);
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 -next] mfd: convert comma to semicolon
  2021-01-08  9:20 [PATCH v2 -next] mfd: convert comma to semicolon Zheng Yongjun
@ 2021-01-08 10:53 ` Lee Jones
  2021-01-08 11:07   ` Joe Perches
  0 siblings, 1 reply; 4+ messages in thread
From: Lee Jones @ 2021-01-08 10:53 UTC (permalink / raw)
  To: Zheng Yongjun; +Cc: linux-kernel

On Fri, 08 Jan 2021, Zheng Yongjun wrote:

You're still not using the correct subject format.

It should be:

 "mfd: <driver>: Description starting with an uppercase char"

Code looks fine.

> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
>  drivers/mfd/88pm860x-core.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mfd/88pm860x-core.c b/drivers/mfd/88pm860x-core.c
> index c9bae71f643a..a9e0855b4c66 100644
> --- a/drivers/mfd/88pm860x-core.c
> +++ b/drivers/mfd/88pm860x-core.c
> @@ -916,7 +916,7 @@ static void device_power_init(struct pm860x_chip *chip,
>  	power_devs[0].platform_data = pdata->power;
>  	power_devs[0].pdata_size = sizeof(struct pm860x_power_pdata);
>  	power_devs[0].num_resources = ARRAY_SIZE(battery_resources);
> -	power_devs[0].resources = &battery_resources[0],
> +	power_devs[0].resources = &battery_resources[0];
>  	ret = mfd_add_devices(chip->dev, 0, &power_devs[0], 1,
>  			      &battery_resources[0], chip->irq_base, NULL);
>  	if (ret < 0)
> @@ -925,7 +925,7 @@ static void device_power_init(struct pm860x_chip *chip,
>  	power_devs[1].platform_data = pdata->power;
>  	power_devs[1].pdata_size = sizeof(struct pm860x_power_pdata);
>  	power_devs[1].num_resources = ARRAY_SIZE(charger_resources);
> -	power_devs[1].resources = &charger_resources[0],
> +	power_devs[1].resources = &charger_resources[0];
>  	ret = mfd_add_devices(chip->dev, 0, &power_devs[1], 1,
>  			      &charger_resources[0], chip->irq_base, NULL);
>  	if (ret < 0)
> @@ -942,7 +942,7 @@ static void device_power_init(struct pm860x_chip *chip,
>  		pdata->chg_desc->charger_regulators =
>  			&chg_desc_regulator_data[0];
>  		pdata->chg_desc->num_charger_regulators	=
> -			ARRAY_SIZE(chg_desc_regulator_data),
> +			ARRAY_SIZE(chg_desc_regulator_data);
>  		power_devs[3].platform_data = pdata->chg_desc;
>  		power_devs[3].pdata_size = sizeof(*pdata->chg_desc);
>  		ret = mfd_add_devices(chip->dev, 0, &power_devs[3], 1,
> @@ -958,7 +958,7 @@ static void device_onkey_init(struct pm860x_chip *chip,
>  	int ret;
>  
>  	onkey_devs[0].num_resources = ARRAY_SIZE(onkey_resources);
> -	onkey_devs[0].resources = &onkey_resources[0],
> +	onkey_devs[0].resources = &onkey_resources[0];
>  	ret = mfd_add_devices(chip->dev, 0, &onkey_devs[0],
>  			      ARRAY_SIZE(onkey_devs), &onkey_resources[0],
>  			      chip->irq_base, NULL);
> @@ -972,7 +972,7 @@ static void device_codec_init(struct pm860x_chip *chip,
>  	int ret;
>  
>  	codec_devs[0].num_resources = ARRAY_SIZE(codec_resources);
> -	codec_devs[0].resources = &codec_resources[0],
> +	codec_devs[0].resources = &codec_resources[0];
>  	ret = mfd_add_devices(chip->dev, 0, &codec_devs[0],
>  			      ARRAY_SIZE(codec_devs), &codec_resources[0], 0,
>  			      NULL);

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 -next] mfd: convert comma to semicolon
  2021-01-08 10:53 ` Lee Jones
@ 2021-01-08 11:07   ` Joe Perches
  2021-01-08 14:20     ` Lee Jones
  0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2021-01-08 11:07 UTC (permalink / raw)
  To: Lee Jones, Zheng Yongjun; +Cc: linux-kernel

On Fri, 2021-01-08 at 10:53 +0000, Lee Jones wrote:
> On Fri, 08 Jan 2021, Zheng Yongjun wrote:
> 
> You're still not using the correct subject format.
> 
> It should be:
> 
>  "mfd: <driver>: Description starting with an uppercase char"

IMO: overly pedantic



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 -next] mfd: convert comma to semicolon
  2021-01-08 11:07   ` Joe Perches
@ 2021-01-08 14:20     ` Lee Jones
  0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2021-01-08 14:20 UTC (permalink / raw)
  To: Joe Perches; +Cc: Zheng Yongjun, linux-kernel

On Fri, 08 Jan 2021, Joe Perches wrote:

> On Fri, 2021-01-08 at 10:53 +0000, Lee Jones wrote:
> > On Fri, 08 Jan 2021, Zheng Yongjun wrote:
> > 
> > You're still not using the correct subject format.
> > 
> > It should be:
> > 
> >  "mfd: <driver>: Description starting with an uppercase char"
> 
> IMO: overly pedantic

Duly noted.

This is something I usually fix-up myself.  However, since this is
something I already mentioned when reviewing the first iteration of
this patch (with proper feedback) and it seems to have been ignored,
I'm going to ask for a v3.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-08 14:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08  9:20 [PATCH v2 -next] mfd: convert comma to semicolon Zheng Yongjun
2021-01-08 10:53 ` Lee Jones
2021-01-08 11:07   ` Joe Perches
2021-01-08 14:20     ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).