From: matthias.bgg@kernel.org
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>,
Axel Lin <axel.lin@ingics.com>,
Chen Zhong <chen.zhong@mediatek.com>,
Gene Chen <gene_chen@richtek.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Matthias Brugger <mbrugger@suse.com>
Subject: [PATCH 2/3] regulator: mt6358: Add OF match table
Date: Sat, 9 Jan 2021 03:10:45 +0100 [thread overview]
Message-ID: <20210109021046.21907-2-matthias.bgg@kernel.org> (raw)
In-Reply-To: <20210109021046.21907-1-matthias.bgg@kernel.org>
From: Matthias Brugger <mbrugger@suse.com>
The binding documentation mentions that a compatible is required for the
MT6358 device node. But the driver does not provide a OF match table.
This way auto-loading is broken as the MFD driver that registers the
device has a .of_compatible set which makes the platform .uevent
callback report a OF modalias, but that's not in the module.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
drivers/regulator/mt6358-regulator.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/regulator/mt6358-regulator.c b/drivers/regulator/mt6358-regulator.c
index 13cb6ac9a892..6cadb6d4dfe4 100644
--- a/drivers/regulator/mt6358-regulator.c
+++ b/drivers/regulator/mt6358-regulator.c
@@ -534,9 +534,16 @@ static const struct platform_device_id mt6358_platform_ids[] = {
};
MODULE_DEVICE_TABLE(platform, mt6358_platform_ids);
+static const struct of_device_id mt6358_of_match[] = {
+ { .compatible = "mediatek,mt6358-regulator", },
+ { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, mt6358_of_match);
+
static struct platform_driver mt6358_regulator_driver = {
.driver = {
.name = "mt6358-regulator",
+ .of_match_table = of_match_ptr(mt6358_of_match),
},
.probe = mt6358_regulator_probe,
.id_table = mt6358_platform_ids,
--
2.29.2
next prev parent reply other threads:[~2021-01-09 2:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 2:10 [PATCH 1/3] regulator: mt6360: Add OF match table matthias.bgg
2021-01-09 2:10 ` matthias.bgg [this message]
2021-01-09 2:10 ` [PATCH 3/3] regulator: mt6323: " matthias.bgg
2021-01-09 5:24 ` kernel test robot
2021-01-09 10:44 ` [PATCH 1/3] regulator: mt6360: " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210109021046.21907-2-matthias.bgg@kernel.org \
--to=matthias.bgg@kernel.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=chen.zhong@mediatek.com \
--cc=gene_chen@richtek.com \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mbrugger@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).