From: Aditya Srivastava <yashsri421@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: pkshih@realtek.com, kvalo@codeaurora.org, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
lukas.bulwahn@gmail.com, yashsri421@gmail.com
Subject: [PATCH 2/5] rtlwifi: rtl8192c-common: fix bool comparison in expressions
Date: Sun, 10 Jan 2021 17:45:22 +0530 [thread overview]
Message-ID: <20210110121525.2407-3-yashsri421@gmail.com> (raw)
In-Reply-To: <20210110121525.2407-1-yashsri421@gmail.com>
There are certain conditional expressions in rtl8192c-common, where a
boolean variable is compared with true/false, in forms such as
(foo == true) or (false != bar), which does not comply with checkpatch.pl
(CHECK: BOOL_COMPARISON), according to which boolean variables should be
themselves used in the condition, rather than comparing with true/false
E.g., in drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c,
"else if (initialized == false) {" can be replaced with
"else if (!initialized) {"
Replace all such expressions with the bool variables appropriately
Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
index 265a1a336304..0b6a15c2e5cc 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
@@ -380,7 +380,7 @@ static void rtl92c_dm_initial_gain_multi_sta(struct ieee80211_hw *hw)
initialized = false;
dm_digtable->dig_ext_port_stage = DIG_EXT_PORT_STAGE_MAX;
return;
- } else if (initialized == false) {
+ } else if (!initialized) {
initialized = true;
dm_digtable->dig_ext_port_stage = DIG_EXT_PORT_STAGE_0;
dm_digtable->cur_igvalue = 0x20;
@@ -509,7 +509,7 @@ static void rtl92c_dm_dig(struct ieee80211_hw *hw)
{
struct rtl_priv *rtlpriv = rtl_priv(hw);
- if (rtlpriv->dm.dm_initialgain_enable == false)
+ if (!rtlpriv->dm.dm_initialgain_enable)
return;
if (!(rtlpriv->dm.dm_flag & DYNAMIC_FUNC_DIG))
return;
--
2.17.1
next prev parent reply other threads:[~2021-01-10 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 15:32 [PATCH] drivers: net: wireless: rtlwifi: fix bool comparison in expressions Aditya Srivastava
2021-01-08 19:41 ` Larry Finger
2021-01-10 12:15 ` [PATCH 0/5] " Aditya Srivastava
2021-01-10 12:15 ` [PATCH 1/5] rtlwifi: rtl_pci: " Aditya Srivastava
2021-01-25 14:22 ` Kalle Valo
2021-01-10 12:15 ` Aditya Srivastava [this message]
2021-01-10 12:15 ` [PATCH 3/5] rtlwifi: rtl8188ee: " Aditya Srivastava
2021-01-10 12:15 ` [PATCH 4/5] rtlwifi: rtl8192se: " Aditya Srivastava
2021-01-10 12:15 ` [PATCH 5/5] rtlwifi: rtl8821ae: " Aditya Srivastava
2021-01-13 17:11 ` [PATCH] drivers: net: wireless: rtlwifi: " Aditya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210110121525.2407-3-yashsri421@gmail.com \
--to=yashsri421@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).