From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B64EC433E6 for ; Mon, 11 Jan 2021 19:54:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D426822CA1 for ; Mon, 11 Jan 2021 19:54:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404063AbhAKTyW (ORCPT ); Mon, 11 Jan 2021 14:54:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391318AbhAKTyV (ORCPT ); Mon, 11 Jan 2021 14:54:21 -0500 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80F60C061795 for ; Mon, 11 Jan 2021 11:53:41 -0800 (PST) Received: by mail-pj1-x102f.google.com with SMTP id l23so196482pjg.1 for ; Mon, 11 Jan 2021 11:53:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kqzAS7vv3isJxvxaKX99/4deyJqxK70Am6O+u1zhufI=; b=nXAUtCl5E6clL+2HewBlse6knjeO3Qp1aPdeuYBpDlz8EnXwTACfUnrSGm0VuMOjw1 NeS74Ipb8j/qW34RmwJt2LVEnF+By3NNt3nJYOYr9sp3TttH9K1qA3p2N9EIH3AitKXC YPuAv5EsYMTsYTnNVAx1szkPJdL9X18yzs2F0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kqzAS7vv3isJxvxaKX99/4deyJqxK70Am6O+u1zhufI=; b=fkuj5WJA/rD7sO5FcGfI4Uzs7OWVh1pfbfFlPaYzP6Mus+itPKnv5f7pnCoEVYXjG2 UYMNRjXVq8MFfHtFMo6caN28yTMQfVTCz2Z7YhzxNqVQKFbaUdHo0XKKLx3RXegEjeFo ygdfB3X2A9h2wE2stuVQU73z7qMZenqyILsxxy2ulKklIrPDDZPJiyd4Je+nalxg72oG 6e7ODognGyucrODZzcmL/AP/kWKs4WDMOVg2WcqepRVHrEOB/ZeA+IcqZ16+Ai7Xp4Oz JHqlBTg83ts/PXO05PKU/RDtIP52LVdxZKKQ9Bp7JINTf491Uq3VT3fl4HP1WGujsgXB UTiQ== X-Gm-Message-State: AOAM531l6gZFknPmW73OxSfOeYZXmgWvi4lKbQWUAnD/hdi6b9EDtHVl 5Tk9pERdHnIymmLcoc1QHr9UCA== X-Google-Smtp-Source: ABdhPJzvYP86OQ4uqkMtM24wFDq6qEnqHZO8PCbrEqVvaJXgt7NLlNssoaUa0+LDD1I6B0iBoCU/JQ== X-Received: by 2002:a17:902:eb53:b029:da:da92:c187 with SMTP id i19-20020a170902eb53b02900dada92c187mr1378702pli.34.1610394821104; Mon, 11 Jan 2021 11:53:41 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a23sm214136pjh.19.2021.01.11.11.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 11:53:40 -0800 (PST) Date: Mon, 11 Jan 2021 11:53:39 -0800 From: Kees Cook To: Alexander Lobakin Cc: Thomas Bogendoerfer , Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , Huacai Chen , Pei Huang , Fangrui Song , Jiaxun Yang , Ralf Baechle , Corey Minyard , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, stable@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH v5 mips-next 0/9] MIPS: vmlinux.lds.S sections fixes & cleanup Message-ID: <202101111153.AE5123B6@keescook> References: <20210110115245.30762-1-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210110115245.30762-1-alobakin@pm.me> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 10, 2021 at 11:53:50AM +0000, Alexander Lobakin wrote: > This series hunts the problems discovered after manual enabling of > ARCH_WANT_LD_ORPHAN_WARN. Notably: > - adds the missing PAGE_ALIGNED_DATA() section affecting VDSO > placement (marked for stable); > - stops blind catching of orphan text sections with .text.* > directive; > - properly stops .eh_frame section generation. > > Compile and runtime tested on MIPS32R2 CPS board with no issues > using two different toolkits: > - Binutils 2.35.1, GCC 10.2.1 (with Alpine patches); > - LLVM stack: 11.0.0 and from latest Git snapshot. > > Since v4 [3]: > - new: drop redundant .text.cps-vec creation and blind inclusion > of orphan text sections via .text.* directive in vmlinux.lds.S; > - don't assert SIZEOF(.rel.dyn) as it's reported that it may be not > empty on certain machines and compilers (Thomas); > - align GOT table like it's done for ARM64; > - new: catch UBSAN's "unnamed data" sections in generic definitions > when building with LD_DEAD_CODE_DATA_ELIMINATION; > - collect Reviewed-bys (Kees, Nathan). Looks good; which tree will this land through? -Kees > > Since v3 [2]: > - fix the third patch as GNU stack emits .rel.dyn into VDSO for > some reason if .cfi_sections is specified. > > Since v2 [1]: > - stop discarding .eh_frame and just prevent it from generating > (Kees); > - drop redundant sections assertions (Fangrui); > - place GOT table in .text instead of asserting as it's not empty > when building with LLVM (Nathan); > - catch compound literals in generic definitions when building with > LD_DEAD_CODE_DATA_ELIMINATION (Kees); > - collect two Reviewed-bys (Kees). > > Since v1 [0]: > - catch .got entries too as LLD may produce it (Nathan); > - check for unwanted sections to be zero-sized instead of > discarding (Fangrui). > > [0] https://lore.kernel.org/linux-mips/20210104121729.46981-1-alobakin@pm.me > [1] https://lore.kernel.org/linux-mips/20210106200713.31840-1-alobakin@pm.me > [2] https://lore.kernel.org/linux-mips/20210107115120.281008-1-alobakin@pm.me > [3] https://lore.kernel.org/linux-mips/20210107123331.354075-1-alobakin@pm.me > > Alexander Lobakin (9): > MIPS: vmlinux.lds.S: add missing PAGE_ALIGNED_DATA() section > MIPS: CPS: don't create redundant .text.cps-vec section > MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS > MIPS: properly stop .eh_frame generation > MIPS: vmlinux.lds.S: explicitly catch .rel.dyn symbols > MIPS: vmlinux.lds.S: explicitly declare .got table > vmlinux.lds.h: catch compound literals into data and BSS > vmlinux.lds.h: catch UBSAN's "unnamed data" into data > MIPS: select ARCH_WANT_LD_ORPHAN_WARN > > arch/mips/Kconfig | 1 + > arch/mips/include/asm/asm.h | 18 ++++++++++++++++++ > arch/mips/kernel/cps-vec.S | 1 - > arch/mips/kernel/vmlinux.lds.S | 11 +++++++++-- > include/asm-generic/vmlinux.lds.h | 6 +++--- > 5 files changed, 31 insertions(+), 6 deletions(-) > > -- > 2.30.0 > > -- Kees Cook