From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B4B4C4332B for ; Mon, 11 Jan 2021 13:43:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B740221FD for ; Mon, 11 Jan 2021 13:43:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387562AbhAKNn6 (ORCPT ); Mon, 11 Jan 2021 08:43:58 -0500 Received: from mx2.suse.de ([195.135.220.15]:59816 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387537AbhAKNnx (ORCPT ); Mon, 11 Jan 2021 08:43:53 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2F36DAB7A; Mon, 11 Jan 2021 13:43:11 +0000 (UTC) Date: Mon, 11 Jan 2021 14:43:08 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org, hca@linux.ibm.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Vasily Gorbik , Will Deacon , Ard Biesheuvel , Mark Rutland Subject: Re: [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform Message-ID: <20210111134303.GA3031@linux> References: <1608218912-28932-1-git-send-email-anshuman.khandual@arm.com> <1608218912-28932-2-git-send-email-anshuman.khandual@arm.com> <10e733fa-4568-d38f-9b95-2ccc5dc627b8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10e733fa-4568-d38f-9b95-2ccc5dc627b8@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 11:51:47AM +0100, David Hildenbrand wrote: > AFAIKs, all memhp_get_pluggable_range() users pass "1". > > What about the "add_pages()-only" path? I guess you refer to memremap_pages(), right? If so, moving the added memhp_range_allowed() check above the if-else might do the trick -- Oscar Salvador SUSE L3