From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F17AC433DB for ; Mon, 11 Jan 2021 14:20:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E96A222473 for ; Mon, 11 Jan 2021 14:20:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731781AbhAKOUR (ORCPT ); Mon, 11 Jan 2021 09:20:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727789AbhAKOUQ (ORCPT ); Mon, 11 Jan 2021 09:20:16 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D16EEC061786; Mon, 11 Jan 2021 06:19:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7VNCdPxVAptn3zY7xxux6AD0SS/xbvnIWER1FG+yRhA=; b=whFblDmwn1UOzb3TTni/blVYv eaEeiOFfOIrdZ0mYONDfBOu0Ul1CE0OKgR/2p/6PJY9HrV0ScZqR/YEsw17b8ODdUGa/VEI/qhdVG mNkYjkuGkjEmF+vHFv2v6s7q91sYNA8X4RymSJ4KX23UkziAURo2dPoYsmL3LsL0oq4QfKe9kRETj Cku+puCB55dqBXXyNZDFMJj/L+0ugT+8ZqSBGZzQine13vtQ9D13mSC0epMJ/X9uQXKGrdrYnKW/F 62VmKHYcVI8l6PLPLpa5Vl8YhkOvHmxWQyEiUy8jGchTFh9PYwqXneW3/j+Pul0/RIMqUD98etzrK h0Rx1T3yQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46624) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kyy2e-00078W-FP; Mon, 11 Jan 2021 14:19:32 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kyy2e-0005JJ-8b; Mon, 11 Jan 2021 14:19:32 +0000 Date: Mon, 11 Jan 2021 14:19:32 +0000 From: Russell King - ARM Linux admin To: Bjarni Jonasson Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver Subject: Re: [PATCH v1 1/2] net: phy: Add 100 base-x mode Message-ID: <20210111141932.GV1551@shell.armlinux.org.uk> References: <20210111130657.10703-1-bjarni.jonasson@microchip.com> <20210111130657.10703-2-bjarni.jonasson@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210111130657.10703-2-bjarni.jonasson@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 02:06:56PM +0100, Bjarni Jonasson wrote: > Sparx-5 supports this mode and it is missing in the PHY core. > > Signed-off-by: Bjarni Jonasson Looks good, thanks. Reviewed-by: Russell King > --- > include/linux/phy.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/phy.h b/include/linux/phy.h > index 56563e5e0dc7..dce867222d58 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -111,6 +111,7 @@ extern const int phy_10gbit_features_array[1]; > * @PHY_INTERFACE_MODE_10GBASER: 10G BaseR > * @PHY_INTERFACE_MODE_USXGMII: Universal Serial 10GE MII > * @PHY_INTERFACE_MODE_10GKR: 10GBASE-KR - with Clause 73 AN > + * @PHY_INTERFACE_MODE_100BASEX: 100 BaseX > * @PHY_INTERFACE_MODE_MAX: Book keeping > * > * Describes the interface between the MAC and PHY. > @@ -144,6 +145,7 @@ typedef enum { > PHY_INTERFACE_MODE_USXGMII, > /* 10GBASE-KR - with Clause 73 AN */ > PHY_INTERFACE_MODE_10GKR, > + PHY_INTERFACE_MODE_100BASEX, > PHY_INTERFACE_MODE_MAX, > } phy_interface_t; > > @@ -217,6 +219,8 @@ static inline const char *phy_modes(phy_interface_t interface) > return "usxgmii"; > case PHY_INTERFACE_MODE_10GKR: > return "10gbase-kr"; > + case PHY_INTERFACE_MODE_100BASEX: > + return "100base-x"; > default: > return "unknown"; > } > -- > 2.17.1 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!