From: Rob Herring <robh@kernel.org>
To: Charles Hsu <hsu.yungteng@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: (hwmon/pm6764tr) Add PM6764TR hwmon driver bindings
Date: Mon, 11 Jan 2021 14:42:00 -0600 [thread overview]
Message-ID: <20210111204200.GA3026535@robh.at.kernel.org> (raw)
In-Reply-To: <20201229071723.2219360-1-hsu.yungteng@gmail.com>
On Tue, Dec 29, 2020 at 03:17:23PM +0800, Charles Hsu wrote:
> Document device tree bindings for STMicroelectronics PM6764tr Voltage
> Regulator.
Subject space is valuable and you have 'hwmon', 'pm6764tr', and
'bindings' twice.
>
> Signed-off-by: Charles Hsu <hsu.yungteng@gmail.com>
> ---
> .../bindings/hwmon/pmbus/st,pm6764tr.yaml | 47 +++++++++++++++++++
> .../devicetree/bindings/trivial-devices.yaml | 2 +
> 2 files changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/st,pm6764tr.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/st,pm6764tr.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/st,pm6764tr.yaml
> new file mode 100644
> index 000000000000..b4b0d5614d8d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/st,pm6764tr.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/pmbus/st,pm6764tr.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: PM6764TR voltage regulator
> +
> +maintainers:
> + - Charles Hsu <hsu.yungteng@gmail.com>
> +
> +description: |
> + The PM6764/66 is a high performance digital controller designed to power
> + Intel’s VR12.5 processors (PM6766) and memories (PM6764): all required
> + parameters are programmable through a PMBus™ interface.
> + The device utilizes digital technology to implement all control and
> + power management functions to provide maximum flexibility and performance.
> + The NVM is embedded to store custom configurations.
> +
> + https://www.st.com/resource/en/data_brief/pm6764.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - st,pm6764tr
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pm6764tr@68 {
> + compatible = "st,pm6764tr";
> + reg = <0x68>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index bdc2dc318178..0a2dcd03220b 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -260,6 +260,8 @@ properties:
> - socionext,synquacer-tpm-mmio
> # i2c serial eeprom (24cxx)
> - st,24c256
> + # STMicroelectronics Voltage Regulator
> + - st,pm6764tr
It should be either in trivial-devices or its own schema file, not both.
> # Ambient Light Sensor with SMBUS/Two Wire Serial Interface
> - taos,tsl2550
> # Temperature Monitoring and Fan Control
> --
> 2.25.1
>
prev parent reply other threads:[~2021-01-11 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 7:17 [PATCH] dt-bindings: (hwmon/pm6764tr) Add PM6764TR hwmon driver bindings Charles Hsu
2021-01-11 20:42 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111204200.GA3026535@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hsu.yungteng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).