linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Calvin Johnson <calvin.johnson@oss.nxp.com>
To: Grant Likely <grant.likely@arm.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Jeremy Linton <jeremy.linton@arm.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Cristi Sovaiala <cristian.sovaiala@nxp.com>,
	Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Madalin Bucur <madalin.bucur@oss.nxp.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Marcin Wojtas <mw@semihalf.com>,
	Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>,
	Jon <jon@solid-run.com>
Cc: Diana Madalina Craciun <diana.craciun@nxp.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	linux-acpi@vger.kernel.org, linux.cj@gmail.com,
	linux-arm-kernel@lists.infradead.org,
	Calvin Johnson <calvin.johnson@oss.nxp.com>,
	"David S. Miller" <davem@davemloft.net>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>
Subject: [net-next PATCH v3 05/15] net: phy: Introduce fwnode_get_phy_id()
Date: Tue, 12 Jan 2021 19:10:44 +0530	[thread overview]
Message-ID: <20210112134054.342-6-calvin.johnson@oss.nxp.com> (raw)
In-Reply-To: <20210112134054.342-1-calvin.johnson@oss.nxp.com>

Extract phy_id from compatible string. This will be used by
fwnode_mdiobus_register_phy() to create phy device using the
phy_id.

Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com>
---

Changes in v3:
- Use traditional comparison pattern
- Use GENMASK

Changes in v2: None

 drivers/net/phy/phy_device.c | 21 +++++++++++++++++++++
 include/linux/phy.h          |  5 +++++
 2 files changed, 26 insertions(+)

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 66e779cd905a..6ebb67a19e69 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -846,6 +846,27 @@ static int get_phy_c22_id(struct mii_bus *bus, int addr, u32 *phy_id)
 	return 0;
 }
 
+/* Extract the phy ID from the compatible string of the form
+ * ethernet-phy-idAAAA.BBBB.
+ */
+int fwnode_get_phy_id(struct fwnode_handle *fwnode, u32 *phy_id)
+{
+	unsigned int upper, lower;
+	const char *cp;
+	int ret;
+
+	ret = fwnode_property_read_string(fwnode, "compatible", &cp);
+	if (ret)
+		return ret;
+
+	if (sscanf(cp, "ethernet-phy-id%4x.%4x", &upper, &lower) != 2)
+		return -EINVAL;
+
+	*phy_id = ((upper & GENMASK(15, 0)) << 16) | (lower & GENMASK(15, 0));
+	return 0;
+}
+EXPORT_SYMBOL(fwnode_get_phy_id);
+
 /**
  * get_phy_device - reads the specified PHY device and returns its @phy_device
  *		    struct
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 46b9637dc27e..28cd111f1b09 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -1342,6 +1342,7 @@ struct phy_device *phy_device_create(struct mii_bus *bus, int addr, u32 phy_id,
 				     bool is_c45,
 				     struct phy_c45_device_ids *c45_ids);
 #if IS_ENABLED(CONFIG_PHYLIB)
+int fwnode_get_phy_id(struct fwnode_handle *fwnode, u32 *phy_id);
 struct mdio_device *fwnode_mdio_find_device(struct fwnode_handle *fwnode);
 struct phy_device *fwnode_phy_find_device(struct fwnode_handle *phy_fwnode);
 struct phy_device *device_phy_find_device(struct device *dev);
@@ -1350,6 +1351,10 @@ struct phy_device *get_phy_device(struct mii_bus *bus, int addr, bool is_c45);
 int phy_device_register(struct phy_device *phy);
 void phy_device_free(struct phy_device *phydev);
 #else
+static inline int fwnode_get_phy_id(struct fwnode_handle *fwnode, u32 *phy_id)
+{
+	return 0;
+}
 static inline
 struct mdio_device *fwnode_mdio_find_device(struct fwnode_handle *fwnode)
 {
-- 
2.17.1


  parent reply	other threads:[~2021-01-12 13:43 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12 13:40 [net-next PATCH v3 00/15] ACPI support for dpaa2 driver Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 01/15] Documentation: ACPI: DSD: Document MDIO PHY Calvin Johnson
2021-01-18 22:12   ` Randy Dunlap
2021-01-12 13:40 ` [net-next PATCH v3 02/15] net: phy: Introduce fwnode_mdio_find_device() Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 03/15] net: phy: Introduce phy related fwnode functions Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 04/15] of: mdio: Refactor of_phy_find_device() Calvin Johnson
2021-01-12 13:40 ` Calvin Johnson [this message]
2021-01-12 13:40 ` [net-next PATCH v3 06/15] of: mdio: Refactor of_get_phy_id() Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 07/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy() Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 08/15] of: mdio: Refactor of_mdiobus_register_phy() Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id() Calvin Johnson
2021-01-12 15:48   ` Andy Shevchenko
2021-01-20 18:17     ` Rafael J. Wysocki
2021-01-20 18:45       ` Andy Shevchenko
2021-01-20 19:12         ` Rafael J. Wysocki
2021-01-12 17:30   ` Saravana Kannan
2021-01-12 18:03     ` Andy Shevchenko
2021-01-20 18:18       ` Rafael J. Wysocki
2021-01-20 18:52         ` Andy Shevchenko
2021-01-20 19:15           ` Rafael J. Wysocki
2021-01-20 20:01             ` Saravana Kannan
2021-01-22 16:34               ` Rafael J. Wysocki
2021-01-22 20:58                 ` Saravana Kannan
2021-01-22 21:06                   ` Andy Shevchenko
2021-01-22 21:07                     ` Saravana Kannan
2021-01-15 10:47     ` Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 10/15] net: mdio: Add ACPI support code for mdio Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 11/15] net: mdiobus: Introduce fwnode_mdiobus_register() Calvin Johnson
2021-01-12 15:52   ` Andy Shevchenko
2021-01-12 13:40 ` [net-next PATCH v3 12/15] net/fsl: Use fwnode_mdiobus_register() Calvin Johnson
2021-01-12 15:53   ` Andy Shevchenko
2021-01-12 13:40 ` [net-next PATCH v3 13/15] phylink: introduce phylink_fwnode_phy_connect() Calvin Johnson
2021-01-12 15:55   ` Andy Shevchenko
2021-01-19  4:05     ` Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 14/15] net: phylink: Refactor phylink_of_phy_connect() Calvin Johnson
2021-01-12 15:57   ` Andy Shevchenko
2021-01-19  4:08     ` Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210112134054.342-6-calvin.johnson@oss.nxp.com \
    --to=calvin.johnson@oss.nxp.com \
    --cc=andrew@lunn.ch \
    --cc=andy.shevchenko@gmail.com \
    --cc=cristian.sovaiala@nxp.com \
    --cc=davem@davemloft.net \
    --cc=diana.craciun@nxp.com \
    --cc=f.fainelli@gmail.com \
    --cc=florinlaurentiu.chiculita@nxp.com \
    --cc=grant.likely@arm.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=hkallweit1@gmail.com \
    --cc=ioana.ciornei@nxp.com \
    --cc=jeremy.linton@arm.com \
    --cc=jon@solid-run.com \
    --cc=kuba@kernel.org \
    --cc=laurentiu.tudor@nxp.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.cj@gmail.com \
    --cc=linux@armlinux.org.uk \
    --cc=madalin.bucur@oss.nxp.com \
    --cc=mw@semihalf.com \
    --cc=netdev@vger.kernel.org \
    --cc=pieter.jansenvv@bamboosystems.io \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).