From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Kyle Tso <kyletso@google.com>
Cc: linux@roeck-us.net, gregkh@linuxfoundation.org,
hdegoede@redhat.com, badhri@google.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/3] AMS, Collision Avoidance, and Protocol Error
Date: Tue, 12 Jan 2021 16:04:26 +0200 [thread overview]
Message-ID: <20210112140426.GE2020859@kuha.fi.intel.com> (raw)
In-Reply-To: <20210105163927.1376770-1-kyletso@google.com>
On Wed, Jan 06, 2021 at 12:39:24AM +0800, Kyle Tso wrote:
> This series include previous patch "[v4] AMS and Collision Avoidance"
> https://lore.kernel.org/r/20201217030632.903718-1-kyletso@google.com
> and two more patches "Protocol Error handling" and "Respond Wait if...".
>
> The patch "AMS and Collision Avoidance" in [v5] is the same as the one
> in [v4] (only rebased to ToT).
>
> The patch "Protocol Error handling" is based on PD3 6.8.1 to fix the
> wrong handling.
>
> The patch "Respond Wait if..." is to fix a conflict when
> DR/PR/VCONN_SWAP occurs just after the state machine enters Ready State.
>
> Kyle Tso (3):
> usb: typec: tcpm: AMS and Collision Avoidance
> usb: typec: tcpm: Protocol Error handling
> usb: typec: tcpm: Respond Wait if VDM state machine is running
>
> drivers/usb/typec/tcpm/tcpm.c | 925 +++++++++++++++++++++++++++++-----
> include/linux/usb/pd.h | 2 +
> include/linux/usb/tcpm.h | 4 +
> 3 files changed, 792 insertions(+), 139 deletions(-)
These are OK by me. The few comments I had were all minor nitpicks,
but I would appreciate if you could fix them in any case. After that,
FWIW:
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
thanks,
--
heikki
prev parent reply other threads:[~2021-01-12 14:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 16:39 [PATCH v5 0/3] AMS, Collision Avoidance, and Protocol Error Kyle Tso
2021-01-05 16:39 ` [PATCH v5 1/3] usb: typec: tcpm: AMS and Collision Avoidance Kyle Tso
2021-01-12 13:29 ` Heikki Krogerus
2021-01-13 6:10 ` Badhri Jagan Sridharan
2021-01-13 14:46 ` Kyle Tso
2021-01-13 20:55 ` Hans de Goede
2021-01-13 14:44 ` Kyle Tso
2021-01-05 16:39 ` [PATCH v5 2/3] usb: typec: tcpm: Protocol Error handling Kyle Tso
2021-01-12 13:56 ` Heikki Krogerus
2021-01-13 14:50 ` Kyle Tso
2021-01-05 16:39 ` [PATCH v5 3/3] usb: typec: tcpm: Respond Wait if VDM state machine is running Kyle Tso
2021-01-12 11:53 ` [PATCH v5 0/3] AMS, Collision Avoidance, and Protocol Error Greg KH
2021-01-12 11:57 ` Hans de Goede
2021-01-12 12:06 ` Greg KH
2021-01-12 11:59 ` Heikki Krogerus
2021-01-12 14:09 ` Guenter Roeck
2021-01-13 11:41 ` Heikki Krogerus
2021-01-12 14:04 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112140426.GE2020859@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).