From: Rob Herring <robh@kernel.org>
To: Roger Lu <roger.lu@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Enric Balletbo Serra <eballetbo@gmail.com>,
Kevin Hilman <khilman@kernel.org>,
Nicolas Boichat <drinkcat@google.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Fan Chen <fan.chen@mediatek.com>,
HenryC Chen <HenryC.Chen@mediatek.com>,
YT Lee <yt.lee@mediatek.com>,
Xiaoqing Liu <Xiaoqing.Liu@mediatek.com>,
Charles Yang <Charles.Yang@mediatek.com>,
Angus Lin <Angus.Lin@mediatek.com>,
Mark Rutland <mark.rutland@arm.com>, Nishanth Menon <nm@ti.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v11 1/7] dt-bindings: soc: mediatek: add mtk svs dt-bindings
Date: Tue, 12 Jan 2021 08:47:27 -0600 [thread overview]
Message-ID: <20210112144727.GA321805@robh.at.kernel.org> (raw)
In-Reply-To: <20210107024356.583-2-roger.lu@mediatek.com>
On Thu, Jan 07, 2021 at 10:43:50AM +0800, Roger Lu wrote:
> Document the binding for enabling mtk svs on MediaTek SoC.
>
> Signed-off-by: Roger Lu <roger.lu@mediatek.com>
> ---
> .../bindings/soc/mediatek/mtk-svs.yaml | 80 +++++++++++++++++++
> 1 file changed, 80 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml b/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml
> new file mode 100644
> index 000000000000..bb8c345a0c0a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/mediatek/mtk-svs.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Introduce MTK SVS engine
Introduce? That's what this commit does, not what this binding is.
> +
> +maintainers:
> + - Matthias Brugger <matthias.bgg@gmail.com>
> + - Kevin Hilman <khilman@kernel.org>
> + - Nishanth Menon <nm@ti.com>
This should be someone that knows the h/w. Not who applies patches.
Perhaps you.
> +
> +description: |+
> + The Smart Voltage Scaling(SVS) engine is a piece of hardware
> + which has several controllers(banks) for calculating suitable
> + voltage to different power domains(CPU/GPU/CCI) according to
> + chip process corner, temperatures and other factors. Then DVFS
> + driver could apply SVS bank voltage to PMIC/Buck.
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt8183-svs
> +
> + reg:
> + description: Address range of the MTK SVS controller.
> + maxItems: 1
> +
> + interrupts:
> + description: IRQ for the MTK SVS controller.
Drop. That's kind of obvious with only 1 interrupt.
> + maxItems: 1
> +
> + clocks:
> + description: Main clock for MTK SVS controller to work.
How many clocks (maxItems)?
> +
> + clock-names:
> + const: main
> +
> + nvmem-cells:
> + maxItems: 2
> + description:
> + Phandle to the calibration data provided by a nvmem device.
Need to define what each entry is.
items:
- description: ...
- description: ...
> +
> + nvmem-cell-names:
> + items:
> + - const: svs-calibration-data
> + - const: t-calibration-data
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - nvmem-cells
> + - nvmem-cell-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/mt8183-clk.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + svs@1100b000 {
> + compatible = "mediatek,mt8183-svs";
> + reg = <0 0x1100b000 0 0x1000>;
> + interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&infracfg CLK_INFRA_THERM>;
> + clock-names = "main";
> + nvmem-cells = <&svs_calibration>, <&thermal_calibration>;
> + nvmem-cell-names = "svs-calibration-data", "t-calibration-data";
> + };
> + };
> --
> 2.18.0
>
next prev parent reply other threads:[~2021-01-12 14:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 2:43 [PATCH v11 0/7] soc: mediatek: SVS: introduce MTK SVS Roger Lu
2021-01-07 2:43 ` [PATCH v11 1/7] dt-bindings: soc: mediatek: add mtk svs dt-bindings Roger Lu
2021-01-12 14:47 ` Rob Herring [this message]
2021-01-15 13:46 ` Nishanth Menon
2021-01-07 2:43 ` [PATCH v11 2/7] arm64: dts: mt8183: add svs device information Roger Lu
2021-01-07 2:43 ` [PATCH v11 3/7] soc: mediatek: SVS: introduce MTK SVS engine Roger Lu
2021-01-07 2:43 ` [PATCH v11 4/7] soc: mediatek: SVS: add debug commands Roger Lu
2021-01-07 2:43 ` [PATCH v11 5/7] dt-bindings: soc: mediatek: add mt8192 svs dt-bindings Roger Lu
2021-01-12 14:48 ` Rob Herring
2021-01-07 2:43 ` [PATCH v11 6/7] arm64: dts: mt8192: add svs device information Roger Lu
2021-01-07 2:43 ` [PATCH v11 7/7] soc: mediatek: SVS: add mt8192 SVS GPU driver Roger Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112144727.GA321805@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Angus.Lin@mediatek.com \
--cc=Charles.Yang@mediatek.com \
--cc=HenryC.Chen@mediatek.com \
--cc=Xiaoqing.Liu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@google.com \
--cc=eballetbo@gmail.com \
--cc=fan.chen@mediatek.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=nm@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=roger.lu@mediatek.com \
--cc=sboyd@kernel.org \
--cc=yt.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).