From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E186BC433E6 for ; Tue, 12 Jan 2021 22:49:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3C912312F for ; Tue, 12 Jan 2021 22:49:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394783AbhALWt0 (ORCPT ); Tue, 12 Jan 2021 17:49:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:34266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732390AbhALWtZ (ORCPT ); Tue, 12 Jan 2021 17:49:25 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C2A5823122; Tue, 12 Jan 2021 22:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610491724; bh=fWxXcxqHEI+KsLZg+QH/ku9lOvit7R1hyoKrLJ/10dI=; h=From:To:Cc:Subject:Date:From; b=B1c8aG435fUbuC1xPq3IcCLLYNeEtR6V71UVoKA0CRGj6sk4ilrfp7b0fcCebrM6X WU3CR8kyi/yFTWvYk4NHtAdLQ8tNY24nf970YY8Cnr81uD4FDFic2bhthnkfot3+ko 3wNV5OAccljPV5wcopvGGzHG/Wms3aXdAFpTBW+fRGwTiv6NWhQlnAV3gSJD31lHz2 VjYFGj/z/3GvIWjbUP7QodBBU1rlhiKV1/rKIldqFoUyo3xsTmfai3rdguqPDDaieB IYQZW+W6JTRl6/9YKKiZfV5OonxmEcbo/E4em1hpOVX7mBukuiQJo5i1u0qEfdp4TD FYZBdsB/G/GDA== From: Will Deacon To: linux-arm-kernel@lists.infradead.org Cc: kernel-team@android.com, linux-kernel@vger.kernel.org, Will Deacon , Theodore Ts'o , Catalin Marinas , Florian Weimer , Peter Zijlstra , Linus Torvalds , Nick Desaulniers , Russell King , Arnd Bergmann Subject: [PATCH] compiler.h: Raise minimum version of GCC to 5.1 for arm64 Date: Tue, 12 Jan 2021 22:48:32 +0000 Message-Id: <20210112224832.10980-1-will@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org GCC versions >= 4.9 and < 5.1 have been shown to emit memory references beyond the stack pointer, resulting in memory corruption if an interrupt is taken after the stack pointer has been adjusted but before the reference has been executed. This leads to subtle, infrequent data corruption such as the EXT4 problems reported by Russell King at the link below. Life is too short for buggy compilers, so raise the minimum GCC version required by arm64 to 5.1. Cc: Theodore Ts'o Cc: Catalin Marinas Cc: Florian Weimer Cc: Peter Zijlstra Cc: Linus Torvalds Cc: Nick Desaulniers Reported-by: Russell King Suggested-by: Arnd Bergmann Link: https://lore.kernel.org/r/20210105154726.GD1551@shell.armlinux.org.uk Signed-off-by: Will Deacon --- include/linux/compiler-gcc.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index 74c6c0486eed..555ab0fddbef 100644 --- a/include/linux/compiler-gcc.h +++ b/include/linux/compiler-gcc.h @@ -13,6 +13,12 @@ /* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ #if GCC_VERSION < 40900 # error Sorry, your version of GCC is too old - please use 4.9 or newer. +#elif defined(CONFIG_ARM64) && GCC_VERSION < 50100 +/* + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk + */ +# error Sorry, your version of GCC is too old - please use 5.1 or newer. #endif /* -- 2.30.0.284.gd98b1dd5eaa7-goog