From: Rob Herring <robh@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
konrad.dybcio@somainline.org, marijn.suijten@somainline.org,
martin.botka@somainline.org, phone-devel@vger.kernel.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: pinctrl: Add bindings for Awinic AW9523/AW9523B
Date: Tue, 12 Jan 2021 20:41:18 -0600 [thread overview]
Message-ID: <20210113024118.GA1404906@robh.at.kernel.org> (raw)
In-Reply-To: <20210111182928.587285-2-angelogioacchino.delregno@somainline.org>
On Mon, Jan 11, 2021 at 07:29:28PM +0100, AngeloGioacchino Del Regno wrote:
> Add bindings for the Awinic AW9523/AW9523B I2C GPIO Expander driver.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> ---
> .../pinctrl/awinic,aw9523-pinctrl.yaml | 112 ++++++++++++++++++
> 1 file changed, 112 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml
> new file mode 100644
> index 000000000000..a705c05bb5a2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml
> @@ -0,0 +1,112 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/awinic,aw9523-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Awinic AW9523/AW9523B I2C GPIO Expander
> +
> +maintainers:
> + - AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> +
> +description: |
> + The Awinic AW9523/AW9523B I2C GPIO Expander featuring 16 multi-function
> + I/O, 256 steps PWM mode and interrupt support.
> +
> +properties:
> + compatible:
> + const: awinic,aw9523-pinctrl
> +
> + reg:
> + maxItems: 1
> +
> + '#gpio-cells':
> + description: |
> + Specifying the pin number and flags, as defined in
> + include/dt-bindings/gpio/gpio.h
> + const: 2
> +
> + gpio-controller: true
> +
> + gpio-ranges:
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + interrupts:
> + maxItems: 1
> + description: Specifies the INTN pin IRQ.
> +
> + '#interrupt-cells':
> + description:
> + Specifies the PIN numbers and Flags, as defined in defined in
> + include/dt-bindings/interrupt-controller/irq.h
> + const: 2
> +
> +#PIN CONFIGURATION NODES
> +patternProperties:
> + '^.*$':
> + if:
> + type: object
> + $ref: "/schemas/pinctrl/pincfg-node.yaml"
> + then:
I wish people would stop copying this if/then hack...
For new bindings, just name your nodes something sensible you can match
on like '-pins$'.
> + properties:
> + pins:
> + description:
> + List of gpio pins affected by the properties specified in
> + this subnode.
> + items:
> + pattern: "^gpio([0-9]|1[0-5])$"
> + minItems: 1
> + maxItems: 16
> +
> + function:
> + description:
> + Specify the alternative function to be configured for the
> + specified pins.
> +
> + enum: [ gpio, pwm ]
> +
> + bias-disable: true
> + bias-pull-down: true
> + bias-pull-up: true
> + drive-open-drain: true
> + drive-push-pull: true
> + input-enable: true
> + output-high: true
> + output-low: true
> +
> + required:
> + - pins
> + - function
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - gpio-controller
> + - '#gpio-cells'
> + - gpio-ranges
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c_node {
> + gpio-expander@58 {
> + compatible = "awinic,aw9523-pinctrl";
> + reg = <0x58>;
> + interrupt-parent = <&tlmm>;
> + interrupts = <50 IRQ_TYPE_EDGE_FALLING>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&tlmm 0 0 16>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + reset-gpios = <&tlmm 51 GPIO_ACTIVE_HIGH>;
> + };
> + };
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-01-13 2:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 18:29 [PATCH v2 1/2] pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander AngeloGioacchino Del Regno
2021-01-11 18:29 ` [PATCH v2 2/2] dt-bindings: pinctrl: Add bindings for Awinic AW9523/AW9523B AngeloGioacchino Del Regno
2021-01-12 21:52 ` Rob Herring
2021-01-13 2:41 ` Rob Herring [this message]
2021-01-13 12:30 ` AngeloGioacchino Del Regno
2021-01-14 22:42 ` Rob Herring
2021-01-18 13:19 ` [PATCH v2 1/2] pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander Linus Walleij
2021-01-18 14:38 ` AngeloGioacchino Del Regno
2021-01-22 9:59 ` Linus Walleij
2021-01-22 23:39 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113024118.GA1404906@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).