From: Rob Herring <robh@kernel.org>
To: Alex Elder <elder@linaro.org>
Cc: davem@davemloft.net, kuba@kernel.org, evgreen@chromium.org,
bjorn.andersson@linaro.org, cpratapa@codeaurora.org,
subashab@codeaurora.org, rdunlap@infradead.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/4] dt-bindings: net: remove modem-remoteproc property
Date: Tue, 12 Jan 2021 20:41:51 -0600 [thread overview]
Message-ID: <20210113024151.GA1408606@robh.at.kernel.org> (raw)
In-Reply-To: <20210112192831.686-3-elder@linaro.org>
On Tue, Jan 12, 2021 at 01:28:29PM -0600, Alex Elder wrote:
> The IPA driver uses the remoteproc SSR notifier now, rather than the
> temporary IPA notification system used initially. As a result it no
> longer needs a property identifying the modem subsystem DT node.
>
> Use GIC_SPI rather than 0 in the example interrupt definition.
>
> Signed-off-by: Alex Elder <elder@linaro.org>
> ---
> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index 8a2d12644675b..a8cff214ee11f 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -113,13 +113,6 @@ properties:
> performing early IPA initialization, including loading and
> validating firwmare used by the GSI.
>
> - modem-remoteproc:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description:
> - This defines the phandle to the remoteproc node representing
> - the modem subsystem. This is requied so the IPA driver can
> - receive and act on notifications of modem up/down events.
> -
> memory-region:
> maxItems: 1
> description:
> @@ -135,7 +128,6 @@ required:
> - interrupts
> - interconnects
> - qcom,smem-states
> - - modem-remoteproc
>
> oneOf:
> - required:
> @@ -168,7 +160,6 @@ examples:
> compatible = "qcom,sdm845-ipa";
>
> modem-init;
> - modem-remoteproc = <&mss_pil>;
>
> iommus = <&apps_smmu 0x720 0x3>;
> reg = <0x1e40000 0x7000>,
> @@ -178,8 +169,8 @@ examples:
> "ipa-shared",
> "gsi";
>
> - interrupts-extended = <&intc 0 311 IRQ_TYPE_EDGE_RISING>,
> - <&intc 0 432 IRQ_TYPE_LEVEL_HIGH>,
> + interrupts-extended = <&intc GIC_SPI 311 IRQ_TYPE_EDGE_RISING>,
> + <&intc GIC_SPI 432 IRQ_TYPE_LEVEL_HIGH>,
You need the include file.
> <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
> <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>;
> interrupt-names = "ipa",
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-01-13 2:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 19:28 [PATCH net-next 0/4] net: ipa: remove a build dependency Alex Elder
2021-01-12 19:28 ` [PATCH net-next 1/4] net: ipa: remove a remoteproc dependency Alex Elder
2021-01-12 19:28 ` [PATCH net-next 2/4] dt-bindings: net: remove modem-remoteproc property Alex Elder
2021-01-13 2:35 ` Rob Herring
2021-01-13 2:41 ` Rob Herring [this message]
2021-01-12 19:28 ` [PATCH net-next 3/4] arm64: dts: qcom: sc7180: kill IPA " Alex Elder
2021-01-12 19:28 ` [PATCH net-next 4/4] arm64: dts: qcom: sdm845: " Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113024151.GA1408606@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=elder@linaro.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).