From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89221C433DB for ; Wed, 13 Jan 2021 04:56:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DC3A23133 for ; Wed, 13 Jan 2021 04:56:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbhAME40 (ORCPT ); Tue, 12 Jan 2021 23:56:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726202AbhAME4Y (ORCPT ); Tue, 12 Jan 2021 23:56:24 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA577C061575 for ; Tue, 12 Jan 2021 20:55:43 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id b3so498921pft.3 for ; Tue, 12 Jan 2021 20:55:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mJKCusvpWtBfKn+y4mKbIiTTyEFF53qpNFGSZqmXVHU=; b=AYTgJ9tRKgK3HRW4hrmMHj7DhGnGUEPMNrO18Lx+slvosqt5RDGqMOsTVNyNUVVTCo v1pZVH7seXJuz8HaKjdXfJ0lu1ZsmXbEMoDxpSZ/JSrF1Xw0EeiP9M0EEIScTOoKzJG5 woivZntD0iYcGQ8Gid/i9jTxPu3iGVOMIjqIaSd367us82Nkt/bHZYjrWdKudDQ2CX3V kaZyFOPTicOcFAZ5XTx/WGX9MV5XaLfCJOwcxELeXwitDZPj0xChg15Q6vTR5IiJbeZ9 YmoVMSLr+9m8EffMMzXJpT45GB4+QFPV1tXCSQGpCMDVnwlSKbsKzgXmkYu5caRB+gbe oGZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mJKCusvpWtBfKn+y4mKbIiTTyEFF53qpNFGSZqmXVHU=; b=YGj6L878qpDUauBVicj0K+bgIyYem6yWdox8YDQ4632y0Zmmw3m5jKvAyPct/yvfL3 kcqDVPJztm6qaNCqeM2wwAaxhcvNijHzb67c8hsvbHlYU6CcxZLrdr9i7wasdS1TfRhc TXBBPtPuKubKIb/TpGCvrdJH9v1+wxYjrXsoMyYWUySdcGaWFlJISGF2sf04+JekyJM8 3lcdUkaYSnSv5DXcztGLPNKYQPNZbqcArWpyoo/C++TyWyZ+F6wYDjzyYAcwFAhFtV9b TT98vbBNpGzeM8rMvrLTUreAE7TrTej20DMiH3o5TsmmHVGtJy+nm9P7Y63Z4K/FY9ex TdPg== X-Gm-Message-State: AOAM530uVtW4AcnkQChMIo+lDwctbgWlySR/d3tyDGYgTFu6khe5a/Fo /5QPEelu1uikQt9raaMvrY/m9w== X-Google-Smtp-Source: ABdhPJwTqmk4iglhe8G2D21L3QujLbLeXjPAv+epZYprG0ZGWLUyfbPvPghFsk9qSH1TBXR8r1PVFg== X-Received: by 2002:a63:e246:: with SMTP id y6mr383697pgj.412.1610513743224; Tue, 12 Jan 2021 20:55:43 -0800 (PST) Received: from localhost ([122.172.85.111]) by smtp.gmail.com with ESMTPSA id a198sm820054pfa.7.2021.01.12.20.55.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jan 2021 20:55:42 -0800 (PST) Date: Wed, 13 Jan 2021 10:25:40 +0530 From: Viresh Kumar To: Frank Rowand Cc: Pantelis Antoniou , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Vincent Guittot , Bill Mills , anmar.oueja@linaro.org, Masahiro Yamada Subject: Re: [PATCH V3 2/2] scripts: dtc: Build fdtoverlay and fdtdump tools Message-ID: <20210113045540.s2hg2dxldsyelzkd@vireshk-i7> References: <72c3a4f63dde3c172c11153e9a5b19fb6cdb4498.1610000585.git.viresh.kumar@linaro.org> <1d9369aa-b7aa-6d06-0d44-6ef21bc639e3@gmail.com> <20210112050818.s6ctvd6ihd2dt2d2@vireshk-i7> <3f0c733a-641f-290f-41b8-62ca22e355b7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f0c733a-641f-290f-41b8-62ca22e355b7@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12-01-21, 12:34, Frank Rowand wrote: > On 1/11/21 11:08 PM, Viresh Kumar wrote: > > On 11-01-21, 18:44, Frank Rowand wrote: > >> On 1/7/21 12:25 AM, Viresh Kumar wrote: > >>> We will start building overlays for platforms soon in the kernel and > >>> would need these tools going forward. Lets start building them. > >>> > >>> The fdtoverlay program applies (or merges) one ore more overlay dtb > >>> blobs to a base dtb blob. The kernel build system would later use > >>> fdtoverlay to generate the overlaid blobs based on platform specific > >>> configurations. > >>> > >>> The fdtdump program prints a readable version of a flat device-tree > >>> file. This is a very useful tool to analyze the details of the overlay's > >>> dtb and the final dtb produced by fdtoverlay after applying the > >>> overlay's dtb to a base dtb. > >> > >> You can calso dump an FDT with: > >> > >> dtc -O dts XXX.dtb > >> > >> Is this sufficient for the desired functionality, or is there something > >> additional in fdtdump that is needed? > > > > comment 1: > > > Not for my usecase at least. I answered this question here (and yes I could have been more clear): "is there something additional in fdtdump that is needed?" > > > > >> If nothing additional needed, and there is no other justification for adding > >> another program, I would prefer to leave fdtdump out. > > > > comment 2: > > > Okay, then I will also remove the stale version of fdtdump which is > > already there in kernel since a long time. > > > > I'm confused. I read comment 1 as saying that fdtdump does provide a feature > that you need to analyze the dtb created by fdtoverlay. But I read comment 2 > as implying that you are accepting that fdtdump will not be added to the > Linux kernel source. -- viresh