From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16EADC433E0 for ; Wed, 13 Jan 2021 08:04:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE56323120 for ; Wed, 13 Jan 2021 08:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726609AbhAMIEN (ORCPT ); Wed, 13 Jan 2021 03:04:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbhAMIEL (ORCPT ); Wed, 13 Jan 2021 03:04:11 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C131C061786 for ; Wed, 13 Jan 2021 00:03:31 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id 3so699579wmg.4 for ; Wed, 13 Jan 2021 00:03:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=x/0jlx5sSaKGGvb82wT8NsfZQdjIWktlt2hn75IM74U=; b=UOSU3aE4iuyQkGOW+qRrl9/F6PrWS+AL3kvnJ6uiz+kv99SwWb/xGubQERauz2hPwy G3j5vLn3i4ZU1FME8RQHcOH8vsT235Xq5WVVsOUj5H8jQSnawcM+w4sWsDBKgRaBMRRZ wjHmeBk0IP1np7qyCxkcTMJ8so2OLtf+KJ1YVebD6A+Va6GkpO55SqyL9FW0XBidcd7H H/QYGlcEd3L6nFQalTRd3ZwO4cx1uXbENOO4bS4oKG+NcUztO89pQ8z3veYXCDQigzY0 477bwjCXj6xfANnOv9MrPvNQ+3OXFXrJ0ae1lz9MuRdscRW9DgKfuSF8+q1UZEHrSqIQ qwNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=x/0jlx5sSaKGGvb82wT8NsfZQdjIWktlt2hn75IM74U=; b=GuvCmjNkHfUSh0RY7CEoK3KWQYZFNUAePyPaOLwN+nwjJWTZEKv7W53ZIdJrbXtasa qiIADPKfpNABMX+3ZznIpv86VVemZnzxNT4CAj4A1szEMM9iUzcKaIIyS+A2Y7a2/hrL YPwljksU/3vwLZyh+vEqw8+HUl7tRowssxEvGALUKBsu+/SlaqHmLdzQdlmHLN69nu2R 0zE71tsg3OUTqDtmqEx7ISeAhjgR1cKrH5wjWKj/G0N08nnALR2pU1O7V4nEvytCgcMK PUg5pmj+PAUcLAAglJKzGFySmrAItTPgBQ8HJrBcYe80QN0DeGLuwBNMl+6iZ9B78imi NE+A== X-Gm-Message-State: AOAM532B01Ro/izQkRe6dNdkaQP/ZZe0zKrdbQGmoQ2ky5A8C9BbNm55 fFEIZtJX3sNIYcF8KsaYjUOwqA== X-Google-Smtp-Source: ABdhPJxpCDBiFWnjkppzs22ouEjB8n2LOdUBFP8RAquah+kSxU4xDjx22C+43u1cMHh/poxxgAVVpg== X-Received: by 2002:a7b:cb09:: with SMTP id u9mr944114wmj.61.1610525010138; Wed, 13 Jan 2021 00:03:30 -0800 (PST) Received: from dell ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id y68sm1844813wmc.0.2021.01.13.00.03.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 00:03:29 -0800 (PST) Date: Wed, 13 Jan 2021 08:03:27 +0000 From: Lee Jones To: Andreas Kemnade Cc: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Josua Mayer , Arnd Bergmann , Daniel Palmer , Andy Shevchenko Subject: Re: [PATCH v7 3/7] mfd: Add base driver for Netronix embedded controller Message-ID: <20210113080327.GB3975472@dell> References: <20210109180220.121511-1-j.neuschaefer@gmx.net> <20210109180220.121511-4-j.neuschaefer@gmx.net> <20210112203649.67f66996@aktux> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210112203649.67f66996@aktux> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jan 2021, Andreas Kemnade wrote: > On Sat, 9 Jan 2021 19:02:16 +0100 > Jonathan Neuschäfer wrote: > > > The Netronix embedded controller is a microcontroller found in some > > e-book readers designed by the original design manufacturer Netronix, > > Inc. It contains RTC, battery monitoring, system power management, and > > PWM functionality. > > > > This driver implements register access and version detection. > > > > Third-party hardware documentation is available at: > > > > https://github.com/neuschaefer/linux/wiki/Netronix-MSP430-embedded-controller > > > > The EC supports interrupts, but the driver doesn't make use of them so > > far. > > > > Signed-off-by: Jonathan Neuschäfer > > Acked-for-MFD-by: Lee Jones [...] > > +static const struct of_device_id of_ntxec_match_table[] = { > > + { .compatible = "netronix,ntxec", }, > > + {} > > +}; > > + > MODULE_DEVICE_TABLE? > > > +static struct i2c_driver ntxec_driver = { > > + .driver = { > > + .name = "ntxec", > > + .of_match_table = of_ntxec_match_table, > > + }, > > + .probe_new = ntxec_probe, > > + .remove = ntxec_remove, > > +}; > > +module_i2c_driver(ntxec_driver); > > MODULE_LICENSE()? > > modpost moans about that here. Andreas, would you be kind enough to snip/trim your replies in future please. It would save a *lot* of people a little bit of time (which adds up fast). TIA. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog