From: Michal Hocko <mhocko@suse.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org,
n-horiguchi@ah.jp.nec.com, ak@linux.intel.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/6] mm: hugetlb: retry dissolve page when hitting race
Date: Wed, 13 Jan 2021 10:33:31 +0100 [thread overview]
Message-ID: <20210113093331.GV22493@dhcp22.suse.cz> (raw)
In-Reply-To: <20210113052209.75531-5-songmuchun@bytedance.com>
On Wed 13-01-21 13:22:07, Muchun Song wrote:
> There is a race between dissolve_free_huge_page() and put_page().
> Theoretically, we should return -EBUSY when we encounter this race.
> In fact, we have a chance to successfully dissolve the page if we
> do a retry. Because the race window is quite small. If we seize
> this opportunity, it is an optimization for increasing the success
> rate of dissolving page.
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
> mm/hugetlb.c | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 4a9011e12175..898e4ea43e13 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1772,6 +1772,7 @@ int dissolve_free_huge_page(struct page *page)
> {
> int rc = -EBUSY;
>
> +retry:
> /* Not to disrupt normal path by vainly holding hugetlb_lock */
> if (!PageHuge(page))
> return 0;
> @@ -1793,8 +1794,23 @@ int dissolve_free_huge_page(struct page *page)
> * We should make sure that the page is already on the free list
> * when it is dissolved.
> */
> - if (unlikely(!PageHugeFreed(head)))
> - goto out;
> + if (unlikely(!PageHugeFreed(head))) {
> + spin_unlock(&hugetlb_lock);
> +
> + /*
> + * Theoretically, we should return -EBUSY when we
> + * encounter this race. In fact, we have a chance
> + * to successfully dissolve the page if we do a
> + * retry. Because the race window is quite small.
> + * If we seize this opportunity, it is an optimization
> + * for increasing the success rate of dissolving page.
> + */
> + while (PageHeadHuge(head) && !PageHugeFreed(head)) {
> + cond_resched();
> + cpu_relax();
> + }
> + goto retry;
OK, so you have done the retry here. Please fold it into the previous
patch. Also do we need cpu_relax on top of cond_resched as well?
> + }
>
> /*
> * Move PageHWPoison flag from head page to the raw error page,
> --
> 2.11.0
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-01-13 9:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 5:22 [PATCH v4 0/6] Fix some bugs about HugeTLB code Muchun Song
2021-01-13 5:22 ` [PATCH v4 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one Muchun Song
2021-01-13 10:30 ` David Hildenbrand
2021-01-13 10:57 ` Oscar Salvador
2021-01-13 11:03 ` [External] " Muchun Song
2021-01-13 5:22 ` [PATCH v4 2/6] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page Muchun Song
2021-01-13 11:00 ` Oscar Salvador
2021-01-13 5:22 ` [PATCH v4 3/6] mm: hugetlb: fix a race between freeing and dissolving the page Muchun Song
2021-01-13 9:31 ` Michal Hocko
2021-01-13 5:22 ` [PATCH v4 4/6] mm: hugetlb: retry dissolve page when hitting race Muchun Song
2021-01-13 9:33 ` Michal Hocko [this message]
2021-01-13 10:14 ` [External] " Muchun Song
2021-01-13 10:38 ` Michal Hocko
2021-01-13 11:11 ` Muchun Song
2021-01-13 11:14 ` Oscar Salvador
2021-01-13 11:20 ` Muchun Song
2021-01-13 12:03 ` Michal Hocko
2021-01-13 11:22 ` Michal Hocko
2021-01-13 12:15 ` Muchun Song
2021-01-13 5:22 ` [PATCH v4 5/6] mm: hugetlb: fix a race between isolating and freeing page Muchun Song
2021-01-13 5:22 ` [PATCH v4 6/6] mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113093331.GV22493@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).