From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: menglong8.dong@gmail.com
Cc: alexander.sverdlin@nokia.com, paulburton@kernel.org,
gustavo@embeddedor.com, dong.menglong@zte.com.cn,
colin.king@canonical.com, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] MIPS: OCTEON: fix unreachable code in octeon_irq_init_ciu
Date: Wed, 13 Jan 2021 11:07:22 +0100 [thread overview]
Message-ID: <20210113100722.GA10351@alpha.franken.de> (raw)
In-Reply-To: <20210111132725.4513-1-dong.menglong@zte.com.cn>
On Mon, Jan 11, 2021 at 05:27:25AM -0800, menglong8.dong@gmail.com wrote:
> From: Menglong Dong <dong.menglong@zte.com.cn>
>
> The type of 'r' in octeon_irq_init_ciu is 'unsigned int', so 'r < 0'
> can't be true.
>
> Fix this by change the type of 'r' and 'i' from 'unsigned int'
> to 'int'. As 'i' won't be negative, this change works.
>
> Fixes: 99fbc70f8547 ("MIPS: Octeon: irq: Alloc desc before configuring IRQ")
> Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>
> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> ---
> v2:
> - change 'Fixes' from 64b139f97c01 to 99fbc70f8547
> ---
> arch/mips/cavium-octeon/octeon-irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-01-13 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 13:27 [PATCH v2] MIPS: OCTEON: fix unreachable code in octeon_irq_init_ciu menglong8.dong
2021-01-13 10:07 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113100722.GA10351@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=alexander.sverdlin@nokia.com \
--cc=colin.king@canonical.com \
--cc=dong.menglong@zte.com.cn \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=paulburton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).