From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FB68C433E6 for ; Wed, 13 Jan 2021 11:00:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E7BD2333F for ; Wed, 13 Jan 2021 11:00:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727421AbhAMLAd (ORCPT ); Wed, 13 Jan 2021 06:00:33 -0500 Received: from elvis.franken.de ([193.175.24.41]:47814 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726259AbhAMLA2 (ORCPT ); Wed, 13 Jan 2021 06:00:28 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kzdsF-0002Aa-00; Wed, 13 Jan 2021 11:59:35 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id F1ACBC02B1; Wed, 13 Jan 2021 11:59:24 +0100 (CET) Date: Wed, 13 Jan 2021 11:59:24 +0100 From: Thomas Bogendoerfer To: Thomas Gleixner Cc: LKML , Andrew Morton , linux-mm@kvack.org, Peter Zijlstra , Paul Cercueil , Andreas Larsson , "David S. Miller" , sparclinux@vger.kernel.org, Michael Ellerman , linuxppc-dev@lists.ozlabs.org Subject: Re: [patch 3/4] mips/mm/highmem: Use set_pte() for kmap_local() Message-ID: <20210113105924.GA10822@alpha.franken.de> References: <20210112170136.078559026@linutronix.de> <20210112170411.187513575@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210112170411.187513575@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 12, 2021 at 06:01:39PM +0100, Thomas Gleixner wrote: > set_pte_at() on MIPS invokes update_cache() which might recurse into > kmap_local(). Use set_pte() like the original MIPS highmem implementation > did. > > Fixes: a4c33e83bca1 ("mips/mm/highmem: Switch to generic kmap atomic") > Reported-by: Paul Cercueil > Reported-by: Thomas Bogendoerfer > Signed-off-by: Thomas Gleixner > --- > arch/mips/include/asm/highmem.h | 1 + > 1 file changed, 1 insertion(+) Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]