From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D025FC43603 for ; Thu, 14 Jan 2021 01:48:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AACBD2343B for ; Thu, 14 Jan 2021 01:48:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728503AbhANBss (ORCPT ); Wed, 13 Jan 2021 20:48:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729926AbhANAi0 (ORCPT ); Wed, 13 Jan 2021 19:38:26 -0500 Received: from mail-qk1-x74a.google.com (mail-qk1-x74a.google.com [IPv6:2607:f8b0:4864:20::74a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42E75C0617A2 for ; Wed, 13 Jan 2021 16:37:40 -0800 (PST) Received: by mail-qk1-x74a.google.com with SMTP id k126so3028643qkf.8 for ; Wed, 13 Jan 2021 16:37:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=wOBP2RkmQVjfNopz2sDe0MTwMLiCidw7C7eIsxIrYII=; b=d5HallwW2J+DLmealbbzCxFKbyAzfK0TCDbwfh2qMm5YWuuskaf+J+g2Y1HBZE/+36 t95u9GZ2O9AVZxH2zRkVsS7VzsiEpdru7b+em49iDS3EWnmJWFv90DQuBcHChZAf75rO VP02JzsqqznnSDOTDf0eonMszZ3vXgtU2vVaKV34p+gW5Et1K06G5mJhgBwoOaSNBEJl WbKXUOWXGBYjSyCP3bY9d4dFlimPm7F29OLixyGicfnLAl0aReI/0Gvy7tgrK+sDAAFj xIRu74vuI2atJgPvKzfBw2xjPcCGE2+1cuWIipDSZDTCcH9/n/vEm9zso27LK6FEu01I hFEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=wOBP2RkmQVjfNopz2sDe0MTwMLiCidw7C7eIsxIrYII=; b=YlY//u7N7bhW80LLKVK+PwRblRrm/aGwdFJV5fWDtNmB3vRm9bUKoMlJ8MB02xg6/T Kxkqioaj9EJQ8T5ZSVB9ob1aWcP9/c1Rv1Vt7+gR8foHuDPsWLnXzN9c1XBBxK56yp9V bGaAnNl8jVIzXqTHar0a27Elx8AEzOJ+ZpOUe7AbVvMhZ8fqC6vjDP5LlCckZeNcM3+G kIDJnpzCLPBgUGNctg8cFummx+Zs4tO6N0YplyHQ/TXY+MhL70fDkx2FjLGvT4xGpF/j Is3MSxFf+JA1cdP+6Plc+HlViuKbeAzyd/WqVZlComBTJmwK6istAQ5VMqzlKRD/3spP RYrw== X-Gm-Message-State: AOAM531HqJ90sfs3RFUM0DyWAANrnjtBiwS9GGeREjjGSP8l6mEP09Yy RwoUzUeN/94FdnI6DFqSOrA5q7UOT+o= X-Google-Smtp-Source: ABdhPJzroYZoNQxP6r2XJyTfpLb/UvCXqjUCC3lNQ7J4R0aAzyCK6+Qeih/+mF1Mqy1YwLwmgknKdkcu0kk= Sender: "seanjc via sendgmr" X-Received: from seanjc798194.pdx.corp.google.com ([2620:15c:f:10:1ea0:b8ff:fe73:50f5]) (user=seanjc job=sendgmr) by 2002:a05:6214:58d:: with SMTP id bx13mr4647837qvb.61.1610584659417; Wed, 13 Jan 2021 16:37:39 -0800 (PST) Reply-To: Sean Christopherson Date: Wed, 13 Jan 2021 16:36:56 -0800 In-Reply-To: <20210114003708.3798992-1-seanjc@google.com> Message-Id: <20210114003708.3798992-3-seanjc@google.com> Mime-Version: 1.0 References: <20210114003708.3798992-1-seanjc@google.com> X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog Subject: [PATCH v2 02/14] KVM: SVM: Free sev_asid_bitmap during init if SEV setup fails From: Sean Christopherson To: Paolo Bonzini , Dave Hansen , Andy Lutomirski , Peter Zijlstra Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov , Tom Lendacky , Brijesh Singh Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Free sev_asid_bitmap if the reclaim bitmap allocation fails, othwerise KVM will unnecessarily keep the bitmap when SEV is not fully enabled. Freeing the page is also necessary to avoid introducing a bug when a future patch eliminates svm_sev_enabled() in favor of using the global 'sev' flag directly. While sev_hardware_enabled() checks max_sev_asid, which is true even if KVM setup fails, 'sev' will be true if and only if KVM setup fully succeeds. Fixes: 33af3a7ef9e6 ("KVM: SVM: Reduce WBINVD/DF_FLUSH invocations") Cc: Tom Lendacky Signed-off-by: Sean Christopherson --- arch/x86/kvm/svm/sev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index c8ffdbc81709..0eeb6e1b803d 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -1274,8 +1274,10 @@ void __init sev_hardware_setup(void) goto out; sev_reclaim_asid_bitmap = bitmap_zalloc(max_sev_asid, GFP_KERNEL); - if (!sev_reclaim_asid_bitmap) + if (!sev_reclaim_asid_bitmap) { + bitmap_free(sev_asid_bitmap); goto out; + } pr_info("SEV supported: %u ASIDs\n", max_sev_asid - min_sev_asid + 1); sev_supported = true; -- 2.30.0.284.gd98b1dd5eaa7-goog