From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Peter Osterlund <petero2@telia.com>,
Stefan Gmeiner <riddlebox@freesurf.ch>,
"C. Scott Ananian" <cananian@alumni.priceton.edu>,
Bruce Kalk <kall@compass.com>,
this to <linux-input@vger.kernel.org>
Subject: [PATCH 1/5] input: mouse: synaptics: Replace NOOP with suitable commentary
Date: Thu, 14 Jan 2021 15:23:19 +0000 [thread overview]
Message-ID: <20210114152323.2382283-2-lee.jones@linaro.org> (raw)
In-Reply-To: <20210114152323.2382283-1-lee.jones@linaro.org>
Fixes the following W=1 kernel build warning(s):
drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Peter Osterlund <petero2@telia.com>
Cc: Stefan Gmeiner <riddlebox@freesurf.ch>
Cc: "C. Scott Ananian" <cananian@alumni.priceton.edu>
Cc: Bruce Kalk <kall@compass.com>
Cc: this to <linux-input@vger.kernel.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/mouse/synaptics.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 8fb7b4385ded9..3cc8b76629fa2 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -1106,8 +1106,11 @@ static void synaptics_process_packet(struct psmouse *psmouse)
num_fingers = hw.w + 2;
break;
case 2:
- if (SYN_MODEL_PEN(info->model_id))
- ; /* Nothing, treat a pen as a single finger */
+ /*
+ * Keep defaults
+ *
+ * SYN_MODEL_PEN: Treat pens as a single finger
+ */
break;
case 4 ... 15:
if (SYN_CAP_PALMDETECT(info->capabilities))
--
2.25.1
next prev parent reply other threads:[~2021-01-14 15:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 15:23 [PATCH v3 0/5] (Set 2/2) Rid W=1 issues from Input Lee Jones
2021-01-14 15:23 ` Lee Jones [this message]
2021-01-14 15:23 ` [PATCH 2/5] input: touchscreen: melfas_mip4: Mark a bunch of variables as __always_unused Lee Jones
2021-01-20 2:18 ` Dmitry Torokhov
2021-01-14 15:23 ` [PATCH 3/5] input: touchscreen: usbtouchscreen: Actually check return value of usb_submit_urb() Lee Jones
2021-01-20 2:21 ` Dmitry Torokhov
2021-01-14 15:23 ` [PATCH 4/5] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp' Lee Jones
2021-01-14 16:04 ` Benjamin Tissoires
2021-01-20 2:23 ` Dmitry Torokhov
2021-01-14 15:23 ` [PATCH 5/5] input: touchscreen: stmpe-ts: Add description for 'prop' struct member Lee Jones
2021-01-20 2:23 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114152323.2382283-2-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=cananian@alumni.priceton.edu \
--cc=dmitry.torokhov@gmail.com \
--cc=kall@compass.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
--cc=riddlebox@freesurf.ch \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).