From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00A47C433DB for ; Fri, 15 Jan 2021 17:10:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C91802333E for ; Fri, 15 Jan 2021 17:10:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732286AbhAORKF (ORCPT ); Fri, 15 Jan 2021 12:10:05 -0500 Received: from m43-15.mailgun.net ([69.72.43.15]:61744 "EHLO m43-15.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732153AbhAORKD (ORCPT ); Fri, 15 Jan 2021 12:10:03 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1610730582; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=aiKLgWl9D/qmUkm2ChFG0sCHujSYfskh5yLKLQlSwFY=; b=j9JPfPcMTUHe5kP5D8xMWKgp5k84N5757ZmP8zfuS9yqr3r2D2B5+t3m/8123HnuaeR+BRjm dzZQYljKtDqo73CnDgKLHxpBb7fsoMK4GL8sr8+o6U+5icisBOle/xSOz3QuHOhiL+XUtDBj RgICt+gzCDfm0JY/l19NwB+xowk= X-Mailgun-Sending-Ip: 69.72.43.15 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 6001cc37859d74370ddbd08f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 15 Jan 2021 17:09:11 GMT Sender: jackp=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4965FC43468; Fri, 15 Jan 2021 17:09:10 +0000 (UTC) Received: from jackp-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jackp) by smtp.codeaurora.org (Postfix) with ESMTPSA id 590D7C43464; Fri, 15 Jan 2021 17:09:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 590D7C43464 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=jackp@codeaurora.org Date: Fri, 15 Jan 2021 09:09:06 -0800 From: Jack Pham To: Vinod Koul Cc: Konrad Dybcio , Kishon Vijay Abraham I , Bjorn Andersson , Andy Gross , Rob Herring , Wesley Cheng , Greg Kroah-Hartman , Manu Gautam , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/4] phy: qcom-qmp: Add SM8350 USB QMP PHYs Message-ID: <20210115170906.GB5063@jackp-linux.qualcomm.com> References: <20210115104047.3460-1-jackp@codeaurora.org> <20210115104047.3460-2-jackp@codeaurora.org> <2c5481fe-f5be-5d6a-f62f-c93d04b9210e@somainline.org> <20210115124736.GF2771@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210115124736.GF2771@vkoul-mobl> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vinod, On Fri, Jan 15, 2021 at 06:17:36PM +0530, Vinod Koul wrote: > On 15-01-21, 12:54, Konrad Dybcio wrote: > > I might be wrong but it looks as if you forgot to add a compatible > > for the "sm8350_usb3_uniphy_cfg" configuration. I believe Konrad was referring to the driver in which I had neglected to add the compatible to the qcom_qmp_phy_of_match_table. My mistake. > It seems to be documented in patch 2, ideally we should have the > bindings patches first and this as patch 3... Ok. I think driver change would be patch 2 rather, with the bindings in patch 1? Patch 3 and 4 are dt-bindings updates to the SNPS Femto PHY and DWC3 QCOM docs respectively. Will send v2, thanks. Jack -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project