From: Shawn Guo <shawnguo@kernel.org>
To: Max Krummenacher <max.oss.09@gmail.com>
Cc: Max Krummenacher <max.krummenacher@toradex.com>,
Lucas Stach <l.stach@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@gmail.com>,
Rouven Czerwinski <r.czerwinski@pengutronix.de>,
linux-kernel@vger.kernel.org,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Russell King <linux@armlinux.org.uk>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH 1/1] ARM: imx: build suspend-imx6.S with arm instruction set
Date: Mon, 18 Jan 2021 14:45:13 +0800 [thread overview]
Message-ID: <20210118064512.GK28365@dragon> (raw)
In-Reply-To: <20210111151704.26296-2-max.krummenacher@toradex.com>
On Mon, Jan 11, 2021 at 04:17:04PM +0100, Max Krummenacher wrote:
> When the kernel is configured to use the Thumb-2 instruction set
> "suspend-to-memory" fails to resume. Observed on a Colibri iMX6ULL
> (i.MX 6ULL) and Apalis iMX6 (i.MX 6Q).
>
> It looks like the CPU resumes unconditionally in ARM instruction mode
> and then chokes on the presented Thumb-2 code it should execute.
>
> Fix this by using the arm instruction set for all code in
> suspend-imx6.S.
>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
Applied, thanks.
prev parent reply other threads:[~2021-01-18 6:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 15:17 [PATCH 0/1] ARM: imx: build suspend-imx6.S with arm instruction set Max Krummenacher
2021-01-11 15:17 ` [PATCH 1/1] " Max Krummenacher
2021-01-11 17:38 ` Oleksandr Suvorov
2021-01-11 17:49 ` Ahmad Fatoum
2021-01-11 18:30 ` Max Krummenacher
2021-01-18 6:45 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118064512.GK28365@dragon \
--to=shawnguo@kernel.org \
--cc=a.fatoum@pengutronix.de \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=max.krummenacher@toradex.com \
--cc=max.oss.09@gmail.com \
--cc=r.czerwinski@pengutronix.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).