From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F243C4332B for ; Mon, 18 Jan 2021 09:25:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16D7E222B6 for ; Mon, 18 Jan 2021 09:25:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388741AbhARJXp (ORCPT ); Mon, 18 Jan 2021 04:23:45 -0500 Received: from elvis.franken.de ([193.175.24.41]:33126 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388503AbhARJSQ (ORCPT ); Mon, 18 Jan 2021 04:18:16 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1l1Qf1-0004jQ-00; Mon, 18 Jan 2021 10:17:19 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 831F1C0584; Mon, 18 Jan 2021 09:40:02 +0100 (CET) Date: Mon, 18 Jan 2021 09:40:02 +0100 From: Thomas Bogendoerfer To: Souptick Joarder Cc: jiaxun.yang@flygoat.com, yangtiezhu@loongson.cn, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mips: cacheinfo: Remove unnecessary increment of level Message-ID: <20210118084002.GA5637@alpha.franken.de> References: <1610786400-3629-1-git-send-email-jrdr.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1610786400-3629-1-git-send-email-jrdr.linux@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 16, 2021 at 02:10:00PM +0530, Souptick Joarder wrote: > kernel test robot throws below warning -> > > arch/mips/kernel/cacheinfo.c:112:3: warning: Variable 'level' is > modified but its new value is never used. [unreadVariable] > > Remove unnecessary increment of level at the end. > > Reported-by: kernel test robot > Signed-off-by: Souptick Joarder > --- > arch/mips/kernel/cacheinfo.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/mips/kernel/cacheinfo.c b/arch/mips/kernel/cacheinfo.c > index 5f9d0eb..c858ae3 100644 > --- a/arch/mips/kernel/cacheinfo.c > +++ b/arch/mips/kernel/cacheinfo.c > @@ -109,7 +109,6 @@ static int __populate_cache_leaves(unsigned int cpu) > > if (c->tcache.waysize) { > populate_cache(tcache, this_leaf, level, CACHE_TYPE_UNIFIED); > - level++; please remove the no longer needed braces, too. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]