From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-i2c@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 2/3] media: i2c: adv7842: remove open coded version of SMBus block read
Date: Mon, 18 Jan 2021 10:33:54 +0100 [thread overview]
Message-ID: <20210118093354.GD1018@ninjato> (raw)
In-Reply-To: <62c10525-69c6-e681-feaa-5ec3a865c06c@xs4all.nl>
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
Hello Hans,
I hope you are well!
> > The open coded version differs from the one in the core in one way: the
> > buffer will be always copied back, even when the transfer failed. It
> > looks like it is expected that the sanity check for a correct CRC and
> > header will bail out later.
>
> Nah, it's just a bug. It should have returned and checked the error code,
> so your patch does the right thing.
I see. So, I will only update the commit message.
Thanks for the reviews!
All the best,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-18 9:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 16:41 [PATCH RFC 0/3] treewide: remove open coded SMBus block transfers Wolfram Sang
2021-01-12 16:41 ` [PATCH RFC 1/3] media: i2c: adv7842: remove open coded version of SMBus block write Wolfram Sang
2021-01-18 9:24 ` Hans Verkuil
2021-01-18 9:32 ` Wolfram Sang
2021-01-12 16:41 ` [PATCH RFC 2/3] media: i2c: adv7842: remove open coded version of SMBus block read Wolfram Sang
2021-01-12 16:44 ` Wolfram Sang
2021-01-12 19:41 ` Wolfram Sang
2021-01-18 9:22 ` Hans Verkuil
2021-01-18 9:33 ` Wolfram Sang [this message]
2021-01-12 16:41 ` [PATCH RFC 3/3] ipmi: remove open coded version of SMBus block write Wolfram Sang
2021-01-14 0:48 ` Corey Minyard
2021-01-14 14:04 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118093354.GD1018@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).