From: Sasha Levin <sashal@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: masahiroy@kernel.org, michal.lkml@markovi.net,
torvalds@linux-foundation.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] kbuild: give SUBLEVEL more room in KERNEL_VERSION
Date: Mon, 18 Jan 2021 10:31:35 -0500 [thread overview]
Message-ID: <20210118153135.GA4035784@sasha-vm> (raw)
In-Reply-To: <YAWSgjWHCcJt6m0j@kroah.com>
On Mon, Jan 18, 2021 at 02:52:02PM +0100, Greg KH wrote:
>On Mon, Jan 18, 2021 at 08:39:59AM -0500, Sasha Levin wrote:
>> I think it would also affect code that doesn't do things based on
>> SBULEVEL. Consider something like:
>>
>> if (LINUX_VERSION_CODE < KERNEL_VERSION(4,5,0))
>>
>> Which will cause 4.4.256 to now change the result of that comparison.
>
>Sure, but there are no in-kernel users like this, so my sympathy is
>quite low :)
Wouldn't it be an issue for the hacky in-kernel users too? For example,
right now the USB code does:
#define KERNEL_REL bin2bcd(((LINUX_VERSION_CODE >> 16) & 0x0ff))
#define KERNEL_VER bin2bcd(((LINUX_VERSION_CODE >> 8) & 0x0ff))
After 4.4.256, KERNEL_VER will be (5) rather than (4), indicating a
version of 4.5.
--
Thanks,
Sasha
next prev parent reply other threads:[~2021-01-18 15:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 1:49 [PATCH] kbuild: give SUBLEVEL more room in KERNEL_VERSION Sasha Levin
2021-01-18 9:21 ` Greg KH
2021-01-18 9:24 ` Greg KH
2021-01-18 13:39 ` Sasha Levin
2021-01-18 13:52 ` Greg KH
2021-01-18 15:31 ` Sasha Levin [this message]
2021-01-18 16:39 ` Greg KH
2021-01-18 10:27 ` Masahiro Yamada
2021-01-18 10:32 ` Greg KH
2021-01-18 22:54 ` David Laight
2021-01-18 13:38 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118153135.GA4035784@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).