From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58089C433E6 for ; Tue, 19 Jan 2021 10:26:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B35D2312E for ; Tue, 19 Jan 2021 10:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389896AbhASKSW (ORCPT ); Tue, 19 Jan 2021 05:18:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730765AbhASJ4D (ORCPT ); Tue, 19 Jan 2021 04:56:03 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC91BC061573 for ; Tue, 19 Jan 2021 01:55:14 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id y8so10202875plp.8 for ; Tue, 19 Jan 2021 01:55:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xAqXt2hrMnUwGHY4K/vXVEtDT5xO+PqICWyHvp6jNI4=; b=yLyMj40c8dpxG49080WIa+e1h0pdwJbbPb6WrmW/NlllBflJkMeezxlqx/j4D5Eu+f UVjn8MO4sm0KngRQxbChnQghGE8x7cuFzzgtIWVDa4mwXm+TnRc3LgZNKRDKwjDIWqk/ xd1U0afI3Wfh4S7IEVlwnL6i/FE6p/oj8XtHRhcJDpvC45IRYws7FU6ZBKyBFqPyed4U MoieLszFLBCu2JWPzofsc8lwyRT7UFSDBPMDaoTmg4iGU+VoBu3jjofvFwH1C2en01Mf UePfcVcZW4+RGC2J74FvKjBsbvFQ0mWIWrfMWdyEpT6tW6pjxGN2/N1X2RjaVTPIu+SA 92aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xAqXt2hrMnUwGHY4K/vXVEtDT5xO+PqICWyHvp6jNI4=; b=IlGHyrUDogLDpyhanT+5nlV/5jFTwXW0rCbRxFMpnucSkX5TP0HRzXQN39H4sZEocc 1tLT5/RM7O7aPsfXkTZIera9nhA6KZ12nOoGmf602hZ7hTInYbEXhrueZ3nsEVM/adPt 4NOC0IFHwl2SsJLLxstgdWRJn2rR9d2J+QMccBBTCu2mSuWbsBYn0XUEAY7zE5kSWrde DtqdZ9I7/BHwAJlBQAcAhzlr2Yo8ziMp3cCBbMJnGtOrldqOQse87Qr4T1KOrD13VkRl KoHobg6YF/uJi54ifs0nVmk111TBShwW051k/lq6bHUz4Eo7JNeTyIKI4ZLb8hC1I6fS Ixbw== X-Gm-Message-State: AOAM530auYc8ACFVXbInGb/ew8kPjBDiWCW9N5lujhfeFW6MStp76efk McDCpzZjW3dZRX8tijhXdzkQVg== X-Google-Smtp-Source: ABdhPJzzA9SrNQFl+F6LdDy36vNrtNXWt6cwOvgIfknJpkBo8QX65rmWDW606+FJKruuIfh0mqyekA== X-Received: by 2002:a17:90a:fa84:: with SMTP id cu4mr4536724pjb.0.1611050114175; Tue, 19 Jan 2021 01:55:14 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id q9sm18869325pgb.82.2021.01.19.01.55.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jan 2021 01:55:13 -0800 (PST) Date: Tue, 19 Jan 2021 15:25:11 +0530 From: Viresh Kumar To: Ulf Hansson Cc: Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Peter Geis , Nicolas Chauvet , "Rafael J. Wysocki" , Kevin Hilman , Peter De Schrijver , Viresh Kumar , Stephen Boyd , Greg Kroah-Hartman , Matt Merhar , Linux Kernel Mailing List , linux-tegra , Linux PM Subject: Re: [PATCH v3 1/3] PM: domains: Make set_performance_state() callback optional Message-ID: <20210119095511.s3xntwwq4g65dcoa@vireshk-i7> References: <20210118011330.4145-1-digetx@gmail.com> <20210118011330.4145-2-digetx@gmail.com> <20210118072855.anncyl6z3e5uznvd@vireshk-i7> <20210118110506.linvsoca7jbl42iq@vireshk-i7> <20210119034428.qgjjlvti6sirsnzy@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19-01-21, 10:52, Ulf Hansson wrote: > That would work if the topology is built from top to bottom, but I > don't think we can rely on that. > > For example, when a domain A is added as a child to domain B, domain B > doesn't have a parent yet (and the "can-handle-pstates" don't get set > for neither domain A or domain B). Next, domain B is added as child > domain to domain C. Domain C has the "can-handle-pstates" set, which > means domain B gets the "can-handle-pstates" set as well. This means > domain A, will not have "can-handle-pstates" set, while it probably > should have. Okay, I missed that part. > > > > > So, maybe we should simply just stick to the existing code, forcing > > > the parent to have a ->set_performance() callback assigned if > > > propagation should continue? > > > > I think it would be better to fix the issue even if we aren't fully optimized > > and making the change to make sure we keep propagating is rather important. > > Alright, let's continue with Dmitry's patches and discuss this further > when v4 is out, as he seems to have it almost ready. Right. -- viresh