From: Mark Brown <broonie@kernel.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mayulong <mayulong1@huawei.com>, Rob Herring <robh+dt@kernel.org>,
devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 15/18] mfd: hi6421-spmi-pmic: move driver from staging
Date: Tue, 19 Jan 2021 13:46:22 +0000 [thread overview]
Message-ID: <20210119134622.GB4478@sirena.org.uk> (raw)
In-Reply-To: <aa17f0fee8cfcd654e107897d350cb3b0438763b.1611048785.git.mchehab+huawei@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
On Tue, Jan 19, 2021 at 11:14:20AM +0100, Mauro Carvalho Chehab wrote:
> +int hi6421_spmi_pmic_read(struct hi6421_spmi_pmic *pmic, int reg)
> +{
> + struct spmi_device *pdev;
> + u8 read_value = 0;
> + u32 ret;
> +
> + pdev = to_spmi_device(pmic->dev);
> + if (!pdev) {
> + pr_err("%s: pdev get failed!\n", __func__);
> + return -ENODEV;
> + }
> +
> + ret = spmi_ext_register_readl(pdev, reg, &read_value, 1);
> + if (ret) {
> + pr_err("%s: spmi_ext_register_readl failed!\n", __func__);
> + return ret;
> + }
> + return read_value;
> +}
> +EXPORT_SYMBOL(hi6421_spmi_pmic_read);
The I/O here looks a lot like regmap_spmi_ext.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-20 0:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 10:14 [PATCH v3 00/18] Move Hisilicon 6421v600 SPMI driver set out of staging Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 01/18] staging: hikey9xx: hisilicon,hisi-spmi-controller.yaml fix bindings Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 02/18] staging: hikey9xx: hisilicon,hi6421-spmi-pmic.yaml: simplify props Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 03/18] staging: hikey9xx: hisi-spmi-controller: clean sparse warnings Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 04/18] staging: hikey9xx: hi6421v600-regulator: do some cleanups Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 05/18] staging: hikey9xx: hi6421v600-regulator: move LDO config from DT Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 06/18] staging: hikey9xx: hi6421v600-regulator: cleanup debug msgs Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 07/18] staging: hikey9xx: hi6421v600-regulator: get rid of an static data Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 08/18] staging: hikey9xx: hi6421v600-regulator: do some cleanups Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 09/18] staging: hikey9xx: hi6421v600-regulator: update copyright Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 10/18] staging: hikey9xx: hi6421v600-regulator: fix delay logic Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 11/18] staging: hikey9xx: hi6421v600-regulator: cleanup comments Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 12/18] staging: hikey9xx: hi6421v600-regulator: fix get_optimum_mode Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 13/18] staging: hikey9xx: hisilicon,hi6421-spmi-pmic.yaml: cleanup a warning Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 14/18] spmi: hi6421-spmi-pmic: move driver from staging Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 15/18] mfd: " Mauro Carvalho Chehab
2021-01-19 13:46 ` Mark Brown [this message]
2021-01-19 15:50 ` Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 16/18] regulator: hi6421v600-regulator: move it " Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 17/18] dts: hisilicon: add support for USB3 on Hikey 970 Mauro Carvalho Chehab
2021-01-19 10:14 ` [PATCH v3 18/18] dts: hisilicon: add support for the PMIC found " Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119134622.GB4478@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mayulong1@huawei.com \
--cc=mchehab+huawei@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).