From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E13FC433E0 for ; Wed, 20 Jan 2021 01:25:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3018523109 for ; Wed, 20 Jan 2021 01:25:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728141AbhATBZe (ORCPT ); Tue, 19 Jan 2021 20:25:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbhATBYw (ORCPT ); Tue, 19 Jan 2021 20:24:52 -0500 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAE86C061757; Tue, 19 Jan 2021 17:24:11 -0800 (PST) Received: by mail-lj1-x22e.google.com with SMTP id n11so24166160lji.5; Tue, 19 Jan 2021 17:24:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uj7BT9C+f28xNkznwoNGgGBjdluidQQjv9Qul4Tcuu0=; b=cwmxZcEPvwLv/kyqRMBkARFDLnbvaOMuwQ1Ad6KQtMs35OMqAoCEnblKyZ+A/eKgyA N864A//qe/1OnirT+gVqN4ehdhJI+oXEdxjrYJQTTEK82X8pwEhNfKJGPbuU3hJNNyYw VUPX9tFD6CEygMswsa6GzYw0QLuc55Pgo5LJiLdx3col24gaQRyfmJ/gTHyC8SV1xQMN 8yedXesZcL/vdZ9YdJli8BqLtNde1bhecLfDpmJzk/91/d+uEbNKx10ZJLYglDqzLe6C NB8M5g82kJUitIKF4AwsPorUgOV5kjD+nCSTh+rGzcds+O753ZgMpb38xs32TTXucurg GATg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uj7BT9C+f28xNkznwoNGgGBjdluidQQjv9Qul4Tcuu0=; b=K2ZkOj7NPRhj9U9KH3UjYutxGj7wS+fRRE1XhZNxnSdJXMePcjsN5pI0zu4yo+K+PR prT1jOFKBCL3EdyQWBV3Gb+AlB9O0TFjndlyDYtnItynzV64pC+s3/GgEk0ZtWv2qADq 0uPvU6nlT0cEuzTUh5n7dv7v69RwfIZ2imlrZhZR2S913GbYq8d38DdjCXgzGyf3L/vw I7SXX+sZlDj8uwuRB7F8y0HB01X+OtbeOLuhWY4n+3o5m1Tj2qD83QaCNzcRPeqb4agn jMASx5U3kbNUVChi5b1RWafheFr1MDOYED6syrQygAOywfRFiX3iUIuDBCReGEXrdlqG 6s6A== X-Gm-Message-State: AOAM533rZ3/7/vFTShK7MNkOcEvHqLf+douIZ3oPXqSN3HVxPIcyX6n1 bi85+hEHiYsqIFgiiA9t9M4= X-Google-Smtp-Source: ABdhPJw3T0wyb4OJ46VKz6CKlnDUcY6hkqNPg84d5mL9Fge6xXAVcdpa6b1G+0Rwh4H+H0CcHMHQDA== X-Received: by 2002:a2e:58f:: with SMTP id 137mr3174423ljf.469.1611105850276; Tue, 19 Jan 2021 17:24:10 -0800 (PST) Received: from localhost.localdomain (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.gmail.com with ESMTPSA id c8sm28416lja.80.2021.01.19.17.24.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jan 2021 17:24:09 -0800 (PST) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Peter Geis , Nicolas Chauvet , Matt Merhar Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/5] soc/tegra: pmc: Fix imbalanced clock disabling in error code path Date: Wed, 20 Jan 2021 04:23:53 +0300 Message-Id: <20210120012357.11038-2-digetx@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210120012357.11038-1-digetx@gmail.com> References: <20210120012357.11038-1-digetx@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The tegra_powergate_power_up() has a typo in the error code path where it will try to disable clocks twice, fix it. In practice that error never happens, so this is a minor correction. Tested-by: Peter Geis # Ouya T30 Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124 Tested-by: Matt Merhar # Ouya T30 Tested-by: Dmitry Osipenko # A500 T20 and Nexus7 T30 [this patch was also boot-tested on some other T20/30/114 devices] Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/pmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index df9a5ca8c99c..fd2ba3c59178 100644 --- a/drivers/soc/tegra/pmc.c +++ b/drivers/soc/tegra/pmc.c @@ -638,7 +638,7 @@ static int tegra_powergate_power_up(struct tegra_powergate *pg, err = tegra_powergate_enable_clocks(pg); if (err) - goto disable_clks; + goto powergate_off; usleep_range(10, 20); -- 2.29.2