From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7372AC43331 for ; Wed, 20 Jan 2021 16:23:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5112A233E2 for ; Wed, 20 Jan 2021 16:23:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404024AbhATQWr (ORCPT ); Wed, 20 Jan 2021 11:22:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:43746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403837AbhATQUs (ORCPT ); Wed, 20 Jan 2021 11:20:48 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9AECB233CE; Wed, 20 Jan 2021 16:20:06 +0000 (UTC) Date: Wed, 20 Jan 2021 11:20:04 -0500 From: Steven Rostedt To: Jianlin Lv Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, Masami Hiramatsu Subject: Re: [PATCH v2] tracing: precise log info for kretprobe addr err Message-ID: <20210120112004.4b9ff1df@gandalf.local.home> In-Reply-To: <20210120155644.64721-1-Jianlin.Lv@arm.com> References: <20210120155644.64721-1-Jianlin.Lv@arm.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org You forgot to include Masami on Cc again. Masami maintains kprobes. Please include him on any updates, as he needs to review them, and give his acknowledgment before acceptance. I need to update MAINTAINERS files to include trace_kprobe under KPROBES. And I also don't see any UPROBES section there. That needs to be done as well. On Wed, 20 Jan 2021 23:56:44 +0800 Jianlin Lv wrote: > When trying to create kretprobe with the wrong function symbol in tracefs; > The error is triggered in the register_trace_kprobe() and recorded as > FAIL_REG_PROBE issue, > > Example: > $ cd /sys/kernel/debug/tracing > $ echo 'r:myprobe ERROR_SYMBOL_XXX ret=%x0' >> kprobe_events > bash: echo: write error: Invalid argument > $ cat error_log > [142797.347877] trace_kprobe: error: Failed to register probe event > Command: r:myprobe ERROR_SYMBOL_XXX ret=%x0 > ^ > > This error can be detected in the parameter parsing stage, the effect of > applying this patch is as follows: > > $ echo 'r:myprobe ERROR_SYMBOL_XXX ret=%x0' >> kprobe_events > bash: echo: write error: Invalid argument > $ cat error_log > [415.89]trace_kprobe: error: Retprobe address must be an function entry > Command: r:myprobe ERROR_SYMBOL_XXX ret=%x0 > ^ > > Signed-off-by: Jianlin Lv > > v2:add !strchr(symbol, ':') to check really bad symbol or not. Also, the "changes since" section should be below the "---" so that they don't get pulled into the commit. Thanks! -- Steve > --- > kernel/trace/trace_kprobe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c > index e6fba1798771..bce63d5ecaec 100644 > --- a/kernel/trace/trace_kprobe.c > +++ b/kernel/trace/trace_kprobe.c > @@ -830,7 +830,7 @@ static int trace_kprobe_create(int argc, const char *argv[]) > flags |= TPARG_FL_RETURN; > if (kprobe_on_func_entry(NULL, symbol, offset)) > flags |= TPARG_FL_FENTRY; > - if (offset && is_return && !(flags & TPARG_FL_FENTRY)) { > + if (!strchr(symbol, ':') && is_return && !(flags & TPARG_FL_FENTRY)) { > trace_probe_log_err(0, BAD_RETPROBE); > goto parse_error; > }