From: Christoph Hellwig <hch@infradead.org>
To: Will McVicker <willmcvicker@google.com>
Cc: Jessica Yu <jeyu@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christoph Hellwig <hch@infradead.org>,
Saravana Kannan <saravanak@google.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH v5] modules: introduce the MODULE_SCMVERSION config
Date: Wed, 20 Jan 2021 14:25:26 +0000 [thread overview]
Message-ID: <20210120142526.GA3759754@infradead.org> (raw)
In-Reply-To: <20210108003035.1930475-1-willmcvicker@google.com>
On Fri, Jan 08, 2021 at 12:30:35AM +0000, Will McVicker wrote:
> For example, we have a CI setup that tests new kernel changes on the
> hikey960 and db845c devices without updating their kernel modules. When
> these tests fail, we need to be able to identify the exact device
> configuration the test was using. By including MODULE_SCMVERSION, we can
> identify the exact kernel and modules' SCM versions for debugging the
> failures.
Sorry, but this still has no business in the upstream kernel as every
change to the kernel is free to just change any API. That is whatever
you test there is a completely unsupported setup.
More importantly the "scmversion" of a module simply does not matter,
as we only support modules from the kernel tree and it thus must be the
kernel version.
be supported.
You are still trying to sneak out of tree module infrastructure in here
with a bad cover story. Please stop doing that.
next prev parent reply other threads:[~2021-01-20 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 0:30 [PATCH v5] modules: introduce the MODULE_SCMVERSION config Will McVicker
2021-01-12 15:54 ` Jessica Yu
2021-01-14 18:20 ` Will McVicker
2021-01-17 15:20 ` Masahiro Yamada
2021-01-19 21:48 ` Will McVicker
2021-01-20 0:18 ` Will McVicker
2021-01-20 19:41 ` Masahiro Yamada
2021-01-20 14:25 ` Christoph Hellwig [this message]
2021-01-20 17:01 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120142526.GA3759754@infradead.org \
--to=hch@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeyu@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=saravanak@google.com \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).