From: kernel test robot <lkp@intel.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>
Cc: kbuild-all@lists.01.org, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/14] rtc: ac100: use rtc_lock/rtc_unlock
Date: Thu, 21 Jan 2021 01:50:38 +0800 [thread overview]
Message-ID: <202101210107.NEOteApJ-lkp@intel.com> (raw)
In-Reply-To: <20210119220653.677750-1-alexandre.belloni@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 2653 bytes --]
Hi Alexandre,
I love your patch! Yet something to improve:
[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on stm32/stm32-next linux/master linus/master v5.11-rc4 next-20210120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alexandre-Belloni/rtc-ac100-use-rtc_lock-rtc_unlock/20210120-172843
base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
config: arm-sunxi_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/b6052366a7328ef9db6ad0d0fc7ea94e542a6f05
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alexandre-Belloni/rtc-ac100-use-rtc_lock-rtc_unlock/20210120-172843
git checkout b6052366a7328ef9db6ad0d0fc7ea94e542a6f05
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/rtc/rtc-ac100.c:21:
drivers/rtc/rtc-ac100.c: In function 'ac100_rtc_irq':
>> include/linux/rtc.h:165:32: error: lvalue required as unary '&' operand
165 | #define rtc_lock(d) mutex_lock(&d->ops_lock)
| ^
drivers/rtc/rtc-ac100.c:531:2: note: in expansion of macro 'rtc_lock'
531 | rtc_lock(&chip->rtc);
| ^~~~~~~~
include/linux/rtc.h:166:36: error: lvalue required as unary '&' operand
166 | #define rtc_unlock(d) mutex_unlock(&d->ops_lock)
| ^
drivers/rtc/rtc-ac100.c:554:2: note: in expansion of macro 'rtc_unlock'
554 | rtc_unlock(&chip->rtc);
| ^~~~~~~~~~
vim +165 include/linux/rtc.h
0c86edc0d4970649 Alessandro Zummo 2006-03-27 164
ae48668843382593 Alexandre Belloni 2019-10-19 @165 #define rtc_lock(d) mutex_lock(&d->ops_lock)
ae48668843382593 Alexandre Belloni 2019-10-19 166 #define rtc_unlock(d) mutex_unlock(&d->ops_lock)
ae48668843382593 Alexandre Belloni 2019-10-19 167
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28836 bytes --]
next prev parent reply other threads:[~2021-01-20 17:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 22:06 [PATCH 01/14] rtc: ac100: use rtc_lock/rtc_unlock Alexandre Belloni
2021-01-19 22:06 ` [PATCH 02/14] rtc: asm9260: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 03/14] rtc: ds1305: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 04/14] rtc: ds1307: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 05/14] rtc: ds1685: " Alexandre Belloni
2021-01-25 3:33 ` Joshua Kinard
2021-01-19 22:06 ` [PATCH 06/14] rtc: ds3232: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 07/14] rtc: hym8563: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 08/14] rtc: m41t80: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 09/14] rtc: mcp795: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 10/14] rtc: pcf2123: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 11/14] rtc: rv3029: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 12/14] rtc: rx8010: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 13/14] rtc: rx8025: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 14/14] rtc: stm32: " Alexandre Belloni
2021-01-20 17:50 ` kernel test robot [this message]
2021-01-25 22:14 ` [PATCH v2] rtc: ac100: " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101210107.NEOteApJ-lkp@intel.com \
--to=lkp@intel.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).