From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E3FC433DB for ; Thu, 21 Jan 2021 11:48:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3959B238E2 for ; Thu, 21 Jan 2021 11:48:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730602AbhAULsA (ORCPT ); Thu, 21 Jan 2021 06:48:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730059AbhAULVU (ORCPT ); Thu, 21 Jan 2021 06:21:20 -0500 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36D58C0617BD for ; Thu, 21 Jan 2021 03:20:03 -0800 (PST) Received: by mail-pf1-x429.google.com with SMTP id o20so1328468pfu.0 for ; Thu, 21 Jan 2021 03:20:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=UlV9SkLktbmadacAKGgdNG9Y2QsM6fa71yNEW4spCec=; b=dV21di/SIMnV6UG3syoEA4dXCTmipisQDkMW2ufldO2KP0jSQItvJ3YkLtmXk/+JhE 7hmZ57fpHjt97X8PR5gXKmU1bgQz8d9clCagTI0XMnZpqP7mbO2Zh9iAagmu72olXVXj CpvgynAYjmFNlOtru+P+SYxpt+iir3lFG9dv6lysvnZP2hLf/APuNd8AjgmKHKz2BNET Q/B3hhhnbz+8xj6PhO4etIkonSNJevSre91l8KyekoUNJ+w0l4BvS0UDAMyBit0BFHnd 2TjKMVh5o1fOz3r3E2jv7XYpty6AqtiuILOhk63BTwf28a0P+EHbNvdsGS3BPWyxJAU3 Rplg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=UlV9SkLktbmadacAKGgdNG9Y2QsM6fa71yNEW4spCec=; b=nobpqxscHtkGJTEMI+mfxH2CQ0hPz+HpM6fyIIe6UJEKqpPvJ54q1LNyuQa0puNDvW ApfiVl8VGGmJZU0TTh99tMKohvAKkxT8Am09mQuIj0DYzTwLMxkbybg/S/SKBK9hDMKi A/tLJGpsktoqL7xzeDPKbdCkQQVPghnnLEt0ufMN9y8h/IRa9cPj5gmPm8VXp+1kvtHe WrneyLhidPMlK3FfcyW6burFL8xcKAmS+oN7TV3Fs1RPl6aCN4NJAnwXft1tjSnKFCku g1Uv7NUibne34laiO8lkOBKuTeDJfG1HiBxh187GMrRNiYOgOIijdLWDt+4DxOoEnzfQ SRTA== X-Gm-Message-State: AOAM531Vwa9POtiHzQ04KahUJ7AWMZlS0sjuyx1I6GtQxDKe9lBq9OKp MnUW/GB9bwXHt6fb5Oh4vlij/Q== X-Google-Smtp-Source: ABdhPJyWSSNOh5sgHtD8hlBg7objnemuBrANhZgMxnAG9UmzBJYI+f5LE6kZ+jLn7AkBm1SA7BUzng== X-Received: by 2002:a63:455c:: with SMTP id u28mr506335pgk.142.1611228002718; Thu, 21 Jan 2021 03:20:02 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id gk2sm5831650pjb.6.2021.01.21.03.20.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jan 2021 03:20:01 -0800 (PST) Date: Thu, 21 Jan 2021 16:50:00 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Mark Brown , Liam Girdwood , Ulf Hansson , Peter Geis , Nicolas Chauvet , "Rafael J. Wysocki" , Kevin Hilman , Peter De Schrijver , Viresh Kumar , Stephen Boyd , Nishanth Menon , Yangtao Li , Matt Merhar , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v3 05/12] opp: Add dev_pm_opp_set_voltage() Message-ID: <20210121112000.rn6uvfsmgy2wyxwh@vireshk-i7> References: <20210118005524.27787-1-digetx@gmail.com> <20210118005524.27787-6-digetx@gmail.com> <20210118095256.tr2qgnrmokkc6ngf@vireshk-i7> <16c7e096-5efd-2d0c-a2ac-c11133c29c30@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <16c7e096-5efd-2d0c-a2ac-c11133c29c30@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21-01-21, 00:57, Dmitry Osipenko wrote: > 18.01.2021 22:14, Dmitry Osipenko пишет: > > Sounds like it could be a lot of code moving and some extra complexity > > will be added to the code. If nobody will ever need the universal > > dev_pm_opp_set_opp(), then it could become a wasted effort. I'd choose > > the easiest path, i.e. to defer the dev_pm_opp_set_opp() implementation > > until somebody will really need it. > > > > But if it looks to you that it won't be a too much effort, then I'll > > appreciate if you could type the patch. Yes. > Let's start with dev_pm_opp_set_voltage() for now. It shouldn't be a > problem at all to upgrade it to dev_pm_opp_set_opp() later on. > > I'll make a v4 with the dev_pm_opp_set_voltage(), please let me know if > you have objections or more suggestions! Sorry about this, I have been working on this stuff for last 2 days. I didn't reply earlier as I thought I would be able to finish this earlier. Once you see the patches you will see it was a significant change :) I have cc'd you to the relevant patches now. Please see if they work fine for you or not. -- viresh