From: Halil Pasic <pasic@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Tony Krowiak <akrowiak@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, stable@vger.kernel.org,
Pierre Morel <pmorel@linux.ibm.com>,
Harald Freudenberger <freude@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
mjrosato@linux.ibm.com, alex.williamson@redhat.com,
kwankhede@nvidia.com, fiuczy@linux.ibm.com,
frankja@linux.ibm.com, david@redhat.com
Subject: Re: [PATCH 1/1] s390/vfio-ap: No need to disable IRQ after queue reset
Date: Thu, 21 Jan 2021 11:34:38 +0100 [thread overview]
Message-ID: <20210121113438.2e40c5f9.pasic@linux.ibm.com> (raw)
In-Reply-To: <20210121092044.628b77c7.cohuck@redhat.com>
On Thu, 21 Jan 2021 09:20:44 +0100
Cornelia Huck <cohuck@redhat.com> wrote:
> On Thu, 21 Jan 2021 08:20:08 +0100
> Halil Pasic <pasic@linux.ibm.com> wrote:
[..]
> > --- a/drivers/s390/crypto/vfio_ap_private.h
> > +++ b/drivers/s390/crypto/vfio_ap_private.h
> > @@ -88,11 +88,6 @@ struct ap_matrix_mdev {
> > struct mdev_device *mdev;
> > };
> >
> > -extern int vfio_ap_mdev_register(void);
> > -extern void vfio_ap_mdev_unregister(void);
> > -int vfio_ap_mdev_reset_queue(unsigned int apid, unsigned int apqi,
> > - unsigned int retry);
> > -
> > struct vfio_ap_queue {
> > struct ap_matrix_mdev *matrix_mdev;
> > unsigned long saved_pfn;
> > @@ -100,5 +95,10 @@ struct vfio_ap_queue {
> > #define VFIO_AP_ISC_INVALID 0xff
> > unsigned char saved_isc;
> > };
> > -struct ap_queue_status vfio_ap_irq_disable(struct vfio_ap_queue *q);
> > +
> > +int vfio_ap_mdev_register(void);
> > +void vfio_ap_mdev_unregister(void);
>
> Nit: was moving these two necessary?
>
No not strictly necessary. I decided that having the data types
first and the function prototypes in one place after the former
is nicer.
> > +int vfio_ap_mdev_reset_queue(struct vfio_ap_queue *q,
> > + unsigned int retry);
> > +
> > #endif /* _VFIO_AP_PRIVATE_H_ */
> >
> > base-commit: 9791581c049c10929e97098374dd1716a81fefcc
>
> Anyway, if I didn't entangle myself in the various branches, this seems
> sane.
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>
Thank you very much!
Regards,
Halil
next prev parent reply other threads:[~2021-01-21 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 7:20 [PATCH 1/1] s390/vfio-ap: No need to disable IRQ after queue reset Halil Pasic
2021-01-21 8:20 ` Cornelia Huck
2021-01-21 10:34 ` Halil Pasic [this message]
2021-01-22 8:24 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121113438.2e40c5f9.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=fiuczy@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).