From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21FD9C433E9 for ; Thu, 21 Jan 2021 16:45:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2B2E23A22 for ; Thu, 21 Jan 2021 16:45:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732886AbhAUQoz (ORCPT ); Thu, 21 Jan 2021 11:44:55 -0500 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:52135 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732681AbhAUQjW (ORCPT ); Thu, 21 Jan 2021 11:39:22 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 6AEA5580524; Thu, 21 Jan 2021 11:38:33 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 21 Jan 2021 11:38:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=jGeQp6cCdgRQb61rYx3MEZ5kn8M eELzWsDuny0yRFYw=; b=SRiREtqkD3dJbRr71G5KSiZ7ANboAAwVVTw9kq3m2Gn 03DtHyDdBA0/ZHBb7GXWXH8J9c7br/Yd8IvKhD3leABgjjZ/k11/MapTmzPNco3X LYP3HV89lOSlsUUeOHovLQYxyvWrTiB/2e/gXYO8+GK8BBxggH2N70WTZbwNcFKJ OFJ2XdUvUWDRnp/r6nQn9Jjns2yF9k2nRj8IG4dsERPZgiC2wNulFne6haT2pAhe v5et/hrzhSMqR0AjAJ31TrySZv3PpZvhdyQetuykK3qFSgF72MvsGsxwAt0tKivA YZBYe5FbA6drsht6sKDoaEWDajcCzBSDRmYnVe+ymAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=jGeQp6 cCdgRQb61rYx3MEZ5kn8MeELzWsDuny0yRFYw=; b=UTP4rOuBX7YVXF9N39RbTg uLPjVNQv+MIddZqkFLxuSreA5/hSqPoeal1uoOz9k/OxbYfEz9pGa/YZOD4iIIZn wEmPUERIAlzxskN0SzyuIGDb8INGdVlvxz/gVOOV0BKiSQ8yjiYJGAuVWD/e3yj1 P5QFqXobplP+/X3Yw9t9zaLyK8MQOYQJ1+8hiqw/6Ldxlgyl3eXGZmZHH15rYFpy TmUj17ZUGdGk/2WemnhEpinSBoFygaLtXE37zNYmklJ12VZu1r0MBSfpxrtICfzx vYvVHNyi941jsK/zXzuCllF3iJAYRqOI17OHEz47urZgc5t8bfAYtFDhepRFD3uA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeggdelgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id BF38B1080057; Thu, 21 Jan 2021 11:38:31 -0500 (EST) Date: Thu, 21 Jan 2021 17:38:30 +0100 From: Maxime Ripard To: Andre Przywara Cc: Chen-Yu Tsai , Jernej Skrabec , Icenowy Zheng , Linus Walleij , Rob Herring , =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Samuel Holland , Shuosheng Huang , Yangtao Li , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Ulf Hansson Subject: Re: [PATCH v3 02/21] mmc: sunxi: add support for A100 mmc controller Message-ID: <20210121163830.5fhrr3qx4kjbqj5y@gilmour> References: <20210118020848.11721-1-andre.przywara@arm.com> <20210118020848.11721-3-andre.przywara@arm.com> <20210118132854.yiwn7rnvcyexgqim@gilmour> <20210118155228.3bd0e909@slackpad.fritz.box> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ev4lppgespatcttv" Content-Disposition: inline In-Reply-To: <20210118155228.3bd0e909@slackpad.fritz.box> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ev4lppgespatcttv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andre, On Mon, Jan 18, 2021 at 03:52:28PM +0000, Andre Przywara wrote: > On Mon, 18 Jan 2021 14:28:54 +0100 > Maxime Ripard wrote: >=20 > Hi Maxime, >=20 > > On Mon, Jan 18, 2021 at 02:08:29AM +0000, Andre Przywara wrote: > > > From: Yangtao Li > > >=20 > > > This patch adds support for A100 MMC controller, which use word > > > address for internal dma. > > >=20 > > > Signed-off-by: Yangtao Li > > > Signed-off-by: Andre Przywara =20 > >=20 > > We should also disable the timings setup in probe to derive them from > > the DT. This is causing issues on some SoCs already, so it would be > > best to not make the situation worse >=20 > But only for those new SoCs, where we have the speed modes in the DT > in every case (so only new ones)? And this disabling would be > SoC/compatible string dependent? Happy to send a patch later if that is > what you were thinking about. Yeah, we should only do it for new SoCs at the moment, based on the compatible. I guess at some point we'll have to remove it for the older SoCs as well since we have reports of it failing for SoCs as old as the A20, but we'll probably want to make it as smooth as possible. Maxime --ev4lppgespatcttv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYAmuBgAKCRDj7w1vZxhR xar2AP0ZvOuZtBqouyeCYUoO43ULetRbYn4+luZtYdfkCy5wRwEAmk9MFsIvaryi 3Z1PylgeJOXUkjyhVGs+lWSsIYh91ww= =5rlm -----END PGP SIGNATURE----- --ev4lppgespatcttv--