From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A536BC43381 for ; Thu, 21 Jan 2021 22:58:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6373323A60 for ; Thu, 21 Jan 2021 22:58:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbhAUW6M (ORCPT ); Thu, 21 Jan 2021 17:58:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726789AbhAUW57 (ORCPT ); Thu, 21 Jan 2021 17:57:59 -0500 Received: from mail-qt1-x849.google.com (mail-qt1-x849.google.com [IPv6:2607:f8b0:4864:20::849]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D32A1C061786 for ; Thu, 21 Jan 2021 14:57:18 -0800 (PST) Received: by mail-qt1-x849.google.com with SMTP id h16so2233393qta.12 for ; Thu, 21 Jan 2021 14:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=uXaJ+OStKaU1TSDiW6h4CbV+WkJ9mG9O+r64LsV2Mn0=; b=nmTtBqSvr08bFOptKNcnSwo1YDeMJkZzF68xQek9c3YINaVsmTMySUDd2xXtLvWxWZ tjLmThb8Lfo+sR5bmrD4iEyakM5OrmBzghsoGrYqzxf/PKZd2CvPBvLi+n/9gOWDbezO 2e9kqUbeB00crKhHvlMJV9haXkGiaj0dAGkXdLm1XIxUOTvqLBMQSSF51OQ4AE9yDmwS DbvR3N1OiBNp1pOlE7TzGuGzqafNrowIP6/fhh3Uga6Z5mQKviWaB1gszrOkJgxDPtfq JgnT5LBRTxx+ipdKzvzSh1efd2VLLeCInjPxZoOTraBeMlQvCdZLHppUdXp0dv/EO2F5 x5wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=uXaJ+OStKaU1TSDiW6h4CbV+WkJ9mG9O+r64LsV2Mn0=; b=samQ+JZ88e5FSOOT/K8c8QuhBHud7TRoVsLMifvf6pqxnWs3AoF+fCpz/vA/FqF+uO JLBqpa92RvRGXXlVjxf/c3exDCr2w0EKwiGhmAiePGGzy7BJf6HGP9mIGaapXfSFhiye spGNW2bC179mksc53/d3ndWhS98RbJz4gLd1eZvNJ3pofrcUNewlGssfktHrCDmjyTaM EgV1n9oKQHMXgEyBybXovxHVdYr1NdQmkpBr64yfF+tajWGYP3PYZnc4OCV1PtkCV6Dc +F8nRy7LhjJ35HVmUxYgkXyyzl5447+4LaqOLYltffCQpaOAE8jFnxKekaKRBs1o9hSp 7mSg== X-Gm-Message-State: AOAM530gFXNVeJcaul2N5v08VV+QqZ333CiTs2L+Voe6yevEC1j/z/ki dZx958PRuocfcC3qf6/huIopmMMutjzBveA= X-Google-Smtp-Source: ABdhPJzZsp+6O4qLnPlS0yerTYDKRtyqqRjS5GVEnuxz1NCmThN07PoGdf5AN1Xru0GR5/LMb7l7tU/mTL9+x1U= Sender: "saravanak via sendgmr" X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:7220:84ff:fe09:fedc]) (user=saravanak job=sendgmr) by 2002:ad4:5a53:: with SMTP id ej19mr1822719qvb.61.1611269837945; Thu, 21 Jan 2021 14:57:17 -0800 (PST) Date: Thu, 21 Jan 2021 14:57:11 -0800 In-Reply-To: <20210121225712.1118239-1-saravanak@google.com> Message-Id: <20210121225712.1118239-2-saravanak@google.com> Mime-Version: 1.0 References: <20210121225712.1118239-1-saravanak@google.com> X-Mailer: git-send-email 2.30.0.280.ga3ce27912f-goog Subject: [PATCH v2 1/2] of: property: Add fw_devlink support for "gpio" and "gpios" binding From: Saravana Kannan To: Rob Herring , Frank Rowand , Greg Kroah-Hartman , Saravana Kannan Cc: linux-tegra , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , Geert Uytterhoeven , Jon Hunter , Marc Zyngier , Kevin Hilman , kernel-team@android.com, Rob Herring , Thierry Reding Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To provide backward compatibility for boards that use deprecated DT bindings, we need to add fw_devlink support for "gpio" and "gpios". We also need to ignore these properties on nodes with "gpio-hog" property because their gpio[s] are all supplied by the parent node. Cc: linux-tegra Cc: Linus Walleij Cc: Bartosz Golaszewski Cc: Greg Kroah-Hartman Cc: Geert Uytterhoeven Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Reviewed-by: Rob Herring Reviewed-by: Thierry Reding Tested-by: Jon Hunter Signed-off-by: Saravana Kannan --- drivers/of/property.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/drivers/of/property.c b/drivers/of/property.c index 5f9eed79a8aa..b2ea1951d937 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1271,6 +1271,28 @@ static struct device_node *parse_iommu_maps(struct device_node *np, return of_parse_phandle(np, prop_name, (index * 4) + 1); } +static struct device_node *parse_gpio_compat(struct device_node *np, + const char *prop_name, int index) +{ + struct of_phandle_args sup_args; + + if (strcmp(prop_name, "gpio") && strcmp(prop_name, "gpios")) + return NULL; + + /* + * Ignore node with gpio-hog property since its gpios are all provided + * by its parent. + */ + if (of_find_property(np, "gpio-hog", NULL)) + return NULL; + + if (of_parse_phandle_with_args(np, prop_name, "#gpio-cells", index, + &sup_args)) + return NULL; + + return sup_args.np; +} + static const struct supplier_bindings of_supplier_bindings[] = { { .parse_prop = parse_clocks, }, { .parse_prop = parse_interconnects, }, @@ -1296,6 +1318,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { { .parse_prop = parse_pinctrl6, }, { .parse_prop = parse_pinctrl7, }, { .parse_prop = parse_pinctrl8, }, + { .parse_prop = parse_gpio_compat, }, { .parse_prop = parse_regulators, }, { .parse_prop = parse_gpio, }, { .parse_prop = parse_gpios, }, -- 2.30.0.296.g2bfb1c46d8-goog