From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71735C433E0 for ; Fri, 22 Jan 2021 06:29:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FF18208C7 for ; Fri, 22 Jan 2021 06:29:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726943AbhAVG3A (ORCPT ); Fri, 22 Jan 2021 01:29:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726954AbhAVG1n (ORCPT ); Fri, 22 Jan 2021 01:27:43 -0500 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12B0DC0613D6 for ; Thu, 21 Jan 2021 22:27:03 -0800 (PST) Received: by mail-pf1-x432.google.com with SMTP id q131so3056705pfq.10 for ; Thu, 21 Jan 2021 22:27:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=svgrB85wDJvp1wFsJQnCVp+ank0Arsi8GO3FERYAPGc=; b=ux0UjAuQYmGVBrb8Ye8qm1tpjApuGIEbLNzDKfWG+sREKtOBhs9wc69kCk2XcGEVUh u4H3V16lDaQ13d/AsqE4nHLxmPe4u06EH1Ukvg1m+2aWKGTgxgUMmm0h9Dyvq3nJb8ZP wCFeHZ709a0RsxBpawIx7FvwlQZ8KLhnixCtMwH2xgNME8aSrvH+oC4TzP1Dr5/Q2t3Y N7tUbU7RSFbJcNRFLbM6VehvtjO8Sb5j3WRpjKSVSc63nhcKQUoNQNIRXe6oINWi8Mz6 tP5tfq11q/Tl8+KmTKFLM8pkvPvi50GMr6qKyC077jMTvm/URFFLSlHH/sqZHxmEpnqa qNmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=svgrB85wDJvp1wFsJQnCVp+ank0Arsi8GO3FERYAPGc=; b=rfWbwaXBT5tJ0Umi/JKMeNzTjbkhOEKz6GdkWU5570Sfheh3VZsdR1DkMBFyePT7PS NDI4wFZs2yDrWvsMRfFz0d8/lqeqZTECDn+EL9Bvbtvw09+fHGbVX6czl9FGlVnqHqC9 FPnzvcbUmAWt6Hc/iEOufGpWICBIs795fTHL4QusUZ8bprcRstVKndNrWgoysWxt1neK Xku9cmejBIwLxO4KHcZlsDeG7bGNoGPnd/UPexnbqQDAfrD4UBhlywWdJZxGzJggjCIM R3MiJHOBU/dcoSazsu4okiUmr/ewiCRzp2ad+u4DblTxBfvEtg+o0mFmyhx/sFFOqF5W qSAw== X-Gm-Message-State: AOAM530It6UHZVgmmBa64L5kMklivN9mzXGCm+H4cKlxqu1+yW6a2B1Z xCq4iSr8Md/pH4FNNHY2/v250A== X-Google-Smtp-Source: ABdhPJyYey8B/wZZECCKK/6z6M0ZdDm5dsyDljIPXQKsuXilPAqgZAz+8Uqbev9+vKmCz1YIcKVNQg== X-Received: by 2002:a17:90a:f2d2:: with SMTP id gt18mr3578692pjb.102.1611296822502; Thu, 21 Jan 2021 22:27:02 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id q2sm6678851pfj.32.2021.01.21.22.27.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jan 2021 22:27:01 -0800 (PST) Date: Fri, 22 Jan 2021 11:56:59 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Thierry Reding , Jonathan Hunter , linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , Sibi Sankar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() Message-ID: <20210122062659.qss3hef4kltfgciu@vireshk-i7> References: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> <71451eb2-46b2-1ea0-efcc-0811568159a4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <71451eb2-46b2-1ea0-efcc-0811568159a4@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22-01-21, 00:36, Dmitry Osipenko wrote: > 21.01.2021 14:17, Viresh Kumar пишет: > > dev_pm_opp_set_bw() is getting removed and dev_pm_opp_set_opp() should > > be used instead. Migrate to the new API. > > > > Signed-off-by: Viresh Kumar > > --- > > drivers/devfreq/tegra30-devfreq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > > index 117cad7968ab..d2477d7d1f66 100644 > > --- a/drivers/devfreq/tegra30-devfreq.c > > +++ b/drivers/devfreq/tegra30-devfreq.c > > @@ -647,7 +647,7 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq, > > return PTR_ERR(opp); > > } > > > > - ret = dev_pm_opp_set_bw(dev, opp); > > + ret = dev_pm_opp_set_opp(dev, opp); > > dev_pm_opp_put(opp); > > > > return ret; > > > > This patch introduces a very serious change that needs to be fixed. > > Now dev_pm_opp_set_opp() changes both clock rate and bandwidth, this is > unacceptable for this driver because it shall not touch the clock rate. > > I think dev_pm_opp_set_bw() can't be removed. I am wondering here on what would be a better solution, do what you said or introduce another helper like dev_pm_opp_clear_clk(), which will make sure the OPP core doesn't play with device's clk. -- viresh