From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B5EDC433E0 for ; Fri, 22 Jan 2021 13:06:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4326723444 for ; Fri, 22 Jan 2021 13:06:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727626AbhAVNFr (ORCPT ); Fri, 22 Jan 2021 08:05:47 -0500 Received: from mga06.intel.com ([134.134.136.31]:52985 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726739AbhAVNDL (ORCPT ); Fri, 22 Jan 2021 08:03:11 -0500 IronPort-SDR: 7lkUmEHSiP1kb5ePz6hKW+nXZ0z6ZEiZmiqs1xzEJ2+hgj9yveH1RxkAe2LNy1Zk3hDgAl+CpU 3i5MXyo3/UKA== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="240983067" X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="240983067" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 05:00:54 -0800 IronPort-SDR: XzZPcp38cb30QULsLcXsgLNu4kNWEm2c+0ePLWkyZqoP1WUAH3b3OtPGcyWJbbrJsHw31Kfcoa L2i9km9f35xQ== X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="357014636" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 05:00:50 -0800 Received: by lahna (sSMTP sendmail emulation); Fri, 22 Jan 2021 15:00:48 +0200 Date: Fri, 22 Jan 2021 15:00:48 +0200 From: Mika Westerberg To: Kai-Heng Feng Cc: rjw@rjwysocki.net, AceLan Kao , "Rafael J. Wysocki" , Greg Kroah-Hartman , Andy Shevchenko , Len Brown , "open list:ACPI" , open list Subject: Re: [PATCH] ACPI / device_sysfs: Prefer "compatible" modalias Message-ID: <20210122130048.GN1988617@lahna.fi.intel.com> References: <20210122125302.991591-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210122125302.991591-1-kai.heng.feng@canonical.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2021 at 08:53:02PM +0800, Kai-Heng Feng wrote: > Commit 8765c5ba1949 ("ACPI / scan: Rework modalias creation when > "compatible" is present") may create two "MODALIAS=" in uevent file if > conditions are met. > > This breaks systemd-udevd, which assumes each "key" in uevent file is > unique. The internal implementation of systemd-udevd overwrites the > first MODALIAS with the second one, so its kmod rule doesn't load driver > for the first MODALIAS. > > So if both ACPI modalias and OF modalias are present, use the latter > one to ensure there's only one MODALIAS. > > Reference: https://github.com/systemd/systemd/pull/18163 > Cc: AceLan Kao > Cc: "Rafael J. Wysocki" > Cc: Greg Kroah-Hartman > Cc: Andy Shevchenko > Suggested-by: Mika Westerberg > Fixes: 8765c5ba1949 ("ACPI / scan: Rework modalias creation when "compatible" is present") > Signed-off-by: Kai-Heng Feng Reviewed-by: Mika Westerberg